From patchwork Thu May 2 07:26:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Doron X-Patchwork-Id: 1094025 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="dQviOb+S"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44vnNW5GD7z9s9T for ; Thu, 2 May 2019 17:44:59 +1000 (AEST) Received: from localhost ([127.0.0.1]:46734 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hM6On-0001qW-Gk for incoming@patchwork.ozlabs.org; Thu, 02 May 2019 03:44:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59728) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hM69y-0004nl-Vx for qemu-devel@nongnu.org; Thu, 02 May 2019 03:29:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hM69o-0002le-Rf for qemu-devel@nongnu.org; Thu, 02 May 2019 03:29:34 -0400 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:54406) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hM69i-0000Wg-Az for qemu-devel@nongnu.org; Thu, 02 May 2019 03:29:23 -0400 Received: by mail-wm1-x343.google.com with SMTP id b10so1274932wmj.4 for ; Thu, 02 May 2019 00:27:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7xWdg5J6VC6HFdEkoiuvTsAB/KgJAJp/2excD9374G8=; b=dQviOb+SCs5MNGX57Qf4qTqLp91xrJAzjlGahjovPhrZCLy094ZyU0aVpaHj2ldxpX GfDuDxRRQFjXHFlI7REqyyvNDKY8kfIl7v+SOxTNsgQZET6APgGTXWiHiF6cv+OMkrxq 6VUCeeUEH0waRBjQU+tFHD7RNTzxyM6UyhAEYa+Lv/WfqOJAGfQdD1MrLTDx/yQ9Ol6H 4D9N3s0mfZFFWx93F5+R97MRMrcmpJw2jWrr7FDhDCzeweG8KOpTlbtKOmSC6vVIt8K0 2/jTWt/kTIGTs8hWMhdMojbk0Or8rKfYLFBnUhMVsaOpC0zzvco6u3GISo+CfjGudL9c 0Khw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7xWdg5J6VC6HFdEkoiuvTsAB/KgJAJp/2excD9374G8=; b=p+FH3A5eaBf8y8dYd6edf4PsXKB7bT0sk9d3kFtQy2MlyO8WMN8v6vq16LjRcwJfD1 Oqp2Wgv3vShGAN++lxuL0J8Obb92slbFHqOEBUpRTyayUl/v67hc1JPcTNVvVDKbPyNs VODd46Ejsn8r0c/9/1SZgxGvIp2cftZyEqqP3kRtBXRdstKNag+pJPB7eZwCESsyyzhG njFp44pGpkTOEJ+Dgmg9lK4VP3BpQd2bw3oSqB8BQ/L15mCQ4FBSfk+gmSIzjuaz/+W4 wnjZDjkJH9Iq8tajz+BxdcGDBxeeYaqexnpgDBPkHCY+sqqvSMlqk6J5VyRoIqgb8LBl CiIg== X-Gm-Message-State: APjAAAVrpGV5sB718cEc00u9Sf8DpNtLKOm1Ja4rgNtenBhU3PteiiA0 4OaKqP+53Q5hJ0Sfs18kn0YpRxhq X-Google-Smtp-Source: APXvYqyN/k3ocepivdLQFjmB17xcclQKa67sESmX57WNLxzgotCOJUDPxee36+sPM0tHUBp44cnJ9Q== X-Received: by 2002:a1c:d181:: with SMTP id i123mr1228978wmg.33.1556782033095; Thu, 02 May 2019 00:27:13 -0700 (PDT) Received: from localhost.localdomain ([176.230.64.186]) by smtp.gmail.com with ESMTPSA id z5sm8769289wre.70.2019.05.02.00.27.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2019 00:27:12 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Thu, 2 May 2019 10:26:25 +0300 Message-Id: <20190502072641.4667-12-arilou@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190502072641.4667-1-arilou@gmail.com> References: <20190502072641.4667-1-arilou@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::343 Subject: [Qemu-devel] [PATCH v8 11/27] gdbstub: Implement write memory (M pkt) with new infra X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: liran.alon@oracle.com, alex.bennee@linaro.org, Jon Doron Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Jon Doron --- gdbstub.c | 51 +++++++++++++++++++++++++++++++++------------------ 1 file changed, 33 insertions(+), 18 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index e9a3d0c2bc..8dc2e1d507 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1685,6 +1685,31 @@ static void handle_get_reg(GdbCmdContext *gdb_ctx, void *user_ctx) put_packet(gdb_ctx->s, gdb_ctx->str_buf); } +static void handle_write_mem(GdbCmdContext *gdb_ctx, void *user_ctx) +{ + if (gdb_ctx->num_params < 3) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + /* hextomem() reads 2*len bytes */ + if (gdb_ctx->params[1].val_ull > strlen(gdb_ctx->params[2].data) / 2) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + hextomem(gdb_ctx->mem_buf, gdb_ctx->params[2].data, + gdb_ctx->params[1].val_ull); + if (target_memory_rw_debug(gdb_ctx->s->g_cpu, gdb_ctx->params[0].val_ull, + gdb_ctx->mem_buf, + gdb_ctx->params[1].val_ull, true)) { + put_packet(gdb_ctx->s, "E14"); + return; + } + + put_packet(gdb_ctx->s, "OK"); +} + static int gdb_handle_packet(GDBState *s, const char *line_buf) { CPUState *cpu; @@ -1893,24 +1918,14 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) } break; case 'M': - addr = strtoull(p, (char **)&p, 16); - if (*p == ',') - p++; - len = strtoull(p, (char **)&p, 16); - if (*p == ':') - p++; - - /* hextomem() reads 2*len bytes */ - if (len > strlen(p) / 2) { - put_packet (s, "E22"); - break; - } - hextomem(mem_buf, p, len); - if (target_memory_rw_debug(s->g_cpu, addr, mem_buf, len, - true) != 0) { - put_packet(s, "E14"); - } else { - put_packet(s, "OK"); + { + static const GdbCmdParseEntry write_mem_cmd_desc = { + .handler = handle_write_mem, + .cmd = "M", + .cmd_startswith = 1, + .schema = "L,L:s0" + }; + cmd_parser = &write_mem_cmd_desc; } break; case 'p':