From patchwork Fri Apr 26 04:35:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Doron X-Patchwork-Id: 1091271 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="GuxftqfD"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44r1xn75N3z9s47 for ; Fri, 26 Apr 2019 14:57:17 +1000 (AEST) Received: from localhost ([127.0.0.1]:39243 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJsvD-0001Uj-UB for incoming@patchwork.ozlabs.org; Fri, 26 Apr 2019 00:57:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJsmm-0000dG-1v for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:48:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJsat-0004GT-C9 for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:36:17 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:35593) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJsar-0004DS-Ta for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:36:14 -0400 Received: by mail-wm1-x344.google.com with SMTP id y197so2376235wmd.0 for ; Thu, 25 Apr 2019 21:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lYm7IhGBrxn52sVAeIC90HrrQ0q55SD5y2VdGObDHgY=; b=GuxftqfDBOC6Gh/IgmEfBv1W4NhNRan/qGK3Dw5MJKzDR69QPEUivIShut7Q7Axv5d LKh7QfQq9c6M60hcAgxOMxUeyjEjwAuVFqR9j6MYmF06zjoJT2KFjxHqViZmXJp/ZL01 xP8wxFFZwHm0XjXTyMgO++xCRLbZhYdFCmaJSPeQlGOOETRqQQ/4gM53bFpeCsZOxFG4 z2rkIs+OWj5DdwLn1nzt3xAQgo0jKiUpkaDmJwkizn2FaTzezdh7IvGXF/TWJJV/tw25 hUUeYx/fSkksiQd32hwBEXvT/T8loySXGKbUvr4xRhcDK0LPNH93hcQLAAlg3MXTeIhu pUoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lYm7IhGBrxn52sVAeIC90HrrQ0q55SD5y2VdGObDHgY=; b=CMbpIzFDYj3nbA1E9aKA/K7yCB75hlD271s/rnQVKcNAMhVGFsDbcuwqsGrR4r8GMX QnjyfklMsA0n7mI8oG1uWIBY6qL8QMeYECzajjdcKF0SSoBkwhcFTkI0Ecm3D96/Plah v+ceHwtznwqvtb/7+cm6bFhd15AqpBAlniEV/EgRj0uW3nEvQTlCiQhu9zWU4aj5Cbwf NNLABiHbavsMEW3ZO/Oii2IOf91EaO/mfnGxsporgIRFNuNBC763DaASJ4baZB8Lh8bS ctz3rEqBtFfsrlQJEpVZ4BPRQveTfwyMbBX2Kf+5+OBLorzRLQM6YL54lzRzudWjN7N0 TFFA== X-Gm-Message-State: APjAAAXOFwAKEmJOMYhtnQbRmHbH0fZmLQoCM8R49p+B9Giu1zaxMgDH BaP/3RYEA7gUAF41WfSmD9omLZol X-Google-Smtp-Source: APXvYqwifvW1CP6iF7M4v4S4Du7nNXfC0gtBqNcSoi3t0MIFYMiTlpYu6iA2UttVNjJeMUSrhdCVuA== X-Received: by 2002:a1c:a103:: with SMTP id k3mr6221401wme.8.1556253372530; Thu, 25 Apr 2019 21:36:12 -0700 (PDT) Received: from localhost.localdomain (bzq-79-178-247-46.red.bezeqint.net. [79.178.247.46]) by smtp.gmail.com with ESMTPSA id h5sm3467088wmf.38.2019.04.25.21.36.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 21:36:11 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Fri, 26 Apr 2019 07:35:40 +0300 Message-Id: <20190426043558.6888-4-arilou@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190426043558.6888-1-arilou@gmail.com> References: <20190426043558.6888-1-arilou@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 Subject: [Qemu-devel] [PATCH v7 03/21] gdbstub: Implement thread_alive (T pkt) with new infra X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, Jon Doron Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Jon Doron --- gdbstub.c | 43 ++++++++++++++++++++++++++++++++----------- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 621d689868..c47ef7dd9c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1498,6 +1498,30 @@ static void handle_detach(GdbCmdContext *gdb_ctx, void *user_ctx) put_packet(s, "OK"); } +static void handle_thread_alive(GdbCmdContext *gdb_ctx, void *user_ctx) +{ + CPUState *cpu; + + if (!gdb_ctx->num_params) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + if (gdb_ctx->params[0].thread_id.kind == GDB_READ_THREAD_ERR) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + cpu = gdb_get_cpu(gdb_ctx->s, gdb_ctx->params[0].thread_id.pid, + gdb_ctx->params[0].thread_id.tid); + if (!cpu) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + put_packet(gdb_ctx->s, "OK"); +} + static int gdb_handle_packet(GDBState *s, const char *line_buf) { CPUState *cpu; @@ -1798,17 +1822,14 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) } break; case 'T': - thread_kind = read_thread_id(p, &p, &pid, &tid); - if (thread_kind == GDB_READ_THREAD_ERR) { - put_packet(s, "E22"); - break; - } - cpu = gdb_get_cpu(s, pid, tid); - - if (cpu != NULL) { - put_packet(s, "OK"); - } else { - put_packet(s, "E22"); + { + static const GdbCmdParseEntry thread_alive_cmd_desc = { + .handler = handle_thread_alive, + .cmd = "T", + .cmd_startswith = 1, + .schema = "t0" + }; + cmd_parser = &thread_alive_cmd_desc; } break; case 'q':