From patchwork Fri Apr 26 04:35:53 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Doron X-Patchwork-Id: 1091260 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HNzEwa2N"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44r1mX09Gyz9s47 for ; Fri, 26 Apr 2019 14:49:16 +1000 (AEST) Received: from localhost ([127.0.0.1]:39098 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJsnR-0000uL-Sc for incoming@patchwork.ozlabs.org; Fri, 26 Apr 2019 00:49:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJsma-0000dG-DV for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:48:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJsbO-0004pp-1H for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:36:46 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:40454) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJsbN-0004ph-Rg for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:36:45 -0400 Received: by mail-wm1-x344.google.com with SMTP id h11so2331908wmb.5 for ; Thu, 25 Apr 2019 21:36:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EShIhnyclfVo57FnSdW5zX6W2mQ/1wfNmEis7PfWfkY=; b=HNzEwa2Nxqpej16GQ5d2qNjgFjBlQH0uqqIPgcirFaL34jxlcAFZ/bLLU/zT3LDq4u JuYTXWUGL8yTCXyTPLD9WnFyRxSCEgEL2K7w23ZkzwhJ9YdL/n++xMLWoTIr209QVdol 3W2F6jg+7iL45iSxs+4SBW2FoH8D2IdXW5i5awh1P3RcX9Q527ccXw5dlB52gWIGZy/M pyauS1V7RDC3hCum1SenQb9UI9c/ga5eP9RFF1sVR/XGCZlhgOqY49fDktQfYdcWDlpb yjTWR5Cv1ie+udoGodF3VWdef7dPd7isa1d7T7jpA6XOx/jbLIrheP2PCn+V9VcsJniq ZVGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EShIhnyclfVo57FnSdW5zX6W2mQ/1wfNmEis7PfWfkY=; b=CkfHkmLdS5bAJrW2yiqXi3bxc0gNq7DK7IbKF4bn6+T9Cp5IOTiIpBE8tSMQZko4sE 7AKP6frMMWvX+l7UMMMYtdJSGtI2LCOk00t99Ig0Qh3GZhSTPK6VsON6eOM/9P5TJTwp TxcSW2xtFAGlqCxtTZ1OfnupNFFJ2Gh/0H8WWY9IOdjIevkyhNMvCAV5KyFrdR/RAGws CKmegzDQZlvWgiGXFJ0jcP3iAYbHfr23Xo32OaurZggChwVveQhNQGkO5GBdPRRyirly pyqKm81i4pleoXcP1wo1fJDkMb7RIiLcnhf0fV1XVDIunUqii+9oBDgG7WOhCA3zT2/b yTNA== X-Gm-Message-State: APjAAAWtqwHS9qEAhprhR4S4MxUHFD1041QRoJsz8+r2i9cxZPke15pA okuLpQuSZPVamDNrGwx6sPeYrXSz X-Google-Smtp-Source: APXvYqwBLp/t7BAGM6ZRRHdjlu3iJYxA4T1kyxdub4rArJXGfgUbmy5XS7EH4JHyaFaOv8AmHls8Tg== X-Received: by 2002:a1c:1903:: with SMTP id 3mr5959439wmz.103.1556253404373; Thu, 25 Apr 2019 21:36:44 -0700 (PDT) Received: from localhost.localdomain (bzq-79-178-247-46.red.bezeqint.net. [79.178.247.46]) by smtp.gmail.com with ESMTPSA id h5sm3467088wmf.38.2019.04.25.21.36.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 21:36:43 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Fri, 26 Apr 2019 07:35:53 +0300 Message-Id: <20190426043558.6888-17-arilou@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190426043558.6888-1-arilou@gmail.com> References: <20190426043558.6888-1-arilou@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 Subject: [Qemu-devel] [PATCH v7 16/21] gdbstub: Implement step (s pkt) with new infra X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, Jon Doron Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Jon Doron --- gdbstub.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 9fe130f30d..9b0556f8be 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1805,6 +1805,16 @@ static void handle_file_io(GdbCmdContext *gdb_ctx, void *user_ctx) gdb_continue(gdb_ctx->s); } +static void handle_step(GdbCmdContext *gdb_ctx, void *user_ctx) +{ + if (gdb_ctx->num_params) { + gdb_set_cpu_pc(gdb_ctx->s, (target_ulong)gdb_ctx->params[0].val_ull); + } + + cpu_single_step(gdb_ctx->s->c_cpu, sstep_flags); + gdb_continue(gdb_ctx->s); +} + static int gdb_handle_packet(GDBState *s, const char *line_buf) { CPUState *cpu; @@ -1937,13 +1947,16 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) } break; case 's': - if (*p != '\0') { - addr = strtoull(p, (char **)&p, 16); - gdb_set_cpu_pc(s, addr); + { + static const GdbCmdParseEntry step_cmd_desc = { + .handler = handle_step, + .cmd = "s", + .cmd_startswith = 1, + .schema = "L0" + }; + cmd_parser = &step_cmd_desc; } - cpu_single_step(s->c_cpu, sstep_flags); - gdb_continue(s); - return RS_IDLE; + break; case 'F': { static const GdbCmdParseEntry file_io_cmd_desc = {