From patchwork Fri Apr 26 04:35:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Doron X-Patchwork-Id: 1091258 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="SF69tbtu"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44r1m539bsz9s47 for ; Fri, 26 Apr 2019 14:48:53 +1000 (AEST) Received: from localhost ([127.0.0.1]:39092 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJsn5-0000fw-5R for incoming@patchwork.ozlabs.org; Fri, 26 Apr 2019 00:48:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJsmG-0000dE-8i for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:48:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJsbJ-0004lK-11 for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:36:41 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:37710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJsbI-0004k6-R4 for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:36:40 -0400 Received: by mail-wm1-x344.google.com with SMTP id y5so1351800wma.2 for ; Thu, 25 Apr 2019 21:36:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b1bpFqGwMibMAfq1pbDbHkF4Xk3yQKA0SG1CtWad0g4=; b=SF69tbtuEDfg+zVkwn3CyXSc7922uL/xeUTg2YwU2RWtPLiahhSeWdg7vTicTpoF/C lFxvg6MxTz1aqgpaTj+RlrkdR4pj96d+ja1btTuhI4xri/WdAiBTYaVksB90lfYsyREJ pYMZRK532vLySjDfA1ok8oH6wePv7eb7VlNLJuraxhOaPo8PGTSB/HEMx5OakAFBWhV1 gZifn50K8LG6hRMt7s1dfHzN13fVh+hGVC3ABmp83w+buVz8eWfiKGlUMFpL7miTyQnb irU1W1V/D1ah0ExcRFy2wxHKOsQ9qY7Ps+iOAPEZhG1nrn0hs0iULJLJ+OrGKbKEl3sY SAYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b1bpFqGwMibMAfq1pbDbHkF4Xk3yQKA0SG1CtWad0g4=; b=OpdbUNzst2os4Hzpas2y7O2+n/k6EG6Nuw9UPazw3UykTaufn5jsN5l8bYFVG8CJsM HTTwvlKX9vvbBZdQVC3D3yHhlUn8+BZk8ZN3ClBaFLnIHa4ECQCn0rzjCsQsjSHOT8vF VrEGhsJ1ekgzXXKmlSbb09jdpve8+8ImS64QJN/f8Qijr9UtPFt+vf6AsimMRbEwglhn Ksxcwvszj6LXtG+XS1AFPVhVZXEMiLl/MZ/09cueySHhywm7EULBl1K+i6/ZxwJQfZFX uhA4xeBnJrLB8VQROgvlnsNdkTpkUfTh4LlUXvjnFtO1rJVjdtwI/SoaIMPK72Pzy0Xn YRhA== X-Gm-Message-State: APjAAAU9c20FOZHZooQ7J2rpeHTv3E0Ry4MN3m5b7kVymRERyP9X13+8 laatLTXt42UxdXiw5hezvR2CU5g6 X-Google-Smtp-Source: APXvYqzOaBgVLX8/6c8SKgeDQv7EqNAdkemjvAZwCtNWrHPqkDAuRhldM4ZoW3o3pM8xqqdHv5qdFw== X-Received: by 2002:a7b:cd93:: with SMTP id y19mr5830979wmj.113.1556253399095; Thu, 25 Apr 2019 21:36:39 -0700 (PDT) Received: from localhost.localdomain (bzq-79-178-247-46.red.bezeqint.net. [79.178.247.46]) by smtp.gmail.com with ESMTPSA id h5sm3467088wmf.38.2019.04.25.21.36.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 21:36:37 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Fri, 26 Apr 2019 07:35:51 +0300 Message-Id: <20190426043558.6888-15-arilou@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190426043558.6888-1-arilou@gmail.com> References: <20190426043558.6888-1-arilou@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 Subject: [Qemu-devel] [PATCH v7 14/21] gdbstub: Implement read all registers (g pkt) with new infra X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, Jon Doron Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Jon Doron --- gdbstub.c | 31 +++++++++++++++++++++++-------- 1 file changed, 23 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index adfe39b3a3..3478ac778d 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1757,6 +1757,21 @@ static void handle_write_all_regs(GdbCmdContext *gdb_ctx, void *user_ctx) put_packet(gdb_ctx->s, "OK"); } +static void handle_read_all_regs(GdbCmdContext *gdb_ctx, void *user_ctx) +{ + target_ulong addr, len; + + cpu_synchronize_state(gdb_ctx->s->g_cpu); + len = 0; + for (addr = 0; addr < gdb_ctx->s->g_cpu->gdb_num_g_regs; addr++) { + len += gdb_read_register(gdb_ctx->s->g_cpu, gdb_ctx->mem_buf + len, + addr); + } + + memtohex(gdb_ctx->str_buf, gdb_ctx->mem_buf, len); + put_packet(gdb_ctx->s, gdb_ctx->str_buf); +} + static int gdb_handle_packet(GDBState *s, const char *line_buf) { CPUState *cpu; @@ -1764,7 +1779,7 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) CPUClass *cc; const char *p; uint32_t pid, tid; - int ch, reg_size, type, res; + int ch, type, res; uint8_t mem_buf[MAX_PACKET_LENGTH]; char buf[sizeof(mem_buf) + 1 /* trailing NUL */]; char thread_id[16]; @@ -1923,14 +1938,14 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) } break; case 'g': - cpu_synchronize_state(s->g_cpu); - len = 0; - for (addr = 0; addr < s->g_cpu->gdb_num_g_regs; addr++) { - reg_size = gdb_read_register(s->g_cpu, mem_buf + len, addr); - len += reg_size; + { + static const GdbCmdParseEntry read_all_regs_cmd_desc = { + .handler = handle_read_all_regs, + .cmd = "g", + .cmd_startswith = 1 + }; + cmd_parser = &read_all_regs_cmd_desc; } - memtohex(buf, mem_buf, len); - put_packet(s, buf); break; case 'G': {