From patchwork Fri Apr 26 04:35:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Doron X-Patchwork-Id: 1091280 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kgmoqyCI"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44r23N2wpvz9s47 for ; Fri, 26 Apr 2019 15:02:08 +1000 (AEST) Received: from localhost ([127.0.0.1]:39322 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJszu-0006QD-7O for incoming@patchwork.ozlabs.org; Fri, 26 Apr 2019 01:02:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJsmf-0000dG-Bz for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:48:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJsb6-0004WP-Db for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:36:29 -0400 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:43048) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJsb6-0004Vy-7S for qemu-devel@nongnu.org; Fri, 26 Apr 2019 00:36:28 -0400 Received: by mail-wr1-x441.google.com with SMTP id a12so2410826wrq.10 for ; Thu, 25 Apr 2019 21:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C5wVxSSu9B3yjrVL1kbdSqghY5biwyr5/S2ykkoUubY=; b=kgmoqyCIYRjiJsanjHfvhXOXnK9d/A+YXxNeDoiohUdikM5ponc+AdUmcqfFV0d9Lg wXhed/bbYuy4xwLvftaNx6EnFeVvc6oEnvdPRd3Y7HZX18CN2BpyU1DEw379xd3JMmg1 IGEeYM7fAFj2x4xKY7gKDli7mNC5WktvIZSnrzp85E0/d+pLsP7Kfzna/PhkmnUK2hix gTZf9nP4UFExxdIPi8edUKmRf9ghY3p0ZMKtmYCsJh5Wv/KXWBoZIISCilrogmYfr8hA +jmTPHmVqXHGl2RsJPWyUIakReK9aLJKXhBS4o+cEb1/fUsG3Fgmlk5BG5cJYHsPd2CY /Y1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C5wVxSSu9B3yjrVL1kbdSqghY5biwyr5/S2ykkoUubY=; b=ucJZAnULqCkGZPcxuPQZo+JvQHJEawa8+fGQLTwH/QPN6EPG/yxLKwY4Q5zANjC5Wg VV33oCAblT6WQtVL5bNUtHU1VSQUVY/tdoskJolsCMgmO3Mh2qXrZhj5lXS1zcm8JrKQ pyARvtnThfgsSd7lGEeN/+JMr9bdj5hLDOzgC42JJA16JnN80n0TAKV/mHIi2LFOkiaU /wSvYKHfdVc4y8l4b2+mlo3bGNvxFgvg5G/RfBCCpPB8BuO6VAqDg7NOJYLL32Mf6bzY JYdiByYM3vSaMwkF+K+11FcltnpetO6s0IdPNB9T0v+5W5d5hMHsjdfTed/JOQPTmwni bDjA== X-Gm-Message-State: APjAAAW9KeNbRIrQajgRYztiP8Z8wnTsuLoSxd2ExeO+pTSwz7UYdGcY FQe2ul9+DVOMMhvlXqqp6+v/SpiU X-Google-Smtp-Source: APXvYqx+6F/TJJBApYN5dKwOVuVNDH6IEpPXTv0lzsS6nGUEOONWZJwyF8rXeknJGbQrgFfAV+oeGQ== X-Received: by 2002:a5d:5542:: with SMTP id g2mr6028705wrw.58.1556253386319; Thu, 25 Apr 2019 21:36:26 -0700 (PDT) Received: from localhost.localdomain (bzq-79-178-247-46.red.bezeqint.net. [79.178.247.46]) by smtp.gmail.com with ESMTPSA id h5sm3467088wmf.38.2019.04.25.21.36.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 21:36:24 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Fri, 26 Apr 2019 07:35:47 +0300 Message-Id: <20190426043558.6888-11-arilou@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190426043558.6888-1-arilou@gmail.com> References: <20190426043558.6888-1-arilou@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 Subject: [Qemu-devel] [PATCH v7 10/21] gdbstub: Implement get register (p pkt) with new infra X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.bennee@linaro.org, Jon Doron Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Jon Doron --- gdbstub.c | 50 ++++++++++++++++++++++++++++++++++++++------------ 1 file changed, 38 insertions(+), 12 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 10e3f12a68..e9a3d0c2bc 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1655,6 +1655,36 @@ static void handle_set_reg(GdbCmdContext *gdb_ctx, void *user_ctx) put_packet(gdb_ctx->s, "OK"); } +static void handle_get_reg(GdbCmdContext *gdb_ctx, void *user_ctx) +{ + int reg_size; + + /* + * Older gdb are really dumb, and don't use 'g' if 'p' is avaialable. + * This works, but can be very slow. Anything new enough to + * understand XML also knows how to use this properly. + */ + if (!gdb_has_xml) { + put_packet(gdb_ctx->s, ""); + return; + } + + if (!gdb_ctx->num_params) { + put_packet(gdb_ctx->s, "E14"); + return; + } + + reg_size = gdb_read_register(gdb_ctx->s->g_cpu, gdb_ctx->mem_buf, + gdb_ctx->params[0].val_ull); + if (!reg_size) { + put_packet(gdb_ctx->s, "E14"); + return; + } + + memtohex(gdb_ctx->str_buf, gdb_ctx->mem_buf, reg_size); + put_packet(gdb_ctx->s, gdb_ctx->str_buf); +} + static int gdb_handle_packet(GDBState *s, const char *line_buf) { CPUState *cpu; @@ -1884,18 +1914,14 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) } break; case 'p': - /* Older gdb are really dumb, and don't use 'g' if 'p' is avaialable. - This works, but can be very slow. Anything new enough to - understand XML also knows how to use this properly. */ - if (!gdb_has_xml) - goto unknown_command; - addr = strtoull(p, (char **)&p, 16); - reg_size = gdb_read_register(s->g_cpu, mem_buf, addr); - if (reg_size) { - memtohex(buf, mem_buf, reg_size); - put_packet(s, buf); - } else { - put_packet(s, "E14"); + { + static const GdbCmdParseEntry get_reg_cmd_desc = { + .handler = handle_get_reg, + .cmd = "p", + .cmd_startswith = 1, + .schema = "L0" + }; + cmd_parser = &get_reg_cmd_desc; } break; case 'P':