From patchwork Thu Apr 25 13:26:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Doron X-Patchwork-Id: 1090832 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EQ9x3BX8"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44qdt62R51z9s7T for ; Thu, 25 Apr 2019 23:52:41 +1000 (AEST) Received: from localhost ([127.0.0.1]:57565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJenm-0004cr-DE for incoming@patchwork.ozlabs.org; Thu, 25 Apr 2019 09:52:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJePe-0008Ev-9A for qemu-devel@nongnu.org; Thu, 25 Apr 2019 09:27:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJePc-0000xG-0A for qemu-devel@nongnu.org; Thu, 25 Apr 2019 09:27:42 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:47050) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJePa-0000pV-E6 for qemu-devel@nongnu.org; Thu, 25 Apr 2019 09:27:38 -0400 Received: by mail-wr1-x443.google.com with SMTP id t17so30292125wrw.13 for ; Thu, 25 Apr 2019 06:27:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=14VPjA11kd7BNRAewIUYoLzDl7QlL5dAdw5dQ8aqYZo=; b=EQ9x3BX8jvDHXr7ahkoFy6GLKpEIu5UVPKOvmNR2HvE+w/kvv/NBR0cY29+qkT20t+ ovVil29wdl7HpaQPoohQ2NVAqdU889qPKPS/inhOCg8HK+wS8ffCPuXf9XE3kR8fZv20 1hpp8oB42ShGQoWNk48X1QROYpG5NOkKvf/2PZ9QwNlKky2Khs/af8y99giCVJiQdn1C 6xZS8XqCmpfLImiJ7hE5UesV4SFg2U83uXnLfLorfMidphqaAKYN70ArFGbMpkYmEGLc v+aaGM7LJt9ZZjUMSQrlZ80mtPuv1MLUVUF75J/gEphR5+lw/uFwudJuZG7SG3+3Wq/8 ztMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=14VPjA11kd7BNRAewIUYoLzDl7QlL5dAdw5dQ8aqYZo=; b=XqDmKatIi5EUgHrSwYxXaVkFLSyfBiUuWDv5J7DD6SFTCyB88IX09P8CbepJwryGUF Zxf4ivhObwTolwoi2VysFx8EEaJt1dA5EXHTrONo+Bv1N7Y6/BTSOhDFTOJR0ZqXkYMO HTJYUf/S5ODA2vsmikjnVQPgXcOWGhqrluru+t/ZxZoNCsL755dTzKfGfHjjvUjKtlGy 17NiBkIi+vsL/WWzc9lZQry2Sy+wUusAsGTEpX8mnlZCLrseeb9lX2ld7+dea+ZawYoE nO4c52TjVLbI4Sbegvbs06sUojHSJzr+iZRqQxMCM4Ze2Owyhyf+mCUKqx+t6eUZV8+w Ov6A== X-Gm-Message-State: APjAAAXuuG6YbfsMsV7FVqvFs1sq9N6Wi0GnSfD3NRSoSO8/ePXFKkYn 6wvEhh/Jl+HtESVJWpTUB2/Un6Hf X-Google-Smtp-Source: APXvYqzZ1PYp7F9RnEny29x2lRUz9/RAI5cjv9rjQzqoRQanBIIYPWsLoz/GA5l0i2I9ptiZ1upIQQ== X-Received: by 2002:a5d:4707:: with SMTP id y7mr9648503wrq.185.1556198852822; Thu, 25 Apr 2019 06:27:32 -0700 (PDT) Received: from localhost.localdomain (bzq-79-178-247-46.red.bezeqint.net. [79.178.247.46]) by smtp.gmail.com with ESMTPSA id y4sm2316540wrt.34.2019.04.25.06.27.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 06:27:30 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Thu, 25 Apr 2019 16:26:23 +0300 Message-Id: <20190425132636.31636-9-arilou@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190425132636.31636-1-arilou@gmail.com> References: <20190425132636.31636-1-arilou@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PATCH v6 08/21] gdbstub: Implement remove breakpoint (z pkt) with new infra X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jon Doron Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Jon Doron --- gdbstub.c | 49 ++++++++++++++++++++++++++++++++----------------- 1 file changed, 32 insertions(+), 17 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 8e0446d305..80f2a92da6 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1612,6 +1612,29 @@ static void handle_insert_bp(GdbCmdContext *gdb_ctx, void *user_ctx) put_packet(gdb_ctx->s, "E22"); } +static void handle_remove_bp(GdbCmdContext *gdb_ctx, void *user_ctx) +{ + int res; + + if (gdb_ctx->num_params < 3) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + res = gdb_breakpoint_remove(gdb_ctx->params[1].val_ull, + gdb_ctx->params[2].val_ull, + gdb_ctx->params[0].val_ul); + if (res >= 0) { + put_packet(gdb_ctx->s, "OK"); + return; + } else if (res == -ENOSYS) { + put_packet(gdb_ctx->s, ""); + return; + } + + put_packet(gdb_ctx->s, "E22"); +} + static int gdb_handle_packet(GDBState *s, const char *line_buf) { CPUState *cpu; @@ -1878,23 +1901,15 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) } break; case 'z': - type = strtoul(p, (char **)&p, 16); - if (*p == ',') - p++; - addr = strtoull(p, (char **)&p, 16); - if (*p == ',') - p++; - len = strtoull(p, (char **)&p, 16); - if (ch == 'Z') - res = gdb_breakpoint_insert(addr, len, type); - else - res = gdb_breakpoint_remove(addr, len, type); - if (res >= 0) - put_packet(s, "OK"); - else if (res == -ENOSYS) - put_packet(s, ""); - else - put_packet(s, "E22"); + { + static const GdbCmdParseEntry remove_bp_cmd_desc = { + .handler = handle_remove_bp, + .cmd = "z", + .cmd_startswith = 1, + .schema = "l?L?L0" + }; + cmd_parser = &remove_bp_cmd_desc; + } break; case 'H': {