From patchwork Thu Apr 25 13:26:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Doron X-Patchwork-Id: 1090855 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="lAZItkvB"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44qf3r3600z9s9N for ; Fri, 26 Apr 2019 00:01:12 +1000 (AEST) Received: from localhost ([127.0.0.1]:57904 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJew1-0003Ka-CW for incoming@patchwork.ozlabs.org; Thu, 25 Apr 2019 10:01:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60699) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJeQ6-0000EG-Ex for qemu-devel@nongnu.org; Thu, 25 Apr 2019 09:28:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJeQ5-0001og-LJ for qemu-devel@nongnu.org; Thu, 25 Apr 2019 09:28:10 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]:39578) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJeQ5-0001ln-Et for qemu-devel@nongnu.org; Thu, 25 Apr 2019 09:28:09 -0400 Received: by mail-wm1-x342.google.com with SMTP id n25so10602140wmk.4 for ; Thu, 25 Apr 2019 06:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L0b6ekwQ+2V0lpxiU3U4YMDKi4QNx+8EvSzJuNBfha8=; b=lAZItkvBwUDzADEYBIM0LD0VXSdPc27TXEQdB+TsWijWJMAKVB94dQXnw7Fqa8FNBy zG8iHbsmpCxsfyBy0q7srAA/QpV6sHplZIEJX1rGj/AqjOHnYSOFEa/upp9h66R5zZh9 cCRLEA1YTgrP/GST63qNFyd8CFwJH7KVjqfqMCOhjNEb63b++hQNdGOOIJdvTL3Q9EcC haYVvVazGGdAa3yMwqcYV/3AWGhe5wmwgo3YVWaMfJsqDqSg9+5otOL1C4XOX7c2N3Ga giLFpHoiWR6U7SsxAS8kikcTkxEAllGjsraDrmafa6eEVI5H7i1n7mkiKVCT3RZMXUDw u9Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L0b6ekwQ+2V0lpxiU3U4YMDKi4QNx+8EvSzJuNBfha8=; b=M86oPHkRYe6OgVmK89wNZE5EDPdTpvjpNa+0FHU5pazelmQwGURIDYG/V6B+cdewu8 fFKFnDL2Gh/o4JGWF1qzWm73x7xBL7BhTolKLITdFhrDyfV4evGiZeSu6ukjVKn2JAhr 6Rd3nqZf2BQTqazcsGcPhI8E/gv2qXajQWkBSOEBhOwGCLo7xtO9AJXXIIJlkkyXPguV RDsTjHwf2ldQ0Ftm9xZXRhjl4/nsC1lcTd/OcH0QBvHoWtElztGdF7PJXu939HU6T42R N4DfXmUEvma8SbwgOPoRFil+ptUJoLgzp3a7dqhLiSaps0Vp7nBz2nRurD0xPMFMM2yl HhFQ== X-Gm-Message-State: APjAAAWqHPfcWTxcvl2c685ZoaT1mmqlvLpGuIGxqrJ4OKdz0YZp+VOL kXDnd/dLbhFVxbU8u84gTZ+fyNTq X-Google-Smtp-Source: APXvYqzThWOtFlFpsk5ipejYzlW8N2CD3582XXpON+/+Dcsyfr/dT/4XH9lFSYbZWswj7fguVubznQ== X-Received: by 2002:a7b:cc96:: with SMTP id p22mr3730153wma.17.1556198887241; Thu, 25 Apr 2019 06:28:07 -0700 (PDT) Received: from localhost.localdomain (bzq-79-178-247-46.red.bezeqint.net. [79.178.247.46]) by smtp.gmail.com with ESMTPSA id y4sm2316540wrt.34.2019.04.25.06.28.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 25 Apr 2019 06:28:04 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Thu, 25 Apr 2019 16:26:31 +0300 Message-Id: <20190425132636.31636-17-arilou@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190425132636.31636-1-arilou@gmail.com> References: <20190425132636.31636-1-arilou@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::342 Subject: [Qemu-devel] [PATCH v6 16/21] gdbstub: Implement step (s pkt) with new infra X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jon Doron Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Jon Doron --- gdbstub.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 18949120be..809503c20a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1806,6 +1806,16 @@ static void handle_file_io(GdbCmdContext *gdb_ctx, void *user_ctx) gdb_continue(gdb_ctx->s); } +static void handle_step(GdbCmdContext *gdb_ctx, void *user_ctx) +{ + if (gdb_ctx->num_params) { + gdb_set_cpu_pc(gdb_ctx->s, (target_ulong)gdb_ctx->params[0].val_ull); + } + + cpu_single_step(gdb_ctx->s->c_cpu, sstep_flags); + gdb_continue(gdb_ctx->s); +} + static int gdb_handle_packet(GDBState *s, const char *line_buf) { CPUState *cpu; @@ -1938,13 +1948,16 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) } break; case 's': - if (*p != '\0') { - addr = strtoull(p, (char **)&p, 16); - gdb_set_cpu_pc(s, addr); + { + static const GdbCmdParseEntry step_cmd_desc = { + .handler = handle_step, + .cmd = "s", + .cmd_startswith = 1, + .schema = "L0" + }; + cmd_parser = &step_cmd_desc; } - cpu_single_step(s->c_cpu, sstep_flags); - gdb_continue(s); - return RS_IDLE; + break; case 'F': { static const GdbCmdParseEntry file_io_cmd_desc = {