From patchwork Wed Apr 24 19:38:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Doron X-Patchwork-Id: 1090436 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OdCzmCW2"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44q9sS5p44z9s4Y for ; Thu, 25 Apr 2019 05:50:36 +1000 (AEST) Received: from localhost ([127.0.0.1]:46428 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJNuc-0004DZ-NY for incoming@patchwork.ozlabs.org; Wed, 24 Apr 2019 15:50:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJNkL-0003zs-VM for qemu-devel@nongnu.org; Wed, 24 Apr 2019 15:39:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJNkL-0004F8-28 for qemu-devel@nongnu.org; Wed, 24 Apr 2019 15:39:57 -0400 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]:39653) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJNkK-0004EV-Rs for qemu-devel@nongnu.org; Wed, 24 Apr 2019 15:39:56 -0400 Received: by mail-wr1-x443.google.com with SMTP id a9so9189140wrp.6 for ; Wed, 24 Apr 2019 12:39:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L0b6ekwQ+2V0lpxiU3U4YMDKi4QNx+8EvSzJuNBfha8=; b=OdCzmCW2qJ0fnNoXOMUg/JasfKGaNq2Zm+6qKecWJ5gj7datEFwCatflmW+GzYEXYI 8KDTEjzHXCon/QngQgmKRZ85f90LdmfLlkr/FXTIDE0SnWdMaY13d1qGSYA0qq13iHNo I/gxrP2o/O0jGculu5dv1F5zOS6ytnOmHQtXCTMRGSMz/sk/YMl8t5jNZ/5GCdSuC64b gohHFQg5yE0dayciO3aGqpOn9f+4+MjGHNn64AHTXrfUEHtqVWIPuXVXwse21ZkkTLfc WJRjmZ8HsHawikbkk2+D8oIUtIztxqdylMFFLJjk9Fsn4T4TWtyzMYlJYGOMVc3WcWAa 2c/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L0b6ekwQ+2V0lpxiU3U4YMDKi4QNx+8EvSzJuNBfha8=; b=AdMqCSJhOgA3FzUr35px1Iyebv1hUYT+TrbQbDpNjB+Ow89QGXrgJT2zC7nDlMXLxy zMgv+5d4lXLDrUzwD8hN1Bj/KF7fVsB8nA4SrflJIQIAc6ttJmayNjhEHHK76GOw67RB GT38vs1EA4om+UI+LtWC0AfOSm1O1gu7bUNKT5SQT7Ul+qdvXaOK5nPUSE48uz2/RHFc krfUugLb9SHhHG1VKUzAXDhS/rrAqbfGJAuEBp334h/tK32oAG4vHd5ebzYywhzplbDA 4Lgo41NMMfk5uh8aklm7Fk1dHCRgN8lL+GRTBKMm3PjUJ6aKayUiKU+n77mjcRr3bjWE EzuA== X-Gm-Message-State: APjAAAWZMW1Otr0Ed0D8/3Nn07D1aAqVO5ghVMdVSpxfjn9Q4j6sr/qo 7fjeRrGA4azXggxFH/xVame+BMwX X-Google-Smtp-Source: APXvYqzPGGux3mKiZafdWEzHixzMg1SaExetc3v4s1b2Jv/8keOZTb5UHQZwdLOfD6oPTkrdx+aLGw== X-Received: by 2002:adf:cf0e:: with SMTP id o14mr22435985wrj.182.1556134795262; Wed, 24 Apr 2019 12:39:55 -0700 (PDT) Received: from linux.local ([31.154.166.148]) by smtp.gmail.com with ESMTPSA id n18sm16281372wrt.16.2019.04.24.12.39.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 12:39:53 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Wed, 24 Apr 2019 22:38:54 +0300 Message-Id: <20190424193859.31817-16-arilou@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190424193859.31817-1-arilou@gmail.com> References: <20190424193859.31817-1-arilou@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::443 Subject: [Qemu-devel] [PATCH v5 16/21] gdbstub: Implement step (s pkt) with new infra X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jon Doron Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Jon Doron --- gdbstub.c | 25 +++++++++++++++++++------ 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 18949120be..809503c20a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1806,6 +1806,16 @@ static void handle_file_io(GdbCmdContext *gdb_ctx, void *user_ctx) gdb_continue(gdb_ctx->s); } +static void handle_step(GdbCmdContext *gdb_ctx, void *user_ctx) +{ + if (gdb_ctx->num_params) { + gdb_set_cpu_pc(gdb_ctx->s, (target_ulong)gdb_ctx->params[0].val_ull); + } + + cpu_single_step(gdb_ctx->s->c_cpu, sstep_flags); + gdb_continue(gdb_ctx->s); +} + static int gdb_handle_packet(GDBState *s, const char *line_buf) { CPUState *cpu; @@ -1938,13 +1948,16 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) } break; case 's': - if (*p != '\0') { - addr = strtoull(p, (char **)&p, 16); - gdb_set_cpu_pc(s, addr); + { + static const GdbCmdParseEntry step_cmd_desc = { + .handler = handle_step, + .cmd = "s", + .cmd_startswith = 1, + .schema = "L0" + }; + cmd_parser = &step_cmd_desc; } - cpu_single_step(s->c_cpu, sstep_flags); - gdb_continue(s); - return RS_IDLE; + break; case 'F': { static const GdbCmdParseEntry file_io_cmd_desc = {