From patchwork Wed Apr 24 18:45:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jon Doron X-Patchwork-Id: 1090362 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="kh9RHnyf"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44q92B0YMyz9s3q for ; Thu, 25 Apr 2019 05:13:06 +1000 (AEST) Received: from localhost ([127.0.0.1]:45963 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJNKJ-0006OC-Ap for incoming@patchwork.ozlabs.org; Wed, 24 Apr 2019 15:13:03 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJN6K-0001z4-CY for qemu-devel@nongnu.org; Wed, 24 Apr 2019 14:58:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJMuO-0005Tl-EM for qemu-devel@nongnu.org; Wed, 24 Apr 2019 14:46:17 -0400 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]:44052) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJMuO-0005Sf-8d for qemu-devel@nongnu.org; Wed, 24 Apr 2019 14:46:16 -0400 Received: by mail-wr1-x444.google.com with SMTP id c5so17693653wrs.11 for ; Wed, 24 Apr 2019 11:46:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MK04Gqk/QxrnoBt94M+4u4mfOZrim+/hfyCGy3IWRYE=; b=kh9RHnyfQtjbhdjwbsjvGI8F+3+tJsox2IsRO9ExW2zyRnEfTGzXmSaWyti6JvErIr aiqV99G1fRiWYadiLGDJI5iztVEuUd4i+RLyx5FA2b8K9kNcPAgu/Nnk4h0ZiudCiFx3 hRbYp2ILR2R5ka4vO9BvOFQNZ2SsophylyFAJM2t5C04gTvAcAfkL2/A8lGTX5f4tiTe jE7CX6GEkqipKXM4BB79Bc08UP8AqRNIerXeCWxak1J/hNonKC6u56mMW9d/IqqQxMl2 zz0j5tG1+ZZ4sBplq9B/hqelXzV1zYHr25O81DJ7AiAjC5glFBXpWUbcgVw1qHIDGUMD O6MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MK04Gqk/QxrnoBt94M+4u4mfOZrim+/hfyCGy3IWRYE=; b=K7i5JRPapDlIQ1mvY0NQGgqhar0Nh8yAen2yuKy71RnbVj/oHjulF4hjKGE0Z/I4aA p2LHCM2ZxB6mX95A0G7t78Xj7Rf238ORSNq6tk52SH43UcsQl5iM/macx415VExPHuM3 alB0NMyC+yTynoYGgMyrwnBDQb9FUVjyBgOpqkTJu65v7co3Zm9RMtU4sfQxN2V/Esrx +vZlTK965xmoZtLA0QTCO/FhY1641OSaWKC7MUbuMKC/rPUZbB25TsniShB8LAwfit5H u3ox+vd3CugAOoRp0QqDxar4ZJ0iNbNcYsGbVtzb8il3za6Hl/soEerwDMD1RZiokruq 46Tw== X-Gm-Message-State: APjAAAVL0le491AWEO+L3H5Xn1yLOlLMQGE0kIJKaBES133id9i6iNiL BV+uGxCMbU68u9X8RT/RTxKYFAn6 X-Google-Smtp-Source: APXvYqw5Qkv1dPNHxNa2C5bUbeuB4zPN92KSBwwImMwg4zkw8Gfv0Cc6htw3NdnTakq/nCoh8jVp+w== X-Received: by 2002:adf:de8d:: with SMTP id w13mr8709779wrl.26.1556131574782; Wed, 24 Apr 2019 11:46:14 -0700 (PDT) Received: from linux.local ([31.154.166.148]) by smtp.gmail.com with ESMTPSA id h9sm14720106wmb.5.2019.04.24.11.46.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Apr 2019 11:46:13 -0700 (PDT) From: Jon Doron To: qemu-devel@nongnu.org Date: Wed, 24 Apr 2019 21:45:43 +0300 Message-Id: <20190424184600.8445-3-arilou@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190424184600.8445-1-arilou@gmail.com> References: <20190424184600.8445-1-arilou@gmail.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::444 Subject: [Qemu-devel] [PATCH v4 03/20] gdbstub: Implement thread_alive (T pkt) with new infra X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jon Doron Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Jon Doron --- gdbstub.c | 43 ++++++++++++++++++++++++++++++++----------- 1 file changed, 32 insertions(+), 11 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 952a6d92ef..7704edd69c 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1508,6 +1508,30 @@ static void handle_detach(GdbCmdContext *gdb_ctx, void *user_ctx) put_packet(s, "OK"); } +static void handle_thread_alive(GdbCmdContext *gdb_ctx, void *user_ctx) +{ + CPUState *cpu; + + if (!gdb_ctx->num_params) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + if (gdb_ctx->params[0].thread_id.kind == GDB_READ_THREAD_ERR) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + cpu = gdb_get_cpu(gdb_ctx->s, gdb_ctx->params[0].thread_id.pid, + gdb_ctx->params[0].thread_id.tid); + if (!cpu) { + put_packet(gdb_ctx->s, "E22"); + return; + } + + put_packet(gdb_ctx->s, "OK"); +} + static int gdb_handle_packet(GDBState *s, const char *line_buf) { CPUState *cpu; @@ -1807,17 +1831,14 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) } break; case 'T': - thread_kind = read_thread_id(p, &p, &pid, &tid); - if (thread_kind == GDB_READ_THREAD_ERR) { - put_packet(s, "E22"); - break; - } - cpu = gdb_get_cpu(s, pid, tid); - - if (cpu != NULL) { - put_packet(s, "OK"); - } else { - put_packet(s, "E22"); + { + static GdbCmdParseEntry thread_alive_cmd_desc = { + .handler = handle_thread_alive, + .cmd = "T", + .cmd_startswith = 1, + .schema = "t0" + }; + process_string_cmd(s, NULL, line_buf, &thread_alive_cmd_desc, 1); } break; case 'q':