| Message ID | 20190311191602.25796-6-svens@stackframe.org |
|---|---|
| State | New |
| Headers | show |
| Series | target/hppa patches | expand |
On 3/11/19 12:15 PM, Sven Schnelle wrote: > HP ODE use rfi to set the Q bit, and i don't see anything in the > documentation that this is forbidden. So remove it. > > Signed-off-by: Sven Schnelle <svens@stackframe.org> > --- > target/hppa/op_helper.c | 5 ----- > 1 file changed, 5 deletions(-) Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
diff --git a/target/hppa/op_helper.c b/target/hppa/op_helper.c index a05681d480..a55a5dfc02 100644 --- a/target/hppa/op_helper.c +++ b/target/hppa/op_helper.c @@ -678,11 +678,6 @@ target_ureg HELPER(swap_system_mask)(CPUHPPAState *env, target_ureg nsm) void HELPER(rfi)(CPUHPPAState *env) { - /* ??? On second reading this condition simply seems - to be undefined rather than a diagnosed trap. */ - if (env->psw & (PSW_I | PSW_R | PSW_Q)) { - helper_excp(env, EXCP_ILL); - } env->iasq_f = (uint64_t)env->cr[CR_IIASQ] << 32; env->iasq_b = (uint64_t)env->cr_back[0] << 32; env->iaoq_f = env->cr[CR_IIAOQ];
HP ODE use rfi to set the Q bit, and i don't see anything in the documentation that this is forbidden. So remove it. Signed-off-by: Sven Schnelle <svens@stackframe.org> --- target/hppa/op_helper.c | 5 ----- 1 file changed, 5 deletions(-)