From patchwork Mon Mar 11 13:58:50 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1054483 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="YNqCr79q"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44J0Lw1WWLz9s4V for ; Tue, 12 Mar 2019 01:08:24 +1100 (AEDT) Received: from localhost ([127.0.0.1]:34129 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3LbK-00063W-60 for incoming@patchwork.ozlabs.org; Mon, 11 Mar 2019 10:08:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3LSi-00008X-Lx for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3LSh-0000WU-RN for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:28 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:45239) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h3LSh-0000W0-Kl for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:27 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190311135926euoutp020c61c692d9e4f6d53c79afd4d910e3df~K7DyYG0eb2092420924euoutp02f for ; Mon, 11 Mar 2019 13:59:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190311135926euoutp020c61c692d9e4f6d53c79afd4d910e3df~K7DyYG0eb2092420924euoutp02f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1552312766; bh=w4Jv8ksWorck56mIfI6cvuADBi/bwNFiq1e9hNPUSn4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YNqCr79qNzgCCGN8LrWMZ0B+dgpNz/cHVQUyDkCWxTOXOYfweLM5TK3w4arCeuRuH T/Da2w1Yodi6OCVz87KJ/8IrJMtHThr8hQQOQzgLzzcPLCpSFmzfywtkhnSoKKnWNS qJ+uyWhP00+wbLM7vGErVEQNtPZ1NlVRhlJTF660= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190311135926eucas1p279821241ce856ec044541406dcfc8a97~K7Dx8xS1-3183531835eucas1p2A; Mon, 11 Mar 2019 13:59:26 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 9F.02.04806.DB9668C5; Mon, 11 Mar 2019 13:59:25 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190311135925eucas1p21442eda0f28a7e6ae1f9a238ca0a4f0d~K7DxBPPG-0058600586eucas1p2s; Mon, 11 Mar 2019 13:59:25 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20190311135924eusmtrp214999deb66165486fc8dee24231db424~K7DwyOFK13070130701eusmtrp2K; Mon, 11 Mar 2019 13:59:24 +0000 (GMT) X-AuditID: cbfec7f5-367ff700000012c6-9f-5c8669bd3c50 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id D2.2D.04128.CB9668C5; Mon, 11 Mar 2019 13:59:24 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190311135924eusmtip197e858d65249e5b56175d47ecb80d5c8~K7DwLxQ-e1279912799eusmtip18; Mon, 11 Mar 2019 13:59:24 +0000 (GMT) From: Ilya Maximets To: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Eduardo Habkost Date: Mon, 11 Mar 2019 16:58:50 +0300 Message-Id: <20190311135850.6537-5-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190311135850.6537-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBKsWRmVeSWpSXmKPExsWy7djPc7p7M9tiDJZ+NrF482YNk0XDvVCL K+0/2S1OH+1gtnh26ySzxYK2dlaL/dv+sVoc793B4sDh8eTaZiaP9/uusnn0bVnFGMAcxWWT kpqTWZZapG+XwJXx/1UHe8ENroqWM0YNjM/Yuxg5OSQETCQe3JsEZHNxCAmsYJT48mgHM0hC SOALo8SbVxoQic+MEpPnHWOD6Zh66wALRGI5o8SFS9+g2n8wSnzbOo8RpIpNQEfi1OojYLaI QL7EhsZGZpAiZoGvjBIXj7wDGsXBISxgKnF2Lx9IDYuAqsSCpcfB6nkFrCR+v/nDArFNXmL1 hgNgJ3EKWEtM7HjEDlEjKHFy5hOwGmagmuats8HmSwjMY5d4d6uDGaLZReLb8kaoQcISr45v gXpaRuL/zvlMEHa9xP2Wl4wQzR2MEtMP/YNK2EtseX2OHeRQZgFNifW79CHCjhJv/k1hBAlL CPBJ3HgrCHEDn8SkbdOZIcK8Eh1tQhDVKhK/Dy6HukZK4ua7z1AXeEicn/KaeQKj4iwk38xC 8s0shL0LGJlXMYqnlhbnpqcWG+ellusVJ+YWl+al6yXn525iBKaX0/+Of93BuO9P0iFGAQ5G JR7ehOTWGCHWxLLiytxDjBIczEoivDvd2mKEeFMSK6tSi/Lji0pzUosPMUpzsCiJ81YzPIgW EkhPLEnNTk0tSC2CyTJxcEo1MGpxc3L+9z9l+iCnsX6jjOeJjhPrfrz9ahb5xS+7bqmAtZrz txmTvXTFHy4xejXBe/f7aWfE31q6HNvLISmkk/GgUUBdQdC0tEegOU6Nz3XarXu3O37uOFyV IHze3PFd5V3Nsvo3Ad/yF3bKMyVlL1JsWLMj5NPFtdlH/vVZ97EefHxR0e3yCiWW4oxEQy3m ouJEAFrUOY8rAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsVy+t/xu7p7MttiDB6sMrJ482YNk0XDvVCL K+0/2S1OH+1gtnh26ySzxYK2dlaL/dv+sVoc793B4sDh8eTaZiaP9/uusnn0bVnFGMAcpWdT lF9akqqQkV9cYqsUbWhhpGdoaaFnZGKpZ2hsHmtlZKqkb2eTkpqTWZZapG+XoJfx/1UHe8EN roqWM0YNjM/Yuxg5OSQETCSm3jrA0sXIxSEksJRRYsPWh0wQCSmJH78usELYwhJ/rnWxQRR9 Y5S4OvciWDebgI7EqdVHGEFsEYF8iQ2NjcwgRcwCPxklXtzcBtTBwSEsYCpxdi8fSA2LgKrE gqXHwep5Bawkfr/5wwKxQF5i9YYDzCA2p4C1xMSOR2DzhYBqOvdtZ4eoF5Q4OfMJC8hIZgF1 ifXzhEDCzECtzVtnM09gFJyFpGoWQtUsJFULGJlXMYqklhbnpucWG+kVJ+YWl+al6yXn525i BEbNtmM/t+xg7HoXfIhRgINRiYeXI7E1Rog1say4MvcQowQHs5II7063thgh3pTEyqrUovz4 otKc1OJDjKZAr01klhJNzgdGdF5JvKGpobmFpaG5sbmxmYWSOO95g8ooIYH0xJLU7NTUgtQi mD4mDk6pBkad8sQjnVEi5Q+9jzvKP5lzS9G4X/Op0owUIdXFiaGqaUfKDDX3Loo7W1P7bFu9 8vYJ196eFnukeeu75uzM+kcbSz7yen58qL1cZJK9TXLG2g9SP+Tnm3A8E5xzRv/Ppb2RqjM4 M8tEJwYuEje3nhG74IVteYzMpO4Fd7tyF9Vs+Hmk+nTKw2QlluKMREMt5qLiRACt6jRNsAIA AA== X-CMS-MailID: 20190311135925eucas1p21442eda0f28a7e6ae1f9a238ca0a4f0d X-Msg-Generator: CA X-RootMTR: 20190311135925eucas1p21442eda0f28a7e6ae1f9a238ca0a4f0d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190311135925eucas1p21442eda0f28a7e6ae1f9a238ca0a4f0d References: <20190311135850.6537-1-i.maximets@samsung.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 210.118.77.12 Subject: [Qemu-devel] [PATCH v3 4/4] memfd: improve error messages X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Igor Mammedov , Ilya Maximets , Paolo Bonzini Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" This gives more information about the failure. Additionally 'ENOSYS' returned for a non-Linux platforms instead of 'errno', which is not initilaized in this case. Signed-off-by: Ilya Maximets Reviewed-by: Marc-André Lureau --- util/memfd.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/util/memfd.c b/util/memfd.c index 393d23da96..00334e5b21 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -71,14 +71,18 @@ int qemu_memfd_create(const char *name, size_t size, bool hugetlb, } mfd = memfd_create(name, flags); if (mfd < 0) { + error_setg_errno(errp, errno, + "failed to create memfd with flags 0x%x", flags); goto err; } if (ftruncate(mfd, size) == -1) { + error_setg_errno(errp, errno, "failed to resize memfd to %zu", size); goto err; } if (seals && fcntl(mfd, F_ADD_SEALS, seals) == -1) { + error_setg_errno(errp, errno, "failed to add seals 0x%x", seals); goto err; } @@ -88,8 +92,9 @@ err: if (mfd >= 0) { close(mfd); } +#else + error_setg_errno(errp, ENOSYS, "failed to create memfd"); #endif - error_setg_errno(errp, errno, "failed to create memfd"); return -1; }