From patchwork Mon Mar 11 13:58:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1054478 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="P3xozHNO"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44J0JY6KD0z9s4V for ; Tue, 12 Mar 2019 01:06:20 +1100 (AEDT) Received: from localhost ([127.0.0.1]:34115 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3LZJ-0004pC-Dk for incoming@patchwork.ozlabs.org; Mon, 11 Mar 2019 10:06:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3LSb-0008Ss-E1 for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3LSa-0000Sy-Er for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:21 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:45162) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1h3LSa-0000S9-7H for qemu-devel@nongnu.org; Mon, 11 Mar 2019 09:59:20 -0400 Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190311135918euoutp0279aea9f58c738e61e4ddd1abdcdb121c~K7DqsJuR22095420954euoutp02R for ; Mon, 11 Mar 2019 13:59:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190311135918euoutp0279aea9f58c738e61e4ddd1abdcdb121c~K7DqsJuR22095420954euoutp02R DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1552312758; bh=2r1LDYdyh1zFXd/AmW3qbVCJPimzSpTwh/QVpbLabVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P3xozHNOKFkQy8kp4QWS2UPYIMbfgjpExSw29mSeiAfobSHSQkoM6J5Oaf+76GTF9 blZe28iYfnIYPvcrmz3R6hstTXTZsja5JQ+WL6QoYZQJrQMJ6b+zE+gsoBORVZBrL5 vOLUTzxAFog4ogj+oNldWJtekyLoFvwiQhC/R2kw= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20190311135917eucas1p13d922e62c3630559952a8d0c0029375b~K7DqUvazf1241212412eucas1p1N; Mon, 11 Mar 2019 13:59:17 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 8D.C9.04294.5B9668C5; Mon, 11 Mar 2019 13:59:17 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20190311135916eucas1p27b50ca29c84af5f7529d56fd43a2964d~K7DpbCc_u0722607226eucas1p2p; Mon, 11 Mar 2019 13:59:16 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20190311135916eusmtrp2043b0a3508cfc11146193d2d2805741d~K7DpM0zcV3045630456eusmtrp23; Mon, 11 Mar 2019 13:59:16 +0000 (GMT) X-AuditID: cbfec7f4-835ff700000010c6-2a-5c8669b5f589 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 95.1D.04128.4B9668C5; Mon, 11 Mar 2019 13:59:16 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20190311135916eusmtip10ea80427009260620fc948bfca039738~K7DooSwJd1278712787eusmtip10; Mon, 11 Mar 2019 13:59:16 +0000 (GMT) From: Ilya Maximets To: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Eduardo Habkost Date: Mon, 11 Mar 2019 16:58:47 +0300 Message-Id: <20190311135850.6537-2-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190311135850.6537-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsWy7djPc7pbM9tiDFb+0LB482YNk0XDvVCL K+0/2S1OH+1gtnh26ySzxYK2dlaL/dv+sVoc793B4sDh8eTaZiaP9/uusnn0bVnFGMAcxWWT kpqTWZZapG+XwJVxaBtvwSPJilUNe5gaGJsEuxg5OSQETCQuTT/L2sXIxSEksIJRYsKGBWwQ zhdGiY/vN0E5nxklpvzdxgjTcvBVA1TLcqCqx8uZIZwfjBKLZpxhBaliE9CROLX6CFiHiEC+ xIbGRrAiZoGvjBIXj7xjA0kIC4RI7D52FKyIRUBVYvfcW0wgNq+AlcSF2SvYINbJS6zecIAZ xOYUsJaY2PGIHaJGUOLkzCcsIDYzUE3z1tlgCyQE2tklbvy8BnWri8T7w/tYIWxhiVfHt7BD 2DIS/3fOZ4Kw6yXut7xkhGjuYJSYfugfVMJeYsvrc0ANHEAbNCXW79KHCDtK/JpxFCwsIcAn ceOtIMQNfBKTtk1nhgjzSnS0CUFUq0j8PricGcKWkrj57jPUBR4Sx57sY57AqDgLyTezkHwz C2HvAkbmVYziqaXFuempxUZ5qeV6xYm5xaV56XrJ+bmbGIEp5vS/4192MO76k3SIUYCDUYmH NyG5NUaINbGsuDL3EKMEB7OSCO9Ot7YYId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rzVDA+ihQTS E0tSs1NTC1KLYLJMHJxSDYzr22qVNPqT3rN/mlPQOPlScJRJ37kwh7eBM9Z2L9qdHn5VsvJk vemzyxxrZqWG54tmxcrWOdkrRlvFefiun2D8NjuXPeuy4T81DsdeV6uMVwJJKd6n1jf9NzvL zHOhsHLrxhX669j/BNqIV3HvFZ/3fr1Y6LYaCasl65IDevoZzr/aVLPhhRJLcUaioRZzUXEi AASng/otAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42I5/e/4Xd0tmW0xBke3aVi8ebOGyaLhXqjF lfaf7Banj3YwWzy7dZLZYkFbO6vF/m3/WC2O9+5gceDweHJtM5PH+31X2Tz6tqxiDGCO0rMp yi8tSVXIyC8usVWKNrQw0jO0tNAzMrHUMzQ2j7UyMlXSt7NJSc3JLEst0rdL0Ms4tI234JFk xaqGPUwNjE2CXYycHBICJhIHXzWwdjFycQgJLGWUuPNgEStEQkrix68LULawxJ9rXWwQRd8Y JT5dbmAHSbAJ6EicWn2EEcQWEciX2NDYyAxSxCzwk1Hixc1tQB0cHMICQRItr6tAalgEVCV2 z73FBGLzClhJXJi9gg1igbzE6g0HmEFsTgFriYkdj8DmCwHVdO7bzg5RLyhxcuYTFhCbGai+ eets5gmMArOQpGYhSS1gZFrFKJJaWpybnltspFecmFtcmpeul5yfu4kRGAnbjv3csoOx613w IUYBDkYlHl6OxNYYIdbEsuLK3EOMEhzMSiK8O93aYoR4UxIrq1KL8uOLSnNSiw8xmgI9MZFZ SjQ5HxileSXxhqaG5haWhubG5sZmFkrivOcNKqOEBNITS1KzU1MLUotg+pg4OKUaGBdNloqS 5v6f22bdEpnXNPXfkZUnPx148L0wSdaqLqipN7mkQP2bvQvXfvNWLv2aRUGhKh6/c8q09/z1 1zF5bhGek/TxHN+qu8I3xTfczA/oe/yFL7S+/MGNvaUfp6/daPDh6kLr848+9L7nYAx4dP/j tny/+ym2+sp+zzK9OHgc+LsKOX+7KbEUZyQaajEXFScCAIet3u2aAgAA X-CMS-MailID: 20190311135916eucas1p27b50ca29c84af5f7529d56fd43a2964d X-Msg-Generator: CA X-RootMTR: 20190311135916eucas1p27b50ca29c84af5f7529d56fd43a2964d X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190311135916eucas1p27b50ca29c84af5f7529d56fd43a2964d References: <20190311135850.6537-1-i.maximets@samsung.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 210.118.77.12 Subject: [Qemu-devel] [PATCH v3 1/4] hostmem-memfd: disable for systems wihtout sealing support X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Igor Mammedov , Ilya Maximets , Paolo Bonzini Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" If seals are not supported, memfd_create() will fail. Furthermore, there is no way to disable it in this case because '.seal' property is not registered. This issue leads to vhost-user-test failures on RHEL 7.2: qemu-system-x86_64: -object memory-backend-memfd,id=mem,size=2M,: \ failed to create memfd: Invalid argument and actually breaks the feature on such systems. Let's restrict memfd backend to systems with sealing support. Signed-off-by: Ilya Maximets --- backends/hostmem-memfd.c | 18 ++++++++---------- tests/vhost-user-test.c | 5 +++-- 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c index 98c9bf3240..46b15b916a 100644 --- a/backends/hostmem-memfd.c +++ b/backends/hostmem-memfd.c @@ -154,15 +154,13 @@ memfd_backend_class_init(ObjectClass *oc, void *data) "Huge pages size (ex: 2M, 1G)", &error_abort); } - if (qemu_memfd_check(MFD_ALLOW_SEALING)) { - object_class_property_add_bool(oc, "seal", - memfd_backend_get_seal, - memfd_backend_set_seal, - &error_abort); - object_class_property_set_description(oc, "seal", - "Seal growing & shrinking", - &error_abort); - } + object_class_property_add_bool(oc, "seal", + memfd_backend_get_seal, + memfd_backend_set_seal, + &error_abort); + object_class_property_set_description(oc, "seal", + "Seal growing & shrinking", + &error_abort); } static const TypeInfo memfd_backend_info = { @@ -175,7 +173,7 @@ static const TypeInfo memfd_backend_info = { static void register_types(void) { - if (qemu_memfd_check(0)) { + if (qemu_memfd_check(MFD_ALLOW_SEALING)) { type_register_static(&memfd_backend_info); } } diff --git a/tests/vhost-user-test.c b/tests/vhost-user-test.c index 0c965b3b1e..3817966010 100644 --- a/tests/vhost-user-test.c +++ b/tests/vhost-user-test.c @@ -178,7 +178,8 @@ static void append_mem_opts(TestServer *server, GString *cmd_line, int size, enum test_memfd memfd) { if (memfd == TEST_MEMFD_AUTO) { - memfd = qemu_memfd_check(0) ? TEST_MEMFD_YES : TEST_MEMFD_NO; + memfd = qemu_memfd_check(MFD_ALLOW_SEALING) ? TEST_MEMFD_YES + : TEST_MEMFD_NO; } if (memfd == TEST_MEMFD_YES) { @@ -930,7 +931,7 @@ static void register_vhost_user_test(void) "virtio-net", test_read_guest_mem, &opts); - if (qemu_memfd_check(0)) { + if (qemu_memfd_check(MFD_ALLOW_SEALING)) { opts.before = vhost_user_test_setup_memfd; qos_add_test("vhost-user/read-guest-mem/memfd", "virtio-net",