From patchwork Wed Mar 6 11:07:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1052303 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44Drpn4Mjyz9s9T for ; Wed, 6 Mar 2019 22:18:09 +1100 (AEDT) Received: from localhost ([127.0.0.1]:59468 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1UYp-0004LN-Da for incoming@patchwork.ozlabs.org; Wed, 06 Mar 2019 06:18:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1UQ6-0005jj-RX for qemu-devel@nongnu.org; Wed, 06 Mar 2019 06:09:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1UQ0-0002gA-9s for qemu-devel@nongnu.org; Wed, 06 Mar 2019 06:09:06 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:45211) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1UPQ-0002DB-6B; Wed, 06 Mar 2019 06:08:24 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mg6mG-1hSJYz1dCY-00hcbj; Wed, 06 Mar 2019 12:07:23 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Wed, 6 Mar 2019 12:07:02 +0100 Message-Id: <20190306110711.309-2-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190306110711.309-1-laurent@vivier.eu> References: <20190306110711.309-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:Q3hk8qijD5KUlzCX23w0FWN0YpKiKd/7xr6qFZcEo8PLB8u8yfX vwCU01TcPv4ex5BZ7A+BddktVxYRMFof/lQqi/2RhrLTxAZExppSELttcY/aR4S88vFEbA8 gwsmlRgnqlsBBOxTx0F0eLIsSbkKUgkWyHOixueqLu3CfMbhpd8yC4ww1zAgFBVfhrfL3np usahS5fOCRRfPavkpW29A== X-UI-Out-Filterresults: notjunk:1; V03:K0:qpDPq41EuXc=:8F4TerVI713vWXfl+T7WWE KvuD7Suq9FYNPM0fBIYJUX45lmGIY5/Brj9PeshcFybRtT1VN+FoV3KHJNxP1bpVxTm3XsnPT XxyMXVLilr0Z/iou/CD1Gwf0ZDhjgKNW65TsIUoRVjEPxXxLG25QxSR48QlY+vw5pfRtAkQOp V2wyxoYZlWYLMWyVlBfIoUuv4ko6NxmapVeqUcTJpcxzuTAvTEOSDlsxEgDeTOlNmJt1aWHIs q+s2dyEIIVfTrC0EeZ4ZuVcmarkwVg3jXlnMych1msYbfjgLWnFhdeNSpwU8iUFup5qp/Bp1l ELp9JG8FO/51hDHWNPhAiA9yD8A6uJvtpTmw4HGGsctWuGSizRRFRRdSeCT4LxB7SY75CKWwm MS5rb4lnJcuBKK9wVfleu093GCz6mHSJDLomCaSh+B0I/8YtNLKv4o6wkbQikWBdXcY/XDQXB R/ZaI/N54Z5eVy5F72mDLaDbAksMEbg0SOJZduSItLBZa66N5BSY9sAN/ZVY6WriUDlVlUDlL YHeAthu9gSxQsWz9XpsF6HX+NZQaqVq2i/4L1tHxkUZgHqtnLC/KjxCmdVOkPLBkANEzzjTgV IWwmftVZZZXePgkGGtBBtf4P4sYHPnZEHyHwy2N8zQZFrRSzuKPEKpQgg1h5kDHczZO9U1V2a N/EHWaB2b4PruEFoF0N/kH495/TySkmCNMgMfSFf81cKlWNUOfalb/CLeADAhExbHCB0q3EfM 7iJ/5mGRpno964KYVum9ueWkof9lwVqME7DhKQ== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.72.192.73 Subject: [Qemu-devel] [PULL 01/10] tests: Remove (mostly) useless architecture checks X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Corey Minyard , Li Zhijian , "Michael S. Tsirkin" , Michael Tokarev , Paolo Bonzini , zhanghailiang , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Halil Pasic , Christian Borntraeger , Laurent Vivier , Tony Krowiak , Thomas Huth , Eduardo Habkost , Corey Minyard , Riku Voipio , qemu-s390x@nongnu.org, Pavel Dovgalyuk , Zhang Chen , John Snow , Richard Henderson , Kevin Wolf , Pierre Morel , Cornelia Huck , Laurent Vivier , Max Reitz , Igor Mammedov Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Thomas Huth These checks at the beginning of some of the tests are mostly useless: We only run the tests on x86 anyway, and g_test_message() does not print anything unless you call g_test_init() first. Signed-off-by: Thomas Huth Acked-by: John Snow Acked-by: Corey Minyard Message-Id: <1551456970-463-1-git-send-email-thuth@redhat.com> Signed-off-by: Laurent Vivier --- tests/fdc-test.c | 7 ------- tests/ide-test.c | 7 ------- tests/ipmi-bt-test.c | 7 ------- tests/ipmi-kcs-test.c | 7 ------- 4 files changed, 28 deletions(-) diff --git a/tests/fdc-test.c b/tests/fdc-test.c index 88f1abfa10e2..31cd3295c102 100644 --- a/tests/fdc-test.c +++ b/tests/fdc-test.c @@ -548,16 +548,9 @@ static void fuzz_registers(void) int main(int argc, char **argv) { - const char *arch = qtest_get_arch(); int fd; int ret; - /* Check architecture */ - if (strcmp(arch, "i386") && strcmp(arch, "x86_64")) { - g_test_message("Skipping test for non-x86\n"); - return 0; - } - /* Create a temporary raw image */ fd = mkstemp(test_image); g_assert(fd >= 0); diff --git a/tests/ide-test.c b/tests/ide-test.c index f0280e636b5d..300d64e77ddf 100644 --- a/tests/ide-test.c +++ b/tests/ide-test.c @@ -1009,16 +1009,9 @@ static void test_cdrom_dma(void) int main(int argc, char **argv) { - const char *arch = qtest_get_arch(); int fd; int ret; - /* Check architecture */ - if (strcmp(arch, "i386") && strcmp(arch, "x86_64")) { - g_test_message("Skipping test for non-x86\n"); - return 0; - } - /* Create temporary blkdebug instructions */ fd = mkstemp(debug_path); g_assert(fd >= 0); diff --git a/tests/ipmi-bt-test.c b/tests/ipmi-bt-test.c index f4a81b526505..fc4c83b5db7c 100644 --- a/tests/ipmi-bt-test.c +++ b/tests/ipmi-bt-test.c @@ -400,15 +400,8 @@ static void open_socket(void) int main(int argc, char **argv) { - const char *arch = qtest_get_arch(); int ret; - /* Check architecture */ - if (strcmp(arch, "i386") && strcmp(arch, "x86_64")) { - g_test_message("Skipping test for non-x86\n"); - return 0; - } - open_socket(); /* Run the tests */ diff --git a/tests/ipmi-kcs-test.c b/tests/ipmi-kcs-test.c index 178ffc179734..a2354c10c7fe 100644 --- a/tests/ipmi-kcs-test.c +++ b/tests/ipmi-kcs-test.c @@ -263,16 +263,9 @@ static void test_enable_irq(void) int main(int argc, char **argv) { - const char *arch = qtest_get_arch(); char *cmdline; int ret; - /* Check architecture */ - if (strcmp(arch, "i386") && strcmp(arch, "x86_64")) { - g_test_message("Skipping test for non-x86\n"); - return 0; - } - /* Run the tests */ g_test_init(&argc, &argv, NULL);