From patchwork Tue Nov 27 11:10:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Maximets X-Patchwork-Id: 1003774 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=samsung.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="K9FoijI7"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4341MD0Ch8z9s4s for ; Tue, 27 Nov 2018 22:11:52 +1100 (AEDT) Received: from localhost ([::1]:41417 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRbHR-0003Lz-04 for incoming@patchwork.ozlabs.org; Tue, 27 Nov 2018 06:11:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51259) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRbGu-0003Kn-1s for qemu-devel@nongnu.org; Tue, 27 Nov 2018 06:11:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRbGq-0004q9-ON for qemu-devel@nongnu.org; Tue, 27 Nov 2018 06:11:16 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:44497) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gRbGq-0004pg-IY for qemu-devel@nongnu.org; Tue, 27 Nov 2018 06:11:12 -0500 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181127111110euoutp025215ec040b3a975f7e3d97afebd33f25~q9rL9Civp2967029670euoutp02P for ; Tue, 27 Nov 2018 11:11:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181127111110euoutp025215ec040b3a975f7e3d97afebd33f25~q9rL9Civp2967029670euoutp02P DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1543317070; bh=+I5YAN8Wx9z7BmOvdA2l8gQC4KQitDwzRQxGs+9+CtA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K9FoijI7hMSLfVLWJc1HN/0SFFZiYl9ghprtzIhHzPmvC17WceaiRCMJNbD+hIP3q un0TI/xNwWVZdsXq+VFUJWbpJTE7TTJDAmryVp/q3N9M+n5tKAjVOwX2GN8oG1q9A5 K+2lX7PGQMQV8hH/bNuyoP4WFrbN8XYgQzhFu5/Y= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181127111110eucas1p16790015ef54a57ebf3a118ff2058d125~q9rLj_CAL3143931439eucas1p1W; Tue, 27 Nov 2018 11:11:10 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 99.3E.04441.E462DFB5; Tue, 27 Nov 2018 11:11:10 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20181127111109eucas1p2b1eae35e38e46c3f76c86a350ed41926~q9rK7C0JM3090630906eucas1p2R; Tue, 27 Nov 2018 11:11:09 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181127111109eusmtrp25b327153eac821cec26b97a1515768c3~q9rK6HMGs0895908959eusmtrp2Y; Tue, 27 Nov 2018 11:11:09 +0000 (GMT) X-AuditID: cbfec7f2-5e3ff70000001159-9d-5bfd264e692e Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 82.C3.04284.D462DFB5; Tue, 27 Nov 2018 11:11:09 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20181127111108eusmtip2382d40fa9672477f40ace356a430332c~q9rKFyBfX0663606636eusmtip2j; Tue, 27 Nov 2018 11:11:08 +0000 (GMT) From: Ilya Maximets To: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Tue, 27 Nov 2018 14:10:47 +0300 Message-Id: <20181127111050.18453-2-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181127111050.18453-1-i.maximets@samsung.com> MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42LZduznOV0/tb/RBu23BCwa7oVaXGn/yW5x +mgHs8WCtnZWi/3b/rFaHO/dweLA5vHk2mYmj/f7rrJ59G1ZxRjAHMVlk5Kak1mWWqRvl8CV cWOyUMET9orFu46zNTDOZeti5OSQEDCReL3/GXsXIxeHkMAKRomjex6wQThfGCXmTDjODlIl JPCZUaJ7lQhMx7RNfSwQ8eWMEocvqUE0/GCUmDy9EyzBJqAjcWr1EUYQW0TATeLFg+NgU5kF tjFK/Fk5G6xIWMBJ4k/3RVYQm0VAVaJvxXlmEJtXwFpiz6S3rBDb5CVWbzgAFOfg4BSwkdjy UwaiRFDi5MwnYGOYgUqat85mBpkvIfCZTWJH2w1miF4Xif47t6H+FJZ4dXwLO4QtI/F/53wm CLte4n7LS0aI5g5GiemH/kEl7CW2vD7HDrKYWUBTYv0ufYiwo8Slo71gYQkBPokbbwUhbuCT mLRtOjNEmFeio00IolpF4vfB5VDXSEncfPcZ6gIPiZ+LO9knMCrOQvLNLCTfzELYu4CReRWj eGppcW56arFhXmq5XnFibnFpXrpecn7uJkZgIjn97/inHYxfLyUdYhTgYFTi4d3w/Xe0EGti WXFl7iFGCQ5mJRFeZ+W/0UK8KYmVValF+fFFpTmpxYcYpTlYlMR5qxkeRAsJpCeWpGanphak FsFkmTg4pRoYtZgMhEV+XVo6sdyi28Rx8unXf9dGnk9ZYP1+0Z+Jv80uK2bfsZj3k31x29QX dzTCt7wN/5Sz1HIm/4S6neb1OY754tI1KcmNu/eY/vX4eLHxVd2/qhnrDv28N+UeT9wmTetL d9dL6Hl9SBb6ubdpR5nr3gNdm1xdOSI4fYqvnmXfOOFowNaLX5VYijMSDbWYi4oTAd8VUtEg AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsVy+t/xe7q+an+jDTq36lg03Au1uNL+k93i 9NEOZosFbe2sFvu3/WO1ON67g8WBzePJtc1MHu/3XWXz6NuyijGAOUrPpii/tCRVISO/uMRW KdrQwkjP0NJCz8jEUs/Q2DzWyshUSd/OJiU1J7MstUjfLkEv48ZkoYIn7BWLdx1na2Ccy9bF yMkhIWAiMW1THwuILSSwlFFi9xYXiLiUxI9fF1ghbGGJP9e6gOq5gGq+MUoc6r0IlmAT0JE4 tfoII4gtIuAm8eLBcbAiZoFdjBLXFx5hBkkICzhJ/OmGaGARUJXoW3EeLM4rYC2xZ9JbqA3y Eqs3HACKc3BwCthIbPkpA3GQtcTSFzdYIcoFJU7OfAJ2KDNQefPW2cwTGAVmIUnNQpJawMi0 ilEktbQ4Nz232FCvODG3uDQvXS85P3cTIzDktx37uXkH46WNwYcYBTgYlXh4N3z/HS3EmlhW XJl7iFGCg1lJhNdZ+W+0EG9KYmVValF+fFFpTmrxIUZToB8mMkuJJucD4zGvJN7Q1NDcwtLQ 3Njc2MxCSZz3vEFllJBAemJJanZqakFqEUwfEwenVAPjfOsZk07dP+etdX3DfTY2Ry61e96q s2a+rm3XDteVO7Lj6BpnhzibpUylFjL/3vRwdE5lZPkjoRxQevtNqdKCVW2cC4ssjq9OlTRZ fJnl/V/B42LCcqsv651Ovlz6Y3++TFvOB2m3E3cdPzUf53yrssL7tt7G2xx6czfeDA0r8E5h fxXix2etxFKckWioxVxUnAgAeIOzjY8CAAA= X-CMS-MailID: 20181127111109eucas1p2b1eae35e38e46c3f76c86a350ed41926 X-Msg-Generator: CA X-RootMTR: 20181127111109eucas1p2b1eae35e38e46c3f76c86a350ed41926 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181127111109eucas1p2b1eae35e38e46c3f76c86a350ed41926 References: <20181127111050.18453-1-i.maximets@samsung.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 210.118.77.12 Subject: [Qemu-devel] [PATCH 1/4] hostmem-memfd: enable seals only if supported X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ilya Maximets , Paolo Bonzini , Igor Mammedov , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" If seals are not supported, memfd_create() will fail. Furthermore, there is no way to disable it in this case because '.seal' property is not registered. This issue leads to vhost-user-test failures on RHEL 7.2: qemu-system-x86_64: -object memory-backend-memfd,id=mem,size=2M,: \ failed to create memfd: Invalid argument Signed-off-by: Ilya Maximets --- backends/hostmem-memfd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c index b6836b28e5..ee39bdbde6 100644 --- a/backends/hostmem-memfd.c +++ b/backends/hostmem-memfd.c @@ -129,8 +129,8 @@ memfd_backend_instance_init(Object *obj) { HostMemoryBackendMemfd *m = MEMORY_BACKEND_MEMFD(obj); - /* default to sealed file */ - m->seal = true; + /* default to sealed file if supported */ + m->seal = qemu_memfd_check(MFD_ALLOW_SEALING); } static void