From patchwork Thu Nov 15 09:42:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luc Michel X-Patchwork-Id: 998221 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=greensocs.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=greensocs.com header.i=@greensocs.com header.b="2b+o51QY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=greensocs.com header.i=@greensocs.com header.b="2b+o51QY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=greensocs.com header.i=@greensocs.com header.b="C5VGWyWN"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42wcD16tstz9s9G for ; Thu, 15 Nov 2018 20:54:57 +1100 (AEDT) Received: from localhost ([::1]:37718 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNEMR-0008AK-A8 for incoming@patchwork.ozlabs.org; Thu, 15 Nov 2018 04:54:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNEAo-0007Re-GD for qemu-devel@nongnu.org; Thu, 15 Nov 2018 04:42:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gNEAn-0004oT-NF for qemu-devel@nongnu.org; Thu, 15 Nov 2018 04:42:54 -0500 Received: from greensocs.com ([193.104.36.180]:41905) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gNEAk-0004NT-0v; Thu, 15 Nov 2018 04:42:50 -0500 Received: from localhost (localhost [127.0.0.1]) by greensocs.com (Postfix) with ESMTP id B2C07441B67; Thu, 15 Nov 2018 10:42:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1542274939; bh=5y0tKMHMdk7YdAq4Id1MBSsyrMbMoeOzN/P9UoGb6YU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=2b+o51QYRoStLw7FwLpKZ6bFw6mD/aGe3LYGffCPOE3uevzHEwn4vgwS7Qq/HG59d pGgNNB9a8O3HHZG4nAa14fesd6clJsBXQH2TZj5+GkL3GpQxamYuQAdG8yuEy0nkCn dgnNvMcxgmpnlfHrkwNVEmnOHV1++IA4C36z7StQ= X-Virus-Scanned: amavisd-new at greensocs.com Authentication-Results: gs-01.greensocs.com (amavisd-new); dkim=pass (1024-bit key) header.d=greensocs.com header.b=2b+o51QY; dkim=pass (1024-bit key) header.d=greensocs.com header.b=C5VGWyWN Received: from greensocs.com ([127.0.0.1]) by localhost (gs-01.greensocs.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kYHPFGZEkf8b; Thu, 15 Nov 2018 10:42:19 +0100 (CET) Received: by greensocs.com (Postfix, from userid 998) id 01935446865; Thu, 15 Nov 2018 10:42:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1542274939; bh=5y0tKMHMdk7YdAq4Id1MBSsyrMbMoeOzN/P9UoGb6YU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=2b+o51QYRoStLw7FwLpKZ6bFw6mD/aGe3LYGffCPOE3uevzHEwn4vgwS7Qq/HG59d pGgNNB9a8O3HHZG4nAa14fesd6clJsBXQH2TZj5+GkL3GpQxamYuQAdG8yuEy0nkCn dgnNvMcxgmpnlfHrkwNVEmnOHV1++IA4C36z7StQ= Received: from michell-laptop.hive.antfield.fr (lfbn-1-8165-82.w90-112.abo.wanadoo.fr [90.112.74.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: luc.michel@greensocs.com) by greensocs.com (Postfix) with ESMTPSA id 649A4441B57; Thu, 15 Nov 2018 10:42:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=greensocs.com; s=mail; t=1542274938; bh=5y0tKMHMdk7YdAq4Id1MBSsyrMbMoeOzN/P9UoGb6YU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=C5VGWyWNyIMRs0MRiVZ5LRC9hcK3i7OwsytPU+Ht/zglKDs7OzEHDv/sl7j0fGvgZ nVEWj5gEgatipdfAoBd0YPTwE4b+v5QTx+S+9E7VSAp753LCRIc7hjRjynKdweF31n aq3k6+2dx3QolguN+LwUoQl+oSR9Mwx6iEJcfwM0= From: Luc Michel To: qemu-devel@nongnu.org Date: Thu, 15 Nov 2018 10:42:05 +0100 Message-Id: <20181115094207.22846-15-luc.michel@greensocs.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181115094207.22846-1-luc.michel@greensocs.com> References: <20181115094207.22846-1-luc.michel@greensocs.com> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 193.104.36.180 Subject: [Qemu-devel] [PATCH v6 14/16] gdbstub: gdb_set_stop_cpu: ignore request when process is not attached X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Eduardo Habkost , alistair@alistair23.me, mark.burton@greensocs.com, =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , saipava@xilinx.com, edgari@xilinx.com, qemu-arm@nongnu.org, Luc Michel Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" When gdb_set_stop_cpu() is called with a CPU associated to a process currently not attached by the GDB client, return without modifying the stop CPU. Otherwise, GDB gets confused if it receives packets with a thread-id it does not know about. Signed-off-by: Luc Michel Acked-by: Alistair Francis Reviewed-by: Edgar E. Iglesias --- gdbstub.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index 59eed3b878..89819a6a72 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1787,10 +1787,19 @@ static int gdb_handle_packet(GDBState *s, const char *line_buf) return RS_IDLE; } void gdb_set_stop_cpu(CPUState *cpu) { + GDBProcess *p = gdb_get_cpu_process(gdbserver_state, cpu); + + if (!p->attached) { + /* Having a stop CPU corresponding to a process that is not attached + * confuses GDB. So we ignore the request. + */ + return; + } + gdbserver_state->c_cpu = cpu; gdbserver_state->g_cpu = cpu; } #ifndef CONFIG_USER_ONLY