From patchwork Fri Oct 26 15:31:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 989651 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42hTW90zL2z9s9G for ; Sat, 27 Oct 2018 03:11:00 +1100 (AEDT) Received: from localhost ([::1]:60897 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG4hO-0007bT-Bk for incoming@patchwork.ozlabs.org; Fri, 26 Oct 2018 12:10:58 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gG4JH-0003tV-Fd for qemu-devel@nongnu.org; Fri, 26 Oct 2018 11:46:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gG46u-0005R6-5q for qemu-devel@nongnu.org; Fri, 26 Oct 2018 11:33:17 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:45491) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gG46b-0004zg-Ic; Fri, 26 Oct 2018 11:32:57 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N62mG-1fW2030jY8-016T6J; Fri, 26 Oct 2018 17:32:19 +0200 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N62mG-1fW2030jY8-016T6J; Fri, 26 Oct 2018 17:32:19 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 26 Oct 2018 17:31:24 +0200 Message-Id: <20181026153125.24738-20-laurent@vivier.eu> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181026153125.24738-1-laurent@vivier.eu> References: <20181026153125.24738-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:peG9vs6GsMt7FvJ9IOcJtpr6YQ/f1NgGwuxCXLS10Tzwh7VvfDj bumB+gWdPNWZw6tKFratVmDSwhx5bzldZ0O4v00tNLyAm8FG+3+ljvGTfditOJ2aGYQXi78 xo9z6fuF8lhjoTnQ/BEZx0tGvwNDs/NqAMEfI/RdnZUzbAAT/Nm79xVwnJ/7sSDYSPJGHb9 LOIUKPcwnf0R6LBzrrJww== X-UI-Out-Filterresults: notjunk:1; V01:K0:Wmacvs2eZ1k=:3W4TmCzU9ZcT1LHL9taMaS AMPowxQE21LLEE0iygB5vtvM+3A8KTVZkIXddciNyIC5AGDSuKT3D99st/Z0ALRGkuTHSTdiY 1gIpMQbcmuKCPcm38Hbph+QG+miYgVBbYezydmHajI+vSMW00D+t4v+FJ0ZIbkG8lV7hixG5V dWtboDiLCgRT9tw8NH9oQVOqOuw3cOPmxG1XK7etdJ1/oOaCeGrayEMIkzkii6zuFxEpChQK9 lQhcllu29uiOER8BnjLxRGM/wwfqA7VVk+n4TEntn+KzAA2ZaqZAtonUwusfw7PfsfjVawNMJ npC6rYxYSZPL8PyAxXlolSC1uKW345ma6WhoWTaPqPBbUAG+oW95l/5tKpWSwBHHVGfS4EHlw dbYNr7zsv0iGiV+CICcE47Yebc/UjUNpcCkTFCKQPC/l/OJr58NdQs0kbX5gQsk/Pr7hyKRkD 896fLW/uApf7+6YL+wz/nt28ZHKEj0w6u00Zgy1dZ0cgFeL+sv0shGL6+JXJzg4MESR1zAodL +1gqMXBGelfL/T4FYpypaMa6bhOQfu0V2WfR5oyJV1BYhr4s5tCO8HdkwZRDuzS0B9dnMYiU8 zOOB1he6vkqTXeHJGMx/XT1aVOHqTRRHpYSzam+kqGdDV6wfCUwC8xtIefiH4hmzVwtPrrR6o X+D0sH95Ge56tgvFjKJwhr40j79u7gRsyxaUjL+1Y1DgRQdtiSOw+thGiOELiRdRHM7YC+jkc n4IZuoP+NmpIK5b8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.133 Subject: [Qemu-devel] [PULL 19/20] milkymist-minimac2: Use qemu_log_mask(GUEST_ERROR) instead of error_report X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , "Michael S. Tsirkin" , Jason Wang , Michael Tokarev , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Gerd Hoffmann , Stefano Stabellini , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Markus Armbruster , Anthony Perard , xen-devel@lists.xenproject.org, Igor Mammedov , Laurent Vivier , Thomas Huth , Fam Zheng , Eduardo Habkost , Riku Voipio , qemu-arm@nongnu.org, Cleber Rosa , =?utf-8?q?Alex_Benn=C3=A9e?= , Kevin Wolf , Laurent Vivier , Max Reitz , Michael Walle , Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé qemu_log_mask(GUEST_ERROR) is more appropriate: $ qemu -d help Log items (comma separated): guest_errors log when the guest OS does something invalid (eg accessing a non-existent register) Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael Walle Message-Id: <20180702014022.12395-1-f4bug@amsat.org> Signed-off-by: Laurent Vivier --- hw/net/milkymist-minimac2.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/net/milkymist-minimac2.c b/hw/net/milkymist-minimac2.c index 3eaa19dfde..322fb77e46 100644 --- a/hw/net/milkymist-minimac2.c +++ b/hw/net/milkymist-minimac2.c @@ -30,6 +30,7 @@ #include "hw/sysbus.h" #include "trace.h" #include "net/net.h" +#include "qemu/log.h" #include "qemu/error-report.h" #include @@ -214,7 +215,8 @@ static size_t assemble_frame(uint8_t *buf, size_t size, uint32_t crc; if (size < payload_size + 12) { - error_report("milkymist_minimac2: received too big ethernet frame"); + qemu_log_mask(LOG_GUEST_ERROR, "milkymist_minimac2: frame too big " + "(%zd bytes)\n", payload_size); return 0; } @@ -347,8 +349,9 @@ minimac2_read(void *opaque, hwaddr addr, unsigned size) break; default: - error_report("milkymist_minimac2: read access to unknown register 0x" - TARGET_FMT_plx, addr << 2); + qemu_log_mask(LOG_GUEST_ERROR, + "milkymist_minimac2_rd%d: 0x%" HWADDR_PRIx "\n", + size, addr << 2); break; } @@ -413,8 +416,9 @@ minimac2_write(void *opaque, hwaddr addr, uint64_t value, break; default: - error_report("milkymist_minimac2: write access to unknown register 0x" - TARGET_FMT_plx, addr << 2); + qemu_log_mask(LOG_GUEST_ERROR, + "milkymist_minimac2_wr%d: 0x%" HWADDR_PRIx " = 0x%lx\n", + size, addr << 2, value); break; } }