From patchwork Thu Oct 18 19:00:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 986172 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 42bdmT3kXSz9s3Z for ; Fri, 19 Oct 2018 06:05:45 +1100 (AEDT) Received: from localhost ([::1]:43984 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDDc7-0007Gf-3K for incoming@patchwork.ozlabs.org; Thu, 18 Oct 2018 15:05:43 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gDDXK-0004CA-RV for qemu-devel@nongnu.org; Thu, 18 Oct 2018 15:00:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gDDXG-00007n-QF for qemu-devel@nongnu.org; Thu, 18 Oct 2018 15:00:46 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:34745) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gDDXG-000057-FQ for qemu-devel@nongnu.org; Thu, 18 Oct 2018 15:00:42 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mirb8-1fjMxQ0668-00ex0R; Thu, 18 Oct 2018 21:00:32 +0200 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mirb8-1fjMxQ0668-00ex0R; Thu, 18 Oct 2018 21:00:32 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Thu, 18 Oct 2018 21:00:26 +0200 Message-Id: <20181018190026.9494-3-laurent@vivier.eu> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181018190026.9494-1-laurent@vivier.eu> References: <20181018190026.9494-1-laurent@vivier.eu> X-Provags-ID: V03:K1:YwyU+Bw/KbiaikvW1DWuHd9VpdZr8UD1gGXGoUyuYP8ckuEZk5+ Pb3l8bbYros03nWaBtrNGvtCdKxET4oabo20tAzh6wphnxHD1IP8loSDKi68T27+Eo7U9kG +pq2RWCOOzszQO/3QZfb+atvvSEbiAtBHpJINaCTVoHMMZpseBexrJQUWXR04nEWpJ2KDs0 e9mnGObwbbSiCNCTWgvcQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:lDYoMkibq2o=:1dySA6yYX6itqIEuDBElwO l1X1YMMMbthw5RsvjIDT2loxeUGORdnsWG35oBzX9XHK+1VrwZG65nmu9AuKCHjExWxTz0k0h deL5tdKeQcfRVlc1fYKaO3sIv57DJM+4b8YwA5QS4MagKLQQZx13mcJ5aKL0CsWCm64HRTemL cJATPXmRT5DDWhBosqx0zrqoI06ksPqozjMardAF2isNuV4PO1HR/mPa8I5aWsQrFjqBAL72O 2NTIuAYj0pI177cqNNq0c5RosNptUBU7ut4kgSumfBU3iWooaK6YmBTvKQzrIRAzR0JQhLsLb Ej/6i7BriwFVWKjgW/bqhbBNutAW6ztmcLcA6mq7JlVtpYQXFYpsIh4BkzlO8qDPKNiqCD7qX WIuceyn117j/LBAKcGJIJq1AvU+UbNUjxD5Fq9P9S+rOwJr8/1M1xBh4cic1RuK1/DQu+KhzY qssm0sOTwEN/Ua5Nj2uKOE5uRY4u7Bw2T5WHVI3QuWR+vCOKEsk0vi70CBhgNoi6uj/FfR4Vb 9ofjN15LvKC/qhOkyVzy/Foq0zkNxRZCpoIV/9pN77EkllkuiqiMOpaOmfvxu8Gd9RKEjc3FC xGYjUnANxUqq9UFhb3w7KuOCdtZCLbrfshD1I08QzT6cNay2gpK5YEzzZxQ4ytZCJPw6WCRJa Q0GqQxvzRDKZx8HNVjvl3TTkgOczWEo1NjCDS+X9mwuOb17WCv7mjwYOJgk676xgNlQo= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.72.192.73 Subject: [Qemu-devel] [2 2/2] linux-user/sparc/signal.c: Remove unnecessary comment X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Riku Voipio , Laurent Vivier Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell Remove a comment suggesting that we need to call tb_flush() after writing the SPARC signal frame trampoline insns. This isn't necessary in QEMU, because (even if the guest architecture requires explicit icache maintenance) we ensure that memory writes result in invalidation of translated code from that memory. Signed-off-by: Peter Maydell Message-Id: <20181009184017.15675-1-peter.maydell@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/signal.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/linux-user/sparc/signal.c b/linux-user/sparc/signal.c index b4c60aa446..e44e99993c 100644 --- a/linux-user/sparc/signal.c +++ b/linux-user/sparc/signal.c @@ -258,10 +258,6 @@ void setup_frame(int sig, struct target_sigaction *ka, __put_user(val32, &sf->insns[1]); if (err) goto sigsegv; - - /* Flush instruction space. */ - // flush_sig_insns(current->mm, (unsigned long) &(sf->insns[0])); - // tb_flush(env); } unlock_user(sf, sf_addr, sizeof(struct target_signal_frame)); return;