| Message ID | 20180819221707.20693-1-laurent@vivier.eu |
|---|---|
| State | New |
| Headers | show |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180819221707.20693-1-laurent@vivier.eu
Subject: [Qemu-devel] [PULL 0/6] Linux user for 3.1 patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20180819221707.20693-1-laurent@vivier.eu -> patchew/20180819221707.20693-1-laurent@vivier.eu
Switched to a new branch 'test'
7978cedd2d linux-user: add QEMU_IFLA_INFO_KIND nested type for tun
627fe9cda1 linux-user: update netlink route types
221a2f81a7 linux-user: fix recvmsg()/recvfrom() with netlink and MSG_TRUNC
47ed6a6db6 sh4: fix use_icount with linux-user
7d2dc89f58 linux-user: fix 32bit g2h()/h2g()
fce4efcc3d qemu-binfmt-conf.sh: add x86_64 target
=== OUTPUT BEGIN ===
Checking PATCH 1/6: qemu-binfmt-conf.sh: add x86_64 target...
WARNING: line over 80 characters
#29: FILE: scripts/qemu-binfmt-conf.sh:17:
+x86_64_magic='\x7fELF\x02\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x3e\x00'
ERROR: line over 90 characters
#30: FILE: scripts/qemu-binfmt-conf.sh:18:
+x86_64_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'
total: 1 errors, 1 warnings, 18 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/6: linux-user: fix 32bit g2h()/h2g()...
Checking PATCH 3/6: sh4: fix use_icount with linux-user...
Checking PATCH 4/6: linux-user: fix recvmsg()/recvfrom() with netlink and MSG_TRUNC...
Checking PATCH 5/6: linux-user: update netlink route types...
Checking PATCH 6/6: linux-user: add QEMU_IFLA_INFO_KIND nested type for tun...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On 19 August 2018 at 23:17, Laurent Vivier <laurent@vivier.eu> wrote: > The following changes since commit 0abaa41d936becd914a16ee1fe2a981d96d19428: > > Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2018-08-17 09:46:00 +0100) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux-user-for-3.1-pull-request > > for you to fetch changes up to c072a24c11e713f14ab969799433218d8ceebe19: > > linux-user: add QEMU_IFLA_INFO_KIND nested type for tun (2018-08-20 00:11:06 +0200) > > ---------------------------------------------------------------- > linux-user fixes: > - netlink fixes (add missing types, fix MSG_TRUNC) > - sh4 fix (tcg state) > - sparc32plus fix (truncate address space to 32bit) > - add x86_64 binfmt data > > ---------------------------------------------------------------- Hi -- I'm afraid this doesn't build on my ppc64 test box: /home/pm215/qemu/linux-user/syscall.c: In function ‘host_to_target_data_route_rtattr’: /home/pm215/qemu/linux-user/syscall.c:2719:10: error: ‘RTA_PREF’ undeclared (first use in this function) case RTA_PREF: ^ thanks -- PMM
Le 20/08/2018 à 16:44, Peter Maydell a écrit : > On 19 August 2018 at 23:17, Laurent Vivier <laurent@vivier.eu> wrote: >> The following changes since commit 0abaa41d936becd914a16ee1fe2a981d96d19428: >> >> Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2018-08-17 09:46:00 +0100) >> >> are available in the Git repository at: >> >> git://github.com/vivier/qemu.git tags/linux-user-for-3.1-pull-request >> >> for you to fetch changes up to c072a24c11e713f14ab969799433218d8ceebe19: >> >> linux-user: add QEMU_IFLA_INFO_KIND nested type for tun (2018-08-20 00:11:06 +0200) >> >> ---------------------------------------------------------------- >> linux-user fixes: >> - netlink fixes (add missing types, fix MSG_TRUNC) >> - sh4 fix (tcg state) >> - sparc32plus fix (truncate address space to 32bit) >> - add x86_64 binfmt data >> >> ---------------------------------------------------------------- Hi > Hi -- I'm afraid this doesn't build on my ppc64 test box: > > /home/pm215/qemu/linux-user/syscall.c: In function > ‘host_to_target_data_route_rtattr’: > /home/pm215/qemu/linux-user/syscall.c:2719:10: error: ‘RTA_PREF’ > undeclared (first use in this function) > case RTA_PREF: I've tested this on ppc64 box too before the p-l, and it has worked. The macro is in /usr/include/linux/rtnetlink.h that comes with kernel-headers-4.17.14-3.fc28.ppc64. I've checked in the kernel sources and the macro appears in the file in kernel v4.1 (c78ba6d64c78 ipv6: expose RFC4191 route preference via rtnetlink). I'm going to fix that. Thank you. Laurent