From patchwork Tue Jul 31 08:42:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 951472 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41fqhH18dfz9rxx for ; Tue, 31 Jul 2018 18:42:53 +1000 (AEST) Received: from localhost ([::1]:57622 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkQF0-0003BS-33 for incoming@patchwork.ozlabs.org; Tue, 31 Jul 2018 04:42:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fkQEj-0003B9-3c for qemu-devel@nongnu.org; Tue, 31 Jul 2018 04:42:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fkQEg-0005pm-12 for qemu-devel@nongnu.org; Tue, 31 Jul 2018 04:42:33 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:59171) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fkQEf-0005ns-Ix for qemu-devel@nongnu.org; Tue, 31 Jul 2018 04:42:29 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue007 [212.227.15.167]) with ESMTPSA (Nemesis) id 0LmRkt-1gKaKd0xVL-00aBtr; Tue, 31 Jul 2018 10:42:20 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Tue, 31 Jul 2018 10:42:02 +0200 Message-Id: <20180731084203.29959-3-laurent@vivier.eu> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180731084203.29959-1-laurent@vivier.eu> References: <20180731084203.29959-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:l52YK29W4RcdRtgSZYR/3yl72ugWcqgsGCQT1WYtd8JtO+gcOSB dEzSIluOvcRIIMyGKhS5qaIchqjOubU3ukFEoLBbrl1jJk4/icvlG01LS0xzgGHL4+2TpbP NYpY1uYdvuP84kUulPyAUUYsn8yKTOOPgsAgFp9TJM3JA/+4SeJEu4qi+wC0QIitduFnCUg u32j4ihZI6/tH1Eh3KjiQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:MLtbDN/5A/I=:E29OnVJkI7z2eMzCrV375E i+StIgnvDPk0ihLBBVAJBI06SSJk7llvvkyA318XUwmcg6b5x40OD/akw/SfM8mad0edNxk9n sWWKKW2iElhMSu1krg9e2gSvbziVK8yf++vnpqHQliKP/Bp9XOB4N5mpkh1Jcl3eWWBj9W7Ko bFXxZkTXspjcCj80uw304Z1RuYhHxJRpoJAsIMOTUkiGbI5KiqnuOZEMKucW2SgQZL9i4kA1p aDV0gNVoaFcxwX/icevJGkzPQ0vLtuwp809JFcYvdR1D5PqFG/3/74dIAOkwu4FxTrljdZ5s3 Yn9YVSgaoa29bp4LmDpOHOELe3Joi0m5yHnhfCtw17Rrzx91+L4M4UwgYwuAYssPpYGop9s44 gdtp+KnkDurIDgrJe7QZ0cW1PaynJiK+Z0zszUG6mKx8j7S/XrddWObUnolZv8LzK+KkKTlJ/ uHPNHi6pPoBXE3y95ZEMITptriIONJi+9g80eUWUvZT8oWMfZn3slqxtWwCdub8B6ywah4VpO H//AYKEcm51dQFedDkR5G6AIAeIA5rxwpIqCtmaudOam8CkT1zBOxxauDuVRJacYRZen0LgcL Wquv9JivckMY2BqKk/ixzkjpI56dEg4Gm/z4qM+/eMd2MrFkBU8SNwOTUEwvPfXa3kduLyRkS b3yfgMYXP4SyJntWf8MdlIqMGpDTmJIZq81ozyN2E97DStcA5Gg3s7Wv/Pf1z50w8DUQbmheK uYQ+Ti407l+O1VK8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.187 Subject: [Qemu-devel] [PULL 2/3] tests: add check_invalid_maps to test-mmap X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: umarcor <1783362@bugs.launchpad.net>, Riku Voipio , =?utf-8?q?Alex_Benn=C3=A9e?= , Laurent Vivier Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Alex Bennée This adds a test to make sure we fail properly for a 0 length mmap. There are most likely other failure conditions we should also check. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson Cc: umarcor <1783362@bugs.launchpad.net> Message-Id: <20180730134321.19898-3-alex.bennee@linaro.org> Signed-off-by: Laurent Vivier --- tests/tcg/multiarch/test-mmap.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/tests/tcg/multiarch/test-mmap.c b/tests/tcg/multiarch/test-mmap.c index 5c0afe6e49..11d0e777b1 100644 --- a/tests/tcg/multiarch/test-mmap.c +++ b/tests/tcg/multiarch/test-mmap.c @@ -27,7 +27,7 @@ #include #include #include - +#include #include #define D(x) @@ -435,6 +435,25 @@ void checked_write(int fd, const void *buf, size_t count) fail_unless(rc == count); } +void check_invalid_mmaps(void) +{ + unsigned char *addr; + + /* Attempt to map a zero length page. */ + addr = mmap(NULL, 0, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); + fprintf(stdout, "%s addr=%p", __func__, (void *)addr); + fail_unless(addr == MAP_FAILED); + fail_unless(errno == EINVAL); + + /* Attempt to map a over length page. */ + addr = mmap(NULL, -4, PROT_READ, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); + fprintf(stdout, "%s addr=%p", __func__, (void *)addr); + fail_unless(addr == MAP_FAILED); + fail_unless(errno == ENOMEM); + + fprintf(stdout, " passed\n"); +} + int main(int argc, char **argv) { char tempname[] = "/tmp/.cmmapXXXXXX"; @@ -476,6 +495,7 @@ int main(int argc, char **argv) check_file_fixed_mmaps(); check_file_fixed_eof_mmaps(); check_file_unfixed_eof_mmaps(); + check_invalid_mmaps(); /* Fails at the moment. */ /* check_aligned_anonymous_fixed_mmaps_collide_with_host(); */