Message ID | 20180703163451.16936-1-laurent@vivier.eu |
---|---|
State | New |
Headers | show |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180703163451.16936-1-laurent@vivier.eu Subject: [Qemu-devel] [PULL 0/7] Linux user for 3.0 patches === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' b5c1e944b9 linux-user/strace: Improve recvmsg() output b9c50502fd linux-user/strace: Improve capget()/capset() output 17c4fd8620 linux-user: update do_setsockopt() f90cf93e26 linux-user: add netlink CARRIER_UP_COUNT/CARRIER_DOWN_COUNT 06f47f9723 qemu-binfmt-conf.sh: allow to provide a suffix to the interpreter name 55dacf9bb6 qemu-binfmt-conf.sh: add persistent (F) flags 1e59cd7ad3 qemu-binfmt-conf.sh: cleanup --credential === OUTPUT BEGIN === Checking PATCH 1/7: qemu-binfmt-conf.sh: cleanup --credential... Checking PATCH 2/7: qemu-binfmt-conf.sh: add persistent (F) flags... ERROR: line over 90 characters #56: FILE: scripts/qemu-binfmt-conf.sh:320: +options=$(getopt -o ds:Q:e:hc:p: -l debian,systemd:,qemu-path:,exportdir:,help,credential:,persistent: -- "$@") total: 1 errors, 0 warnings, 45 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 3/7: qemu-binfmt-conf.sh: allow to provide a suffix to the interpreter name... ERROR: line over 90 characters #77: FILE: scripts/qemu-binfmt-conf.sh:323: +options=$(getopt -o ds:Q:S:e:hc:p: -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential:,persistent: -- "$@") total: 1 errors, 0 warnings, 69 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/7: linux-user: add netlink CARRIER_UP_COUNT/CARRIER_DOWN_COUNT... Checking PATCH 5/7: linux-user: update do_setsockopt()... Checking PATCH 6/7: linux-user/strace: Improve capget()/capset() output... Checking PATCH 7/7: linux-user/strace: Improve recvmsg() output... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On 3 July 2018 at 17:34, Laurent Vivier <laurent@vivier.eu> wrote: > The following changes since commit ab08440a4ee09032d1a9cb22fdcab23bc7e1c656: > > Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20180702' into staging (2018-07-02 17:57:46 +0100) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux-user-for-3.0-pull-request > > for you to fetch changes up to 377e93e9e85e76c7fd7af900ba965743243a6618: > > linux-user/strace: Improve recvmsg() output (2018-07-03 16:27:15 +0200) > > ---------------------------------------------------------------- > Some strace cleanups > Minor fixes for setsockopt() and netlink > Manage 'F' flag with qemu-binfmt-conf.sh > > ---------------------------------------------------------------- Applied, thanks. -- PMM