From patchwork Thu Feb 15 15:39:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brijesh Singh X-Patchwork-Id: 873971 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="CSp+uTdF"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zj1C60WVjz9t1t for ; Fri, 16 Feb 2018 02:58:10 +1100 (AEDT) Received: from localhost ([::1]:32902 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emLvE-0004zj-5N for incoming@patchwork.ozlabs.org; Thu, 15 Feb 2018 10:58:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35800) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1emLeh-0004Y9-HG for qemu-devel@nongnu.org; Thu, 15 Feb 2018 10:41:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1emLed-0003bA-IP for qemu-devel@nongnu.org; Thu, 15 Feb 2018 10:41:03 -0500 Received: from mail-cys01nam02on0069.outbound.protection.outlook.com ([104.47.37.69]:31616 helo=NAM02-CY1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1emLed-0003aw-9Y for qemu-devel@nongnu.org; Thu, 15 Feb 2018 10:40:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=hmvFoLrpR37+o9yy8PfBRojef8SSpELGZdM7T82RAm0=; b=CSp+uTdFT01JD3wW3fAxF+22DN9bq/p46ILUSwo3lDNN9qslUzP2SgGPvvwC4xw5t7U/Eu8swUWfEAwGWfXfi/xbEXCqPjsnIFUtLxxkH97JhCDdAaLLa3xY2RPtZud1QqJ0AgQhrNdsixmE1IM1XqC7hfirVRa9nvaDtt2hxNE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Received: from wsp141597wss.amd.com (165.204.78.1) by SN1PR12MB0157.namprd12.prod.outlook.com (10.162.3.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.506.18; Thu, 15 Feb 2018 15:40:53 +0000 From: Brijesh Singh To: qemu-devel@nongnu.org Date: Thu, 15 Feb 2018 09:39:44 -0600 Message-Id: <20180215153955.3253-19-brijesh.singh@amd.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180215153955.3253-1-brijesh.singh@amd.com> References: <20180215153955.3253-1-brijesh.singh@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: CY4PR04CA0044.namprd04.prod.outlook.com (10.172.133.30) To SN1PR12MB0157.namprd12.prod.outlook.com (10.162.3.144) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 56d11e8d-5d90-44f9-8758-08d5748a80e5 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:SN1PR12MB0157; X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0157; 3:JbI0TfSUqGEIOpO0OVz7oixkLQAmA4iOMPMjD0+3bIAfxlSgzJBXFkPGKiwpYuZEW3N2dBv5mBf0OYuUbWarr2Jd5GBT80iMrgJPo14B6TOVZiDBEyzkA2iIkG58BV/s6GDxbA4ivyUWFkxgAtnF9yFoqXjLRuIA589DY6Vzw0qrWmk79QSbEviBkn6hWvysRirPqXc9phWd2mlmZSkdxzjhtoQo2IlKnAyGBPp0vCbD+cKmrPlwWrdEXD8iDjcV; 25:5fIh4XKoDZbK8UbDSBYvVkKZSsFp6hbFqospTmjSDtTwazHZrhlpSygxdc+/wrn/YCcY4hp23RcFQzxmRCZ7Ek3CjdPkz68Xm0C0A/dd/zcNGlL2uDnlvrRN6HTOtWpqDAKofTkF5deK1QZfmK7npTJiw9OuJUiwGwNkHz7fY+bbGELS4s6CgE0UROizrtf5JhDtxZQsORIqfThvjfwb4ehGYB4duEtgOO1DsVd2lIK1fgPkrvyjuWKjcnTdkPV3fefl2AJDgM34NMupnrT4Fgc9kv7Ebz9VNv0BhHMuvaYtr4euLgvAQ1/S1q5BVIgbZGfBP2TVJMaP7BXUzdbxig==; 31:lP5RfwB+3PA3k3TEaZwpTFVvd3oSt17e4sAJTJFvKkj2ziiygWeMDtqLy58UUgcfWkGKL8Ft3d1bPOEqr/hb7tRdvRz7/dZCDF77NlJneUiffBwvX7tl/hnxQiKhaay5ijVJTzxYB1TpALopy+pWLAI7L0rWthMFf90sxGE4zK3w7gbHV27IY19tEDJByEPv/2CzY/OgaaPayLb9rjtu4pC5KRaiemVCQ4q1dXATyME= X-MS-TrafficTypeDiagnostic: SN1PR12MB0157: X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0157; 20:0VvEvmbwQfSdK0BYN76O+xDh0wWbn9YndlZPj+D5r7JnuwQvRNRrF7REioHMx50QDz4bi5SNE/9DE07Mbk4TEAMbm9ArrOzTRCi+JOYSYOnetTHm2Iz+1GHDr8G57tnb7EOBQ8aqVDDKbTXY5Tt6MqaBU84xwVBQGdoIQ+tHGyrpuZubQ7JD1SJK2l1kPNp/c8VkZjRyvjZWrTCTUmSbIB5NRZGYcWjAaq1FaTVSgp84ndMc5OO5ziEVa76leMGct6HaDoA6FXeM59XWj7bk6VvXSOzJvClH3sOYZoPsi5AA6BAp0QYgIC39f+8Sm5SXeZC048vJWnM4IfRkFrLzktGRX9a9VLCbWpfFKiYDenbWDDbBuRl9LMvxPXD801/MUMOf1CW5KiB/0nuflCEibSU5AuR9xtwvJez3j/dMv6CpSdBd+oY94cbo/H74K3Jt9ZHE6c3rBHgYi9iu8dCN4OIR5d4WylQXEbzdeDNrXapQUVwV5IdYNur2nd17HWGI; 4:DlGGZHsV2DuKuX30xRaaMmatBott1Q3rmQjb4jtH966akczZRYYE+IvAWgpm+x9kTcWGFn4WFNUGB4MENqstIO9kqP+QN9eNz4j5zUn2qlBaImzB4qz7EEp4mEsdUZWYGK3JZmq3DtEY8wZusN042B7CG7MrR7KdHkevP/NuWlaEg8oSglDDEKnoznwkB4l8viAav/dli1g06TD4QprL9ye5EVNn7LlsxeSrzd5TFl1hrDU4gq4AfFOfZxnyO4plT328giKdJPWiysA5rPMZuDpNlE8KSnUUnyfPSewteUPKcuLTnO9GZt7bpE837P5A X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231101)(944501161)(6055026)(6041288)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:SN1PR12MB0157; BCL:0; PCL:0; RULEID:; SRVR:SN1PR12MB0157; X-Forefront-PRVS: 058441C12A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(1496009)(376002)(39380400002)(346002)(396003)(39860400002)(366004)(189003)(199004)(26005)(3846002)(386003)(8936002)(5660300001)(186003)(16526019)(316002)(6666003)(8666007)(1076002)(54906003)(6116002)(48376002)(50466002)(7416002)(478600001)(59450400001)(8676002)(68736007)(86362001)(575784001)(16586007)(2906002)(50226002)(39060400002)(2351001)(6916009)(7736002)(106356001)(51416003)(8656006)(52116002)(25786009)(4326008)(97736004)(2950100002)(6486002)(2361001)(36756003)(76176011)(81166006)(53416004)(66066001)(53936002)(81156014)(47776003)(305945005)(105586002)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR12MB0157; H:wsp141597wss.amd.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR12MB0157; 23:gfceMaGlLl25YAdhMtsi4Rf7wEYe7FYRSDshPFqV6?= t+bOJOXPc1cjHN9+3SCkjIeEXlGMjlG8s+xSzuspcqhZwfsWeuKi+AByCJ/M+BG/oSeivF5gqBFX3wzR98+HuQlXUSZJTiQy4t6w9+2p2RNw5R0BClqaGClWe0ocNrtsNgbnxnV9yjh3r3qXkzYaxzKCF8Iy7kbnAZNKa7xJHxknjGMkSbGUg2ZkecSqt4SRy+Kq7+oAY0nhzQL6mbP/Ff6DqcfBl6lF+eTZTrWpTFxvqKlWvTW7eYv/c3uxwZ+I8rBc87Kl0hjAvVz67EFLTywKUrg0cqrxnk3AeOLJ7ZLh9uYTrQ2d4a3ps3e55PqcOX6swwE/oQI4jtk7rtY20X2S4yx6lcOzekemlv9+yXJ4C6aGS2+YEvvax+Kw40VvmfaHK9IypN/lPX+l4VaWW0v/7vN4dYv3Ok47Z0jn05CKncQJ6juMX9EXfFttNCXY34SDDi1PNWJNR0uh7AnFr7FH6dC9kd/r5cVgNEe8XFAIq0tChZpO8x3kiz12n3XzIeS/PHmv41FQIeg0XlFm1DunUQ4y5+xWB3EDx4iPVr8wygb7Wup6Y5nH/PKuYRRtZFZGbnOzumCW3YTWLezmcFACDInF3QD0FqZQ8CtFL0Vh9Uhz/4juGLl1olld4IKGSijOKOYfR5HLXl1W4GBdtdMuB4D1dWF8Zhqu4RELJo5sX4L8r2JXUA7uf/1AUZjDv7uEA2gSEAd47kHGQOGqSXvBrLDPBlb7H+2DNP0ihuj2Q+ph0InL6480LrtjABJAdV72QnAOc+2f0GNCN/sYqmgfTaanhFnseuCDATZ/fWIC+YOxP4kLXpzmbhFJ1+uY2cliXaF97ouGP7X8yp3t+SQ9FHQSZYgFmFX7ESvEej6K68EJsOLrLjDx7qpFkrBBp94zOsPplyHS38PjJQM9FsikzvU/eK251eYyQW+3K4suHI4qnwGSFLLIupGy4xacNmaWoJ/knkfeHLtXmeaP87NOZMBp3a5HgnMr5eFWppt5PZE6qLWHYAYb5A0ZzxEFGoDn6CVNrnRG93fEMq+shQ8ry08cf1DYZd7w0nUqObacdu0M7AJ29U5qQqxnC4rrO8ZPMdQhqR/4feKCFZ6W1l76ayRNl7v8Q1IexzqfKKhoOOKMhe6lU58tmHp/o0QNIUpwMYvIyNoWAwcVETihycymQPg9bbgi14LiWywec5ihkv5NjLx+5fX+XHstwUkRQD4EBvntWcb7qEvuLsYq3Lwfprxv1kf6dI3Xy935wNkqvM1uN5CFvZnqUj+xBclg+vMVsE/MK4SaHdgw5ooiGTT X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0157; 6:lST/vpXvfysFaHEUw4GwVzZtgsGr95vPybr2NjnBSBCZP2kb/MwOXwpyri80txOgc6P/fHUYHhCXWbCXSDaRFuVLMgj/DkglOFnS/EamcSDNx2woa9IvsvE6IGMG22l55zT3Fj8C88oSRXjW6KekM3blLQi0qe44r0TtU8HONlUHKbrP+43gmaqHRn5wISa0CosCkzuFzAcAqPz2rdExKpC94L63SfTHB6ELhGUhOSZLzoX88GfD6DJ7y4YL/EyFcG0kVe2pZIm/+5xUP+qZwx7WTzSbf7yG9yoFUm4hgBMK5pWNgQ8QQhSrf1n82j+YK9dN6B6XGOKqXzI5paIFMbRZJJav5Xiuh7lzjaLUJ/4=; 5:kdmZbGe20uoYps5/kcKqfjvvILqDwKmq1dqd2RlRgcNPBWISLg4IoDTfjdr5xt5w0xsuCEf49KBgZ9fjhHFJf9VxVjOEbGPQY596PSENOZTb5K/bggDfyqxppJVnSiCD/7nh/kx0QBduVARus/rwfexjwfV30sW9wDXWnqCwRgU=; 24:JLcSj0XgqULW96ZBb3Otsa3FX5j/arXk4oCyS3ha9h4r2TIIAMy28dYeDGbsLGZOOK4XouK4+38Ho1yTHeetD6QzikQ/JzL7A/6pk1p9rME=; 7:0Qj3hqBDE16z54O7KuUjiOrj7ocLOTXVVUH5991D//zopE/qmNRtRq6iZkU//ZZ4KraGgwTNuVztn5ezlAd+XuPd6lqEzEt4RJuePFseZWLrRzdBKOm6riv0IYDhRrQR7MPTxeEb5U/d72DovCIp0NLCNF7nKyFVYJCbdBKx5VBgVMXzCcRPYIdUEsSaC/TJw+01e5v5CH/R6qCN/ypiho0EwnbQapz5DuirtTOBziVQ9LSRXcnfaZx0oIVeUTOL SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; SN1PR12MB0157; 20:iXuVt5DzdMjdDL3P0SdmXAmXwy5hHEJOx8oCqWSGRMQn5Mmix/F9xn2ajnVX9+SNjtHlMoS2F1phDDmNRTVpzAkOMaNn0ibpX7OSkyke8e1FNzrGIvylou2PmT7G16DiJC2FYskXuwkamMmutTa6emhxMWZHrPHZMcRZ3nObXNu06Wh9dqW4NaK580EivqIePKsSlOc1Rvn3qbY3Ux9x4PTBzoN8FTopfH64+nXzO15KWeVkDfIsLn1RofvM/2zc X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2018 15:40:53.9159 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 56d11e8d-5d90-44f9-8758-08d5748a80e5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0157 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.37.69 Subject: [Qemu-devel] [PATCH v9 18/29] sev/i386: add support to LAUNCH_MEASURE command X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Brijesh Singh , kvm@vger.kernel.org, "Michael S. Tsirkin" , Stefan Hajnoczi , Alexander Graf , "Edgar E. Iglesias" , Markus Armbruster , Bruce Rogers , Christian Borntraeger , Marcel Apfelbaum , Borislav Petkov , Thomas Lendacky , Eduardo Habkost , Richard Henderson , "Dr. David Alan Gilbert" , Alistair Francis , Cornelia Huck , Richard Henderson , Peter Crosthwaite , Paolo Bonzini Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" During machine creation we encrypted the guest bios image, the LAUNCH_MEASURE command can be used to retrieve the measurement of the encrypted memory region. This measurement is a signature of the memory contents that can be sent to the guest owner as an attestation that the memory was encrypted correctly by the firmware. VM management tools like libvirt can query the measurement using query-sev-launch-measure QMP command. Cc: Paolo Bonzini Cc: Richard Henderson Cc: Eduardo Habkost Signed-off-by: Brijesh Singh --- include/sysemu/sev.h | 2 ++ stubs/sev.c | 5 ++++ target/i386/sev.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++++ target/i386/trace-events | 1 + 4 files changed, 76 insertions(+) diff --git a/include/sysemu/sev.h b/include/sysemu/sev.h index c16102b05ec4..ad4a1f1338ec 100644 --- a/include/sysemu/sev.h +++ b/include/sysemu/sev.h @@ -33,6 +33,7 @@ extern void sev_get_fw_version(uint8_t *major, uint8_t *minor, uint8_t *build); extern void sev_get_policy(uint32_t *policy); extern uint32_t sev_get_cbit_position(void); extern uint32_t sev_get_reduced_phys_bits(void); +extern char *sev_get_launch_measurement(void); typedef struct QSevGuestInfo QSevGuestInfo; typedef struct QSevGuestInfoClass QSevGuestInfoClass; @@ -64,6 +65,7 @@ struct QSevGuestInfoClass { struct SEVState { QSevGuestInfo *sev_info; + gchar *measurement; }; typedef struct SEVState SEVState; diff --git a/stubs/sev.c b/stubs/sev.c index 74182bb545e2..5420ada7fd6e 100644 --- a/stubs/sev.c +++ b/stubs/sev.c @@ -57,3 +57,8 @@ void sev_get_fw_version(uint8_t *major, uint8_t *minor, uint8_t *build) void sev_get_policy(uint32_t *policy) { } + +char *sev_get_launch_measurement(void) +{ + return NULL; +} diff --git a/target/i386/sev.c b/target/i386/sev.c index 04a64b5bc61d..401b2a33d7cc 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -19,6 +19,7 @@ #include "sysemu/sev.h" #include "sysemu/sysemu.h" #include "trace.h" +#include "qapi-event.h" #define DEFAULT_GUEST_POLICY 0x1 /* disable debug */ #define DEFAULT_SEV_DEVICE "/dev/sev" @@ -28,6 +29,7 @@ static bool sev_active; static int sev_fd; static uint32_t x86_cbitpos; static uint32_t x86_reduced_phys_bits; +static SEVState *sev_state; static SevState current_sev_guest_state = SEV_STATE_UNINIT; @@ -502,6 +504,69 @@ err: return ret; } +static void +sev_launch_get_measure(Notifier *notifier, void *unused) +{ + int ret, error; + guchar *data; + SEVState *s = sev_state; + struct kvm_sev_launch_measure *measurement; + + if (!sev_check_state(SEV_STATE_LUPDATE)) { + return; + } + + measurement = g_malloc0(sizeof(*measurement)); + if (!measurement) { + return; + } + + /* query the measurement blob length */ + ret = sev_ioctl(KVM_SEV_LAUNCH_MEASURE, measurement, &error); + if (!measurement->len) { + error_report("%s: LAUNCH_MEASURE ret=%d fw_error=%d '%s'", + __func__, ret, error, fw_error_to_str(errno)); + goto free_measurement; + } + + data = g_malloc(measurement->len); + if (s->measurement) { + goto free_data; + } + + measurement->uaddr = (unsigned long)data; + + /* get the measurement blob */ + ret = sev_ioctl(KVM_SEV_LAUNCH_MEASURE, measurement, &error); + if (ret) { + error_report("%s: LAUNCH_MEASURE ret=%d fw_error=%d '%s'", + __func__, ret, error, fw_error_to_str(errno)); + goto free_data; + } + + sev_set_guest_state(SEV_STATE_LSECRET); + + /* encode the measurement value and emit the event */ + s->measurement = g_base64_encode(data, measurement->len); + trace_kvm_sev_launch_measurement(s->measurement); + +free_data: + g_free(data); +free_measurement: + g_free(measurement); +} + +char * +sev_get_launch_measurement(void) +{ + return current_sev_guest_state >= SEV_STATE_LSECRET ? + g_strdup(sev_state->measurement) : NULL; +} + +static Notifier sev_machine_done_notify = { + .notify = sev_launch_get_measure, +}; + void * sev_guest_init(const char *id) { @@ -569,6 +634,9 @@ sev_guest_init(const char *id) x86_cbitpos = cbitpos; sev_active = true; ram_block_notifier_add(&sev_ram_notifier); + qemu_add_machine_init_done_notifier(&sev_machine_done_notify); + + sev_state = s; return s; err: diff --git a/target/i386/trace-events b/target/i386/trace-events index c0cd8e93217f..f7a1a1e6b85c 100644 --- a/target/i386/trace-events +++ b/target/i386/trace-events @@ -13,3 +13,4 @@ kvm_memcrypt_unregister_region(void *addr, size_t len) "addr %p len 0x%lu" kvm_sev_change_state(const char *old, const char *new) "%s -> %s" kvm_sev_launch_start(int policy, void *session, void *pdh) "policy 0x%x session %p pdh %p" kvm_sev_launch_update_data(void *addr, uint64_t len) "addr %p len 0x%" PRIu64 +kvm_sev_launch_measurement(const char *value) "data %s"