Message ID | 20171204140150.20483-6-david@redhat.com |
---|---|
State | New |
Headers | show |
Series | s390x/tcg: facilitites and instructions | expand |
On Mon, 4 Dec 2017 15:01:46 +0100 David Hildenbrand <david@redhat.com> wrote: > Just like KVM does, we should suppress this instruction: > When this instruction is not provided, it is > checked for privileged operation exception and the > instruction is suppressed by the machine > > Signed-off-by: David Hildenbrand <david@redhat.com> > --- > target/s390x/insn-data.def | 1 + > target/s390x/translate.c | 7 +++++++ > 2 files changed, 8 insertions(+) Yes, given that we don't support real channel paths, we can't implement it in a useful way anyway.
diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index e21d226092..c7353e7f11 100644 --- a/target/s390x/insn-data.def +++ b/target/s390x/insn-data.def @@ -1056,6 +1056,7 @@ C(0xb238, RSCH, S, Z, 0, 0, 0, 0, rsch, 0) C(0xb237, SAL, S, Z, 0, 0, 0, 0, sal, 0) C(0xb23c, SCHM, S, Z, 0, insn, 0, 0, schm, 0) + C(0xb23a, STCPS, S, Z, 0, 0, 0, 0, stcps, 0) C(0xb233, SSCH, S, Z, 0, insn, 0, 0, ssch, 0) C(0xb239, STCRW, S, Z, 0, insn, 0, 0, stcrw, 0) C(0xb234, STSCH, S, Z, 0, insn, 0, 0, stsch, 0) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index bd3fc6448e..5c2432678c 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -4102,6 +4102,13 @@ static ExitStatus op_schm(DisasContext *s, DisasOps *o) return NO_EXIT; } +static ExitStatus op_stcps(DisasContext *s, DisasOps *o) +{ + check_privileged(s); + /* The instruction is suppressed if not provided. */ + return NO_EXIT; +} + static ExitStatus op_ssch(DisasContext *s, DisasOps *o) { check_privileged(s);
Just like KVM does, we should suppress this instruction: When this instruction is not provided, it is checked for privileged operation exception and the instruction is suppressed by the machine Signed-off-by: David Hildenbrand <david@redhat.com> --- target/s390x/insn-data.def | 1 + target/s390x/translate.c | 7 +++++++ 2 files changed, 8 insertions(+)