From patchwork Wed May 3 10:52:24 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Guangrong X-Patchwork-Id: 757955 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wHwBF1t3tz9rvt for ; Wed, 3 May 2017 20:58:29 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="eeLANSwH"; dkim-atps=neutral Received: from localhost ([::1]:35786 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5rzG-0000tO-Oy for incoming@patchwork.ozlabs.org; Wed, 03 May 2017 06:58:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d5ruQ-0005Sk-7w for qemu-devel@nongnu.org; Wed, 03 May 2017 06:53:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d5ruP-0006mJ-Ij for qemu-devel@nongnu.org; Wed, 03 May 2017 06:53:26 -0400 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]:34024) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d5ruP-0006m3-CR for qemu-devel@nongnu.org; Wed, 03 May 2017 06:53:25 -0400 Received: by mail-pg0-x242.google.com with SMTP id t7so27786569pgt.1 for ; Wed, 03 May 2017 03:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Uyu1HGrv7EpyYKXZd+0wIZBEfRmPoVJhH7a8qcwNe2U=; b=eeLANSwH5kGp93HKpjztPZBll9Y/7xIJx7SnaqgRNHjELOqRXwfEwSOI+icNHgS3dU cGlGJLuqBlWv5kgo/1RlAyLYN+ipasQQ65PumtsC8/i0mi8xKBBC/OhvSgiwsOl6KfmU kqhzVUWl8qxZQ38b1ZVYsMPKYqduFrLqqW0+lMDR/WnKSLK3w6C2Hj4Ny1h4Wz69vA26 O4CK4wviBDdrwLjh5o9MJVP/RVIA0oRo3cXGQ6KeMOmxcj7sZYOQW7rijkc94CnnHtqz Co/70xANK5iNMmlWWkO7b2smUPsW45WOkO5dJ9ZvGbrO70ouWmkttK0olmzfmDVnqcC0 jWDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Uyu1HGrv7EpyYKXZd+0wIZBEfRmPoVJhH7a8qcwNe2U=; b=KNQBJ45E8Ui5g3MoHz8LwtX0SwJ7ZZTo/fwElVPg+l6EOjUcVKKfh42wZz311dzQQT HYk2cT2L93Jqq0TpdiM0laGMphtoEKaCpE7n2IspxSEu97dfjoFzi7itJmbNhMgjDdHP SKM01ZG6q9hari9qtg4zy9NKZh558JJCcy1qrnY9msN7VuIKX37gEBj+/Ezle3TokUnw PjgbEwrpmLpddqaUrsnJi0PXyA9gECWcwAaGNlvFaQmR+1/Tnqp24ANH0rSgrG3U+v3d 7poohK+JUhQ7quAjF6nQawPMdzCGXIICycOm+XDDo44O+iDNmxgHqMV9C4M9ovi+85+4 +QEA== X-Gm-Message-State: AN3rC/4VuEi4QuF2F6/zHc0qsUP1DvPhqudaoSRJsmtcsZFPSC2xsypv WrpRlkJNOiaKaw== X-Received: by 10.99.247.83 with SMTP id f19mr38910987pgk.190.1493808804543; Wed, 03 May 2017 03:53:24 -0700 (PDT) Received: from eric.tencent.com ([203.205.141.35]) by smtp.gmail.com with ESMTPSA id d24sm4395561pfb.97.2017.05.03.03.53.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 May 2017 03:53:24 -0700 (PDT) From: guangrong.xiao@gmail.com X-Google-Original-From: xiaoguangrong@tencent.com To: pbonzini@redhat.com, mtosatti@redhat.com, avi.kivity@gmail.com, rkrcmar@redhat.com Date: Wed, 3 May 2017 18:52:24 +0800 Message-Id: <20170503105224.19049-8-xiaoguangrong@tencent.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170503105224.19049-1-xiaoguangrong@tencent.com> References: <20170503105224.19049-1-xiaoguangrong@tencent.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c05::242 Subject: [Qemu-devel] [PATCH 7/7] KVM: MMU: stop using mmu_spte_get_lockless under mmu-lock X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xiao Guangrong , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Xiao Guangrong mmu_spte_age() is under the protection of mmu-lock, no reason to use mmu_spte_get_lockless() Signed-off-by: Xiao Guangrong --- arch/x86/kvm/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index f6a74e7..a8b91ee 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -852,7 +852,7 @@ static u64 restore_acc_track_spte(u64 spte) /* Returns the Accessed status of the PTE and resets it at the same time. */ static bool mmu_spte_age(u64 *sptep) { - u64 spte = mmu_spte_get_lockless(sptep); + u64 spte = *sptep; if (!is_accessed_spte(spte)) return false;