From patchwork Thu Jan 26 08:04:48 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 719980 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3v8F3m1skbz9rxw for ; Thu, 26 Jan 2017 19:11:00 +1100 (AEDT) Received: from localhost ([::1]:36698 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWf8z-0002Ok-Qt for incoming@patchwork.ozlabs.org; Thu, 26 Jan 2017 03:10:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWf3R-0005jm-FL for qemu-devel@nongnu.org; Thu, 26 Jan 2017 03:05:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWf3N-0003dv-9r for qemu-devel@nongnu.org; Thu, 26 Jan 2017 03:05:13 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:55075) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cWf3N-0003d6-0M for qemu-devel@nongnu.org; Thu, 26 Jan 2017 03:05:09 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue004 [212.227.15.167]) with ESMTPSA (Nemesis) id 0MJ09d-1cUB0p1vg1-002b31; Thu, 26 Jan 2017 09:04:54 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Thu, 26 Jan 2017 09:04:48 +0100 Message-Id: <20170126080449.28255-3-laurent@vivier.eu> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170126080449.28255-1-laurent@vivier.eu> References: <20170126080449.28255-1-laurent@vivier.eu> X-Provags-ID: V03:K0:8YQnQecgl6lEMi011np1lP4E4ZxMIqJ3r8mwgsOYL6z6wAyidmW Ld3jPf1VnJz7nzpLdltUPyvumSbxA5ADJQaRoGACVP16OvEk9rkJXbFsNvIq6fl3aY8Ij3m vVQCixkZiMJUw0Qm5F8URGJ0vMyoGOysfP8RsffWa3CtYdJyij0kBds1wc39zuwNDsbLGFo y4MYADxM7YzqdKEGbMXVw== X-UI-Out-Filterresults: notjunk:1; V01:K0:vPOjZfLVvBs=:lDEY9HyWM+XOtGp6nsUkQD ZHSkpZr1eqQWmqHCmC1pMYjDM/FXAy5nG+JBNyvNWeSurjIVKtyUwGGHDrFzzuPWXlzU6DxO+ Qruchl6pVN9ipHhXiJq5EJXSN46imLzLPKf6aoLOS7H4iV2zqxg/b8y3N9/792nT6kSxyKyyq 1A2q8hcD3l1qUES4/gTNkshuRWys9PCzDB+dzQERi1ltzsHFxezNI8JFigKfJQIYoSwouV2/2 WRaaGADzCinYpN0wLAGY0NKGlKEttSrrOa7i6L7JZV/iQGxFlMPwv08UhV+JjdRSZp4bW7f3S rmCJF0/jVPOhb6UPiGucVSOw0RvdaefwyrSUUbNDgUGqQAUVi4dC93vHzl+tzXHGYswWB4kv4 RNoaMIb8wGgno800R/ecdAXX4IONElOV3o3NG5PdoNbbESd1CTYrRjgcFND3nB79TYs5xOxEW wev0rK7wTPJrqO3zwZpHKcGqQVwRZEKEe6Q1QgoLrZjVv5Xljyk6c6EYKTmGvpP1j2rhk7CNU YK8/uK4QbZoajpZ6nkky7ZYdxodxwX7/T/i6LYAJEVYiKFpS3NnE/T5T+FloL/Z+VhuvGGETQ dFr0JbyiSmhpFygRjIruUTIQh5/qgP/WQf7gf7ykqQypNR2sUYJaGiXzNf+7zJ77BEhiH5yz8 cXOhrK1+bmxPtUdF456hs5L4/1JgYDFdveyTVtqTX61eZPX/DDDwDyom0XiOnIH7DPVg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.133 Subject: [Qemu-devel] [PATCH v3 2/3] linux-user: fix "apt-get update" on linux-user hppa X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Richard Henderson , Riku Voipio , Laurent Vivier , John Paul Adrian Glaubitz Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" apt-get was hanging on linux-user hppa. strace has shown the netlink data stream was not correctly byte swapped. It appears the fd translator function is unregistered just after it has been registered, so the translator function is not called. This patch removes the fd_trans_unregister() after the do_socket() in the TARGET_NR_socket case. This fd_trans_unregister() was added by commit e36800c linux-user: add signalfd/signalfd4 syscalls when do_socket() was not registering any fd translator. And as now it is, we must remove this fd_trans_unregister() to keep them. Reported-by: John Paul Adrian Glaubitz Signed-off-by: Laurent Vivier Tested-by: John Paul Adrian Glaubitz --- linux-user/syscall.c | 1 - 1 file changed, 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 11a311f..9be8e95 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -9343,7 +9343,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, #ifdef TARGET_NR_socket case TARGET_NR_socket: ret = do_socket(arg1, arg2, arg3); - fd_trans_unregister(ret); break; #endif #ifdef TARGET_NR_socketpair