From patchwork Wed Jan 25 20:38:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 719862 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3v7xl35vsTz9sCg for ; Thu, 26 Jan 2017 07:40:31 +1100 (AEDT) Received: from localhost ([::1]:34430 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWUMn-0006Ry-9D for incoming@patchwork.ozlabs.org; Wed, 25 Jan 2017 15:40:29 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cWULb-0005YM-CV for qemu-devel@nongnu.org; Wed, 25 Jan 2017 15:39:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cWULY-0007RT-9i for qemu-devel@nongnu.org; Wed, 25 Jan 2017 15:39:15 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:53940) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cWULX-0007R3-VU for qemu-devel@nongnu.org; Wed, 25 Jan 2017 15:39:12 -0500 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.167]) with ESMTPSA (Nemesis) id 0Li5PX-1cAxMZ41ml-00nRco; Wed, 25 Jan 2017 21:38:57 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Wed, 25 Jan 2017 21:38:52 +0100 Message-Id: <20170125203852.19254-3-laurent@vivier.eu> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170125203852.19254-1-laurent@vivier.eu> References: <20170125203852.19254-1-laurent@vivier.eu> X-Provags-ID: V03:K0:mz/0oFfMJ0bWa+MTYsql4RHvxEUbhXYJhIjeYs4yTcvJ2mEaf8E VlFzglSXPXXlpowqqMM2wEr4BEbBvaEoDEHlGFKfWAWqfnUlRGz1Pozf8YeyL8MqWHA88uq QQMvXWNf1auE+Y4HKjBMryTvTQQuKDI8qays20mycSe7sO4g6XnukLGCmUMXKrYxenbK5ON pAEeKu4M/+jWQBBckaXxQ== X-UI-Out-Filterresults: notjunk:1; V01:K0:PIQdgMJCLCk=:BM6zseo2z1FxNDGw5iMafG oN7rvRQ19F170CB96qIReIN0j6Rycm8HfA04RC6Jn8NnFeMKA65h2Bef16dfjlEOJDMxnwyip cy8EfCcM0R6ae0ZUNavd2Mm56i0N6lUvuhzf8ke6epZMHcWGdQKVFylgbRcKIVqTrH3cbb385 DtS7BCLkxnhfReGuyARlxx/Fi3HLVqGTXhmQY0egoXsb5UHeKLQr3l22/WJgOc+TRUQPOopPC ycE7mo9u/lqhw+61La0hCrayynDaqKCcmRvYEqwTgGT4Btv1DidpioDZ+ENsqEwY4lSNITQ2/ iMddQAMW8YJwKJ6q1pg5gXPsa4gJeJZllElmVRcUejNXvWpsZKRd6QkLq0Isb64vwfT3z29QU K0PCm2y/drpFM/4VjGSs0icGBzvBJXU2ZuW9plntQUnvyVa0e0bnwhHQQkzOIuDGhO/JUU0sJ EY1nR9jOY2ud6NV/xo68WkSzBrp/6YEqJYggp4ma1ZMZ9Q5QjFgZHQ5l8VX2GkSAWDxcstLu9 LWwtdw8v8xfF5gy+TB8ROMdCAY+/3C6UfJlIXcxDG4ji+1WD99SD8MGZvth6a9dfjtQVT5tNs bkXY2L4jX9ZD5NjKlMMeP2OjP6vXG1lHaNPqSs3JWOInFhOQyoFsEqjuZ0HIWMpO5XsbBB68z N/F9PNblMBoE3RwcsU/hOLqis4IiluQ2J6L5+cWUtQozo7Pq2EmKmTVRRohcW3ehT5wU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 212.227.126.131 Subject: [Qemu-devel] [PATCH 2/2] linux-user: fix "apt-get update" on linux-user hppa X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Riku Voipio , Laurent Vivier , John Paul Adrian Glaubitz Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" apt-get was hanging on linux-user hppa. strace has shown the netlink data stream was not correctly byte swapped. It appears the fd translator function is unregistered just after it has been registered, so the translator function is not called. This patch removes the fd_trans_unregister() after the do_socket() in the TARGET_NR_socket case. This fd_trans_unregister() was added by commit e36800c linux-user: add signalfd/signalfd4 syscalls when do_socket() was not registering any fd translator. And as now it is, we must remove this fd_trans_unregister() to keep them. Reported-by: John Paul Adrian Glaubitz Signed-off-by: Laurent Vivier Tested-by: John Paul Adrian Glaubitz --- linux-user/syscall.c | 1 - 1 file changed, 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 11a311f..9be8e95 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -9343,7 +9343,6 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, #ifdef TARGET_NR_socket case TARGET_NR_socket: ret = do_socket(arg1, arg2, arg3); - fd_trans_unregister(ret); break; #endif #ifdef TARGET_NR_socketpair