From patchwork Mon Sep 7 14:37:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jones X-Patchwork-Id: 515163 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 906FA1401CD for ; Tue, 8 Sep 2015 00:38:03 +1000 (AEST) Received: from localhost ([::1]:56966 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYxYX-0001DP-Om for incoming@patchwork.ozlabs.org; Mon, 07 Sep 2015 10:38:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYxYG-0000u4-0C for qemu-devel@nongnu.org; Mon, 07 Sep 2015 10:37:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZYxYB-0005ff-UB for qemu-devel@nongnu.org; Mon, 07 Sep 2015 10:37:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZYxYB-0005fV-PC for qemu-devel@nongnu.org; Mon, 07 Sep 2015 10:37:39 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 9FA918535C; Mon, 7 Sep 2015 14:37:38 +0000 (UTC) Received: from hawk.localdomain (dhcp-1-101.brq.redhat.com [10.34.1.101]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t87EbXan005379 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Mon, 7 Sep 2015 10:37:35 -0400 Date: Mon, 7 Sep 2015 16:37:33 +0200 From: Andrew Jones To: Alexander Spyridakis Message-ID: <20150907143733.GF3014@hawk.localdomain> References: <1441185926-61587-1-git-send-email-a.spyridakis@virtualopensystems.com> <1441185926-61587-3-git-send-email-a.spyridakis@virtualopensystems.com> <20150904104835.GC3096@hawk.localdomain> <20150904140528.GH3096@hawk.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1 (2014-03-12) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: mttcg@greensocs.com, KVM General , Mark Burton , Claudio Fontana , QEMU Developers , Alvise Rigo , Jani Kokkonen , Alex =?iso-8859-1?Q?Benn=E9e?= , KONRAD =?iso-8859-1?Q?Fr=E9d=E9ric?= Subject: Re: [Qemu-devel] [kvm-unit-tests PATCH 2/2] arm/arm64 config: Fix arch_clean rule X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Mon, Sep 07, 2015 at 03:35:19PM +0200, Alexander Spyridakis wrote: > On 4 September 2015 at 16:05, Andrew Jones wrote: > > This doesn't reproduce for me. I did the following, and it worked > > fine. > > > > make distclean > > ./configure --arch=arm --cross-prefix=arm-linux-gnu- > > make > > ./configure --arch=arm64 --cross-prefix=aarch64-linux-gnu- > > make clean && make > > Ok I think I found the issue: > > config-arm-common.mak: > >arm_clean: libfdt_clean asm_offsets_clean > > $(RM) $(TEST_DIR)/*.{o,flat,elf} $(libeabi) $(eabiobjs) \ > > $(TEST_DIR)/.*.d lib/arm/.*.d > > config-x86-common.mak: > >arch_clean: > > $(RM) $(TEST_DIR)/*.o $(TEST_DIR)/*.flat $(TEST_DIR)/*.elf \ > > $(TEST_DIR)/.*.d lib/x86/.*.d > > I think the arm case tries to be too clever and on many systems it > fails (tested on debian:jessie,sid and ubuntu:14.04,15.04). Basically > the expression for the arm case fails to resolve, while using the > simpler x86 way works as expected. > > So is the following change acceptable in config-arm-common.mak? > > arm_clean: libfdt_clean asm_offsets_clean > >- $(RM) $(TEST_DIR)/*.{o,flat,elf} $(libeabi) $(eabiobjs) \ > >- $(TEST_DIR)/.*.d lib/arm/.*.d > >+ $(RM) $(TEST_DIR)/*.o $(TEST_DIR)/*.flat $(TEST_DIR)/*.elf \ > >+ $(libeabi) $(eabiobjs) $(TEST_DIR)/.*.d lib/arm/.*.d Ah, it's a dash vs. bash thing. Either we need to change all bashisms in the makefiles, or, since kvm-unit-tests already depends on bash for its scripts, then we might as well just tell make to use it too. This patch will fix it I'll probably submit the patch in a second. Thanks for hunting down the problem! drew diff --git a/Makefile b/Makefile index 0d5933474cd8c..3e60b4f8e4a57 100644 --- a/Makefile +++ b/Makefile @@ -1,4 +1,6 @@ +SHELL := /bin/bash + ifeq ($(wildcard config.mak),) $(error run ./configure first. See ./configure -h) endif