From patchwork Sat Aug 8 00:14:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leif Lindholm X-Patchwork-Id: 505273 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 98078140281 for ; Sat, 8 Aug 2015 10:14:36 +1000 (AEST) Received: from localhost ([::1]:51546 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNrmS-0000yg-Po for incoming@patchwork.ozlabs.org; Fri, 07 Aug 2015 20:14:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNrmD-0000gA-CU for qemu-devel@nongnu.org; Fri, 07 Aug 2015 20:14:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNrmA-0000pS-3X for qemu-devel@nongnu.org; Fri, 07 Aug 2015 20:14:17 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:36860) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNrm9-0000pO-Qw for qemu-devel@nongnu.org; Fri, 07 Aug 2015 20:14:14 -0400 Received: by wicgj17 with SMTP id gj17so78770422wic.1 for ; Fri, 07 Aug 2015 17:14:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=4Hvnwr+VGq3Vzy34QeZQ1KSt5AqJYTqzY9jEQPyQQzU=; b=MwFdJ/rZAmfs5LAhuvesGVd6dR8M78K01oKXjW5ifhZk+NEyaelOSVmhJ8Qxq2ipnz lmFr5/1IHQa+MkSuwBpCzCve0Cmv+VwzQC0K9iLNwcD8Rhg6QFaykbG2qyY2Gbi3AAUP d8k4L5yzOOhaBIqSVnUnrLvp7jYQPM9tEfxE4mcl7B2TpO7VXk947uLrde1mrgDp12oa iGWh88sSa9r5TewcNjAsndOpVQJ9IyKIjmZayLgHsd4CP+xYXvqg5ySYy6VYCPnX1B5m lBmiVXFBrUa+GF3V96ripTOTm0lfoXyDhCb4Yqwftw5qSdJxXMWcUzXyKC+Jru2Ij+a/ Engw== X-Gm-Message-State: ALoCoQmHPm2nmFMGDmdD/5MtQ6NWQUIe/mNEud2CPiZ116EBBM8W2yDvFa5dtmcJ2qVJALnINjpZ X-Received: by 10.180.23.66 with SMTP id k2mr1489348wif.85.1438992852999; Fri, 07 Aug 2015 17:14:12 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id go5sm1261933wib.5.2015.08.07.17.14.11 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 07 Aug 2015 17:14:11 -0700 (PDT) Date: Sat, 8 Aug 2015 01:14:08 +0100 From: Leif Lindholm To: Wei Huang Message-ID: <20150808001408.GZ18160@bivouac.eciton.net> References: <1438881300-21738-1-git-send-email-wei@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1438881300-21738-1-git-send-email-wei@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.212.175 Cc: peter.maydell@linaro.org, drjones@redhat.com, ehabkost@redhat.com, ivan.khoronzhuk@linaro.org, ard.biesheuvel@linaro.org, somlo@cmu.edu, mst@redhat.com, qemu-devel@nongnu.org, roy.franz@linaro.org, imammedo@redhat.com, zhaoshenglong@huawei.com, pbonzini@redhat.com, lersek@redhat.com, jdelvare@suse.de, rth@twiddle.net Subject: Re: [Qemu-devel] [ARM SMBIOS V2 PATCH 0/6] SMBIOS Support for ARM X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Hi Wei, So, I can verify that this works all the way into Linux userland dmidecode on arm64. One question: This set still leaves the -smbios set of options x86 only. Would @findex -smbios be relevant to add here (6/6), and would that then be expected to work for filling in values via command line (because that does not currently appear to be the case). / Leif On Thu, Aug 06, 2015 at 01:14:54PM -0400, Wei Huang wrote: > SMBIOS tables present userful system hardware info to management > applications, such as DMI tools. Even though SMBIOS was originally > developed for Intel x86, it has been extended to both Itanium and > ARM (32bit & 64bit). More and more ARM server releases, such as > RHEL Server for ARM, start to integrate support for SMBIOS. > > This patchset is intendted to provid SMBIOS tables for ARM mach-virt > machine. The SMBIOS tables are created and stored in fw_cfg, relying on > OVMF (AAVMF) to parse/present SMBIOS entry. > > RFC version have been tested by Laszlo using his customized version of > AAVMF. We were able to detect SMBIOS 2.8 tables using dmidecode inside > an AArch64 guest VM. Moving forward, it is better to support SMBIOS 3.0 > for ARM guest VM. This new version (V2) integrates SMBIOS 3.0 support > for ARM mach-virt. I have tested this version using a customized AAVMF > created by Laszlo, who has submitted his patches to OVMF mailing list. > > V1->V2: > * Add NULL checking for fw_cfg (Shannon Zhao) > * Init 3.0 entry point table max size to smbios_tables_len (Laszlo) > * Minor re-arrangement of smbios.h layout with function headers to the bottom > * Validated SMBIOS 3.0 tables with a customized AAVMF created by Laszlo > > RFC->V1: > * Add SMBIOS 3.0 support for buidling SMBIOS > * Switch from SMBIOS 2.1 to 3.0 for ARM mach-virt > * RFC version Tested-by Laszlo Ersek and Acked-by Gabriel Somlo > > Thanks, > -Wei > > Wei Huang (6): > smbios: extract x86 smbios building code into a function > smbios: remove dependency on x86 e820 tables > smbios: pass ram size as a parameter to build smbios tables > smbios: move smbios code into a common folder > smbios: add smbios 3.0 support > smbios: implement smbios support for mach-virt > > arch_init.c | 2 +- > default-configs/arm-softmmu.mak | 1 + > default-configs/i386-softmmu.mak | 1 + > default-configs/x86_64-softmmu.mak | 1 + > hw/Makefile.objs | 1 + > hw/arm/virt.c | 27 ++++++++++ > hw/i386/Makefile.objs | 2 +- > hw/i386/pc.c | 56 ++++++++++++++------- > hw/i386/pc_piix.c | 5 +- > hw/i386/pc_q35.c | 5 +- > hw/smbios/Makefile.objs | 1 + > hw/{i386 => smbios}/smbios.c | 96 +++++++++++++++++++++++------------- > include/hw/arm/virt-acpi-build.h | 1 + > include/hw/{i386 => smbios}/smbios.h | 56 ++++++++++++++++----- > tests/bios-tables-test.c | 2 +- > vl.c | 2 +- > 16 files changed, 188 insertions(+), 71 deletions(-) > create mode 100644 hw/smbios/Makefile.objs > rename hw/{i386 => smbios}/smbios.c (93%) > rename include/hw/{i386 => smbios}/smbios.h (83%) > > -- > 1.8.3.1 > > --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1412,7 +1412,7 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios, "-smbios type=17[,loc_pfx=str][,bank=str][,manufacturer=str][,serial=str]\n" " [,asset=str][,part=str][,speed=%d]\n" " specify SMBIOS type 17 fields\n", - QEMU_ARCH_I386) + QEMU_ARCH_I386 | QEMU_ARCH_ARM) STEXI @item -smbios file=@var{binary}