From patchwork Mon Jan 5 05:48:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tiejun Chen X-Patchwork-Id: 425229 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 64FC714009B for ; Mon, 5 Jan 2015 16:56:00 +1100 (AEDT) Received: from localhost ([::1]:59090 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y80dx-0003Aw-NE for incoming@patchwork.ozlabs.org; Mon, 05 Jan 2015 00:55:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y80dh-0002uB-BM for qemu-devel@nongnu.org; Mon, 05 Jan 2015 00:55:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y80dc-0003Ij-CF for qemu-devel@nongnu.org; Mon, 05 Jan 2015 00:55:41 -0500 Received: from indium.canonical.com ([91.189.90.7]:35233) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y80dc-0003IE-0V for qemu-devel@nongnu.org; Mon, 05 Jan 2015 00:55:36 -0500 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.76 #1 (Debian)) id 1Y80da-00064t-GN for ; Mon, 05 Jan 2015 05:55:34 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 615932E80BB for ; Mon, 5 Jan 2015 05:55:34 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 05 Jan 2015 05:48:17 -0000 From: Tiejun Chen To: qemu-devel@nongnu.org X-Launchpad-Bug: product=qemu; status=New; importance=Undecided; assignee=None; X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: plucinski-mariusz tiejun-chen X-Launchpad-Bug-Reporter: =?utf-8?q?Mariusz_Pluci=C5=84ski_=28plucinski-mar?= =?utf-8?q?iusz=29?= X-Launchpad-Bug-Modifier: Tiejun Chen (tiejun-chen) References: <20150104163122.22342.19871.malonedeb@gac.canonical.com> Message-Id: <20150105054817.22315.27766.malone@gac.canonical.com> X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="17286"; Instance="launchpad-lazr.conf" X-Launchpad-Hash: a3a727e4f19a6fde730336997e4a4a212b8477ea X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 91.189.90.7 Subject: [Qemu-devel] [Bug 1407454] Re: assertion failed when using "-usb" option X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Reply-To: Bug 1407454 <1407454@bugs.launchpad.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Could you test this? Signed-off-by: Tiejun Chen --- util/qemu-option.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- diff --git a/util/qemu-option.c b/util/qemu-option.c index a708241..7cb3601 100644 --- a/util/qemu-option.c +++ b/util/qemu-option.c @@ -377,7 +377,7 @@ static bool qemu_opt_get_bool_helper(QemuOpts *opts, const char *name, } opt = qemu_opt_find(opts, name); - if (opt == NULL) { + if ((opt == NULL) || !opt->desc) { const QemuOptDesc *desc = find_desc_by_name(opts->list->desc, name); if (desc && desc->def_value_str) { parse_option_bool(name, desc->def_value_str, &ret, &error_abort);