From patchwork Wed Jan 29 04:27:49 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chubb X-Patchwork-Id: 314896 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 6D2882C00AF for ; Wed, 29 Jan 2014 15:35:55 +1100 (EST) Received: from localhost ([::1]:40425 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8MsS-0000L9-Sd for incoming@patchwork.ozlabs.org; Tue, 28 Jan 2014 23:35:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8Ms8-0000L1-Py for qemu-devel@nongnu.org; Tue, 28 Jan 2014 23:35:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W8Ms3-0007eo-5m for qemu-devel@nongnu.org; Tue, 28 Jan 2014 23:35:32 -0500 Received: from indium.canonical.com ([91.189.90.7]:34801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W8Ms2-0007do-Vo for qemu-devel@nongnu.org; Tue, 28 Jan 2014 23:35:27 -0500 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1W8Ms2-00039H-9E for ; Wed, 29 Jan 2014 04:35:26 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id 36D5F2E80AF for ; Wed, 29 Jan 2014 04:35:26 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 29 Jan 2014 04:27:49 -0000 From: Peter Chubb To: qemu-devel@nongnu.org X-Launchpad-Bug: product=qemu; status=New; importance=Undecided; assignee=None; X-Launchpad-Bug-Information-Type: Public X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: peter-chubb-1 X-Launchpad-Bug-Reporter: Peter Chubb (peter-chubb-1) X-Launchpad-Bug-Modifier: Peter Chubb (peter-chubb-1) References: <20140129041802.30520.43680.malonedeb@chaenomeles.canonical.com> Message-Id: <20140129042749.12626.79571.malone@soybean.canonical.com> X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="16916"; Instance="launchpad-lazr.conf" X-Launchpad-Hash: 2788031cfd7f798591ef66f120bf20678ab5946b X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 91.189.90.7 Subject: [Qemu-devel] [Bug 1273944] Re: multiboot header has 0 in mem_upper field X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Reply-To: Bug 1273944 <1273944@bugs.launchpad.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This change fixes it. peterc@Diprotodon:/usr/src/qemu/tests/m diff --git a/exec.c b/exec.c index 2435d9e..b387d28 100644 --- a/exec.c +++ b/exec.c @@ -1070,7 +1070,7 @@ static void *file_ram_alloc(RAMBlock *block, } /* MAP_POPULATE silently ignores failures */ - for (i = 0; i < (memory/hpagesize); i++) { + for (i = 0; i < (memory/hpagesize)-1; i++) { memset(area + (hpagesize*i), 0, 1); }