From patchwork Fri Jan 17 19:25:20 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Williamson X-Patchwork-Id: 312184 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 83E702C0096 for ; Sat, 18 Jan 2014 06:28:03 +1100 (EST) Received: from localhost ([::1]:39755 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4F5E-00056B-PB for incoming@patchwork.ozlabs.org; Fri, 17 Jan 2014 14:28:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4F2n-0001uW-EH for qemu-devel@nongnu.org; Fri, 17 Jan 2014 14:25:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W4F2g-0004LN-RQ for qemu-devel@nongnu.org; Fri, 17 Jan 2014 14:25:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W4F2g-0004LB-KJ for qemu-devel@nongnu.org; Fri, 17 Jan 2014 14:25:22 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0HJPLdd002463 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 17 Jan 2014 14:25:21 -0500 Received: from bling.home ([10.3.113.17]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0HJPKnk015354; Fri, 17 Jan 2014 14:25:20 -0500 From: Alex Williamson To: aliguori@amazon.com Date: Fri, 17 Jan 2014 12:25:20 -0700 Message-ID: <20140117192520.10456.74054.stgit@bling.home> In-Reply-To: <20140117192252.10456.96113.stgit@bling.home> References: <20140117192252.10456.96113.stgit@bling.home> User-Agent: StGit/0.17-dirty MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Bandan Das , qemu-devel@nongnu.org, kvm@vger.kernel.org Subject: [Qemu-devel] [PULL 2/7] vfio: warn if host device rom can't be read X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Bandan Das If the device rom can't be read, report an error to the user. This alerts the user that the device has a bad state that is causing rom read failure or option rom loading has been disabled from the device boot menu (among other reasons). Signed-off-by: Bandan Das Signed-off-by: Alex Williamson --- hw/misc/vfio.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index ec9f41b..ef615fc 100644 --- a/hw/misc/vfio.c +++ b/hw/misc/vfio.c @@ -1125,6 +1125,13 @@ static void vfio_pci_load_rom(VFIODevice *vdev) vdev->rom_offset = reg_info.offset; if (!vdev->rom_size) { + error_report("vfio-pci: Cannot read device rom at " + "%04x:%02x:%02x.%x\n", + vdev->host.domain, vdev->host.bus, vdev->host.slot, + vdev->host.function); + error_printf("Device option ROM contents are probably invalid " + "(check dmesg).\nSkip option ROM probe with rombar=0, " + "or load from file with romfile=\n"); return; }