From patchwork Thu Oct 10 18:44:59 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Williamson X-Patchwork-Id: 282431 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 754DD2C00A0 for ; Fri, 11 Oct 2013 06:08:20 +1100 (EST) Received: from localhost ([::1]:50425 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VULas-000113-Cq for incoming@patchwork.ozlabs.org; Thu, 10 Oct 2013 15:08:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VULEb-0003C2-9O for qemu-devel@nongnu.org; Thu, 10 Oct 2013 14:45:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VULER-0007nE-Ef for qemu-devel@nongnu.org; Thu, 10 Oct 2013 14:45:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VULEQ-0007lX-Mm for qemu-devel@nongnu.org; Thu, 10 Oct 2013 14:45:07 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9AIixbG025794 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 10 Oct 2013 14:45:00 -0400 Received: from bling.home (ovpn-113-48.phx2.redhat.com [10.3.113.48]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9AIixQf016265; Thu, 10 Oct 2013 14:44:59 -0400 To: anthony@codemonkey.ws From: Alex Williamson Date: Thu, 10 Oct 2013 12:44:59 -0600 Message-ID: <20131010184445.31667.61094.stgit@bling.home> In-Reply-To: <20131010184122.31667.28382.stgit@bling.home> References: <20131010184122.31667.28382.stgit@bling.home> User-Agent: StGit/0.16 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: Paolo Bonzini , qemu-devel@nongnu.org, kvm@vger.kernel.org Subject: [Qemu-devel] [PULL v2 7/8] vfio-pci: Add dummy PCI ROM write accessor X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Just to be sure we don't jump off any NULL pointer cliffs. Signed-off-by: Alex Williamson Reported-by: Paolo Bonzini --- hw/misc/vfio.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c index 68e25bd..1fbc40b 100644 --- a/hw/misc/vfio.c +++ b/hw/misc/vfio.c @@ -1128,8 +1128,14 @@ static uint64_t vfio_rom_read(void *opaque, hwaddr addr, unsigned size) return val; } +static void vfio_rom_write(void *opaque, hwaddr addr, + uint64_t data, unsigned size) +{ +} + static const MemoryRegionOps vfio_rom_ops = { .read = vfio_rom_read, + .write = vfio_rom_write, .endianness = DEVICE_LITTLE_ENDIAN, };