From patchwork Tue Jul 9 00:41:37 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin O'Connor X-Patchwork-Id: 257624 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0C52F2C02A6 for ; Tue, 9 Jul 2013 10:42:03 +1000 (EST) Received: from localhost ([::1]:37349 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwM0F-0003Eq-LI for incoming@patchwork.ozlabs.org; Mon, 08 Jul 2013 20:41:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwLzy-0003CD-4a for qemu-devel@nongnu.org; Mon, 08 Jul 2013 20:41:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UwLzw-0001e3-3P for qemu-devel@nongnu.org; Mon, 08 Jul 2013 20:41:42 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:45311) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UwLzv-0001dy-VS for qemu-devel@nongnu.org; Mon, 08 Jul 2013 20:41:40 -0400 Received: by mail-vc0-f174.google.com with SMTP id kw10so3920363vcb.33 for ; Mon, 08 Jul 2013 17:41:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent :x-gm-message-state; bh=Dw0zCbr1HVikhHY2RRDH5nVqrVVjJj9kVZCDQgzjCFE=; b=BmefPf/8bCgKSsb0BBb647Eu30luc/WpixDYFf8fnf6VONQdoxQDQvvIAaLoscaCX+ Heop+9zThXSGqm3R0/oMFqasDbGxZpnLO9z1MPz4y97nosj6xBHhzzQQ8xZ/AcGItNqB 1OxVbWjTNG3A0iyxnWsOf1RR20MAPYria1NmeNLBQVi0dr8wBFjBBve9QkgHtDM9go9D NNU7oS20XIchcvpk3zU/dahuELGaC0KmpePcRg0lb1EsoTSMh8IsJ8Zv+i9LmMKN7FjU HF3Y4y608CmNbg5eB4zUwSyLdFzXb0thQUyBu0mvRJq27aSOXUVJHuxDWn1T9RYiaRb/ R4tQ== X-Received: by 10.221.63.2 with SMTP id xc2mr12434421vcb.74.1373330499422; Mon, 08 Jul 2013 17:41:39 -0700 (PDT) Received: from localhost (207-172-165-101.c3-0.avec-ubr1.nyr-avec.ny.cable.rcn.com. [207.172.165.101]) by mx.google.com with ESMTPSA id lm13sm18002075vec.8.2013.07.08.17.41.38 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 08 Jul 2013 17:41:38 -0700 (PDT) Date: Mon, 8 Jul 2013 20:41:37 -0400 From: Kevin O'Connor To: Cole Robinson Message-ID: <20130709004137.GA2935@morn.localdomain> References: <20130708034128.GA20623@morn.localdomain> <51DB2DDC.3080001@redhat.com> <20130708231832.GA30361@morn.localdomain> <51DB56E2.6070908@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <51DB56E2.6070908@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQl3tY9/+37V4EGi+XCurNQO+7q6XCm0f1P2/XKgGoF+eYqAhirOpyDce5sHsyBvtVnkAcgZ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.220.174 Cc: seabios@seabios.org, qemu-devel@nongnu.org Subject: Re: [Qemu-devel] seabios 1.7.3 breaks booting windows 7? X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Mon, Jul 08, 2013 at 08:18:42PM -0400, Cole Robinson wrote: > On 07/08/2013 07:18 PM, Kevin O'Connor wrote: > > On Mon, Jul 08, 2013 at 05:23:40PM -0400, Cole Robinson wrote: > >> On 07/07/2013 11:41 PM, Kevin O'Connor wrote: > >>> The 1.7.3 version of SeaBIOS has now been released. For more > >>> information on the release, please see: > >> > >> Just gave it a spin, breaks booting a Windows 7 VM for me. Using qemu-1.4.2 > >> from Fedora 19 as well as qemu.git. > >> > >> Here's the BSOD (F19 qemu and seabios 1.7.3): > >> http://crobinso.fedorapeople.org/misc/seabios_1.7.3_windows_err.png > > > > Thanks for testing. I have a "Windows 7 Ultimate" beta (build 7100) > > that I tested with and I don't see this problem. (Nor do I see the > > problem on WinXP.) > > > > Can you try without smp and with a smaller memory size (eg, 512M) to > > see if the behavior changes. > > > > Hmm, my winxp 32 guest is reproducing as well. And I can reproduce with just > the windows 7 media (mine is ultimate N, came off MSDN years ago): > > ~/src/qemu/x86_64-softmmu/qemu-system-x86_64 -m 512 -sdl -cdrom > /mnt/data/devel/media/win7_64.iso -boot d -bios ~/src/seabios/out/bios.bin > > vista and windows 8 preview media are reproducing for me too. > > Maybe it's a toolchain thing, anyone else on Fedora 19 that can independently > confirm? Ugh - make sure you aren't using an old acpi-dsdt.aml file. I suggest following the steps outlined in the SeaBIOS README file for creating a mybiosdir/ directory and use the QEMU -L option to point to that directory. Otherwise... I compile under FC17. I have pre-packaged binaries available at: http://code.coreboot.org/p/seabios/downloads/ Also, could you post the log output. Add the following to qemu to produce it: qemu ... -chardev stdio,id=seabios \ -device isa-debugcon,iobase=0x402,chardev=seabios ... > > Otherwise, we'll need to iterate through each change in the 76e58028 > > commit and find out which part of the DSDT that your copy of Windows > > doesn't like. > > > > I'll probably need some hand holding through that, I can't tell from looking > at the patch what parts are independent. You'll want to do something like: and then move the "Return" and "#if 0" down until you find the offending code. -Kevin --- a/src/acpi-dsdt-pci-crs.dsl +++ b/src/acpi-dsdt-pci-crs.dsl @@ -56,6 +56,8 @@ Scope(\_SB.PCI0) { }) Method(_CRS, 0) { + Return (CRES) +#if 0 /* Fields provided by dynamically created ssdt */ External(P0S, IntObj) External(P0E, IntObj) @@ -86,5 +88,6 @@ Scope(\_SB.PCI0) { /* add window and return result */ ConcatenateResTemplate(CRES, CR64, Local0) Return (Local0) +#endif } }