From patchwork Wed Jul 4 01:29:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Baron X-Patchwork-Id: 168864 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 419222C0086 for ; Wed, 4 Jul 2012 11:47:34 +1000 (EST) Received: from localhost ([::1]:34126 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmENf-0000lv-JZ for incoming@patchwork.ozlabs.org; Tue, 03 Jul 2012 21:27:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33017) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmENX-0000lc-7G for qemu-devel@nongnu.org; Tue, 03 Jul 2012 21:27:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmENV-0003Or-7b for qemu-devel@nongnu.org; Tue, 03 Jul 2012 21:27:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmENU-0003On-Vq for qemu-devel@nongnu.org; Tue, 03 Jul 2012 21:27:37 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q641RWj6026557 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 3 Jul 2012 21:27:33 -0400 Received: from redhat.com (vpn-11-37.rdu.redhat.com [10.11.11.37]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q641RVKu011560; Tue, 3 Jul 2012 21:27:31 -0400 Date: Tue, 3 Jul 2012 21:29:18 -0400 From: Jason Baron To: Alexander Graf Message-ID: <20120704012917.GA3074@redhat.com> References: <20120703161628.GB32441@redhat.com> <8E6DCE94-DB2B-43B6-8EFE-765E428939E7@suse.de> <20120703183840.GE32441@redhat.com> <77F44C8A-408F-435A-BDDC-C7715C1759A0@suse.de> <20120703184617.GF32441@redhat.com> <20120703203715.GG32441@redhat.com> <18AFE795-B1D9-4378-B55E-1CB1147A786F@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <18AFE795-B1D9-4378-B55E-1CB1147A786F@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: mst@redhat.com, jan.kiszka@siemens.com, alex.williamson@redhat.com, qemu-devel@nongnu.org, yamahata@valinux.co.jp, juzhang@redhat.com, anthony@codemonkey.ws Subject: Re: [Qemu-devel] q35 and ahci X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Tue, Jul 03, 2012 at 10:54:37PM +0200, Alexander Graf wrote: > On 03.07.2012, at 22:37, Jason Baron wrote: > > > On Tue, Jul 03, 2012 at 08:52:50PM +0200, Alexander Graf wrote: > >> On 03.07.2012, at 20:46, Jason Baron wrote: > >> > >>> On Tue, Jul 03, 2012 at 08:41:29PM +0200, Alexander Graf wrote: > >>>> On 03.07.2012, at 20:38, Jason Baron wrote: > >>>> > >>>>> On Tue, Jul 03, 2012 at 08:25:52PM +0200, Alexander Graf wrote: > >>>>>> On 03.07.2012, at 18:16, Jason Baron wrote: > >>>>>> > >>>>>>> Hi, > >>>>>>> > >>>>>>> Update on q35 testing with various os's. > >>>>>>> > >>>>>>> Linux > >>>>>>> ----- > >>>>>>> -RHEL6.3 installs + runs > >>>>>>> -Fedora 16 install + runs > >>>>>>> -Fedora 17 - squashfs errors > >>>>>>> running on already installed f17 seems ok. > >>>>>>> > >>>>>>> Windows > >>>>>>> ------- > >>>>>>> -W7 - install error: > >>>>>>> > >>>>>>> "A required cd/dvd device driver is missing. If you have a > >>>>>>> driver floppy disk, CD, DVD, or USB flash drive, please insert it now. > >>>>>>> " > >>>>>>> > >>>>>>> Related to the new ahci controller, since if I go back to an > >>>>>>> ide conroller it keeps going (albeit the install is *very* slow). > >>>>>>> > >>>>>>> So I'm wondering if we need an ide compatibility mode? Or perhaps, there > >>>>>>> are other ideas. > >>>>>> > >>>>>> Does it work with AHCI and -M pc? It should. Last time I tried it did at least :). > >>>>>> > >>>>>> > >>>>>> Alex > >>>>>> > >>>>>> > >>>>> > >>>>> Yes, adding the ahci controller to -M pc, I see a disk drive and the > >>>>> controller show up in the device manager. I read in some of the ahci > >>>>> commit messages that the cdrom device didn't show up. Did cdrom ever > >>>>> work with ahci? > >>>> > >>>> It did on Linux at least, yes. Does it work on Linux for you? > >>>> > >>> > >>> I meant did a cdrom on the ahci controller configure on windows? > >>> > >>> Yes, Linux seems to be happy with the drive and cdrom on the ahci. See > >>> my above test results. (ich9-ahci is the default controller for q35). > >> > >> Ah, good. I don't remember tbh. But I suppose since it doesn't work for you, it's broken :). Do you have time to look into it? > >> > > > > I have time to look at it (I'm trying to get q35 working on as many os's > > as possible), but I'm far from an expert on ahci. So if you had some > > time to look at it, that would be great. My q35 trees are at: > > Not sure how quickly I can get around to it. I still have quite a bunch of other stuff on my plate atm. > > > git://github.com/jibaron/q35-qemu.git > > git://github.com/jibaron/q35-seabios.git > > > > With a cmd line such as: > > > > /usr/local/bin/qemu-system-x86_64 -name "f16" -M pc_q35 -m 1G -smp 4 > > -hda ./f16.img --enable-kvm -bios /q35-seabios/out/bios.bin > > -acpitable file=/q35-seabios/out/q35-acpi-dsdt.aml -monitor stdio > > I suppose you mean something that actually does -cdrom? oops. yes. here's an example: /usr/local/bin/qemu-system-x86_64 -boot c -name "w7" -m 6G -smp 4 -M pc_q35 -cdrom /images/isos/en_windows_7_ultimate_with_sp1_x64_dvd_u_677332.iso -hda /images/w7-q35.img -vnc :5 --enable-kvm -bios /root/seabios/seabios/out/bios.bin -acpitable file=/root/seabios/seabios/out/q35-acpi-dsdt.aml -monitor stdio > > > The error I run into is: > > > > "A required cd/dvd device driver is missing. If you have a > > driver floppy disk, CD, DVD, or USB flash drive, please insert it now. > > " > > Well, that only tells us that it couldn't find its own CD drive. The question is why. Some ATA logs would be nice here :). > I've posted a log at: http://people.redhat.com/~jbaron/qemu/log Created with the debug patch below. Thanks, -Jason diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index 1e6cb82..ec75e45 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -34,7 +34,7 @@ #include #include -/* #define DEBUG_AHCI */ +#define DEBUG_AHCI #ifdef DEBUG_AHCI #define DPRINTF(port, fmt, ...) \ diff --git a/hw/ide/internal.h b/hw/ide/internal.h index f8a027d..ac1503b 100644 --- a/hw/ide/internal.h +++ b/hw/ide/internal.h @@ -14,9 +14,9 @@ #include "hw/scsi-defs.h" /* debug IDE devices */ -//#define DEBUG_IDE -//#define DEBUG_IDE_ATAPI -//#define DEBUG_AIO +#define DEBUG_IDE +#define DEBUG_IDE_ATAPI +#define DEBUG_AIO #define USE_DMA_CDROM typedef struct IDEBus IDEBus;