From patchwork Thu Jun 14 18:16:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Williamson X-Patchwork-Id: 164995 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 70B25B7057 for ; Fri, 15 Jun 2012 04:30:31 +1000 (EST) Received: from localhost ([::1]:46744 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfEbU-00076S-VR for incoming@patchwork.ozlabs.org; Thu, 14 Jun 2012 14:17:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54727) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfEax-0005lE-EB for qemu-devel@nongnu.org; Thu, 14 Jun 2012 14:16:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfEav-0007mL-9V for qemu-devel@nongnu.org; Thu, 14 Jun 2012 14:16:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfEav-0007lx-1G for qemu-devel@nongnu.org; Thu, 14 Jun 2012 14:16:33 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5EIGVUL023807 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 14 Jun 2012 14:16:31 -0400 Received: from bling.home (ovpn-116-19.ams2.redhat.com [10.36.116.19]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5EIGTsb010747; Thu, 14 Jun 2012 14:16:29 -0400 From: Alex Williamson To: mst@redhat.com Date: Thu, 14 Jun 2012 12:16:28 -0600 Message-ID: <20120614181627.23440.46436.stgit@bling.home> In-Reply-To: <20120614181104.23440.62204.stgit@bling.home> References: <20120614181104.23440.62204.stgit@bling.home> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH v3 5/8] msix: Note endian TODO item X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org MSIX, like PCI, is little endian. Specifying native is wrong here, but we need to check the rest of the file to determine if it's as simple as flipping this macro. Signed-off-by: Alex Williamson --- hw/msix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/msix.c b/hw/msix.c index 50885ac..87d316a 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -224,6 +224,7 @@ static void msix_mmio_write(void *opaque, target_phys_addr_t addr, static const MemoryRegionOps msix_mmio_ops = { .read = msix_mmio_read, .write = msix_mmio_write, + /* TODO: MSIX should be LITTLE_ENDIAN. */ .endianness = DEVICE_NATIVE_ENDIAN, .valid = { .min_access_size = 4,