From patchwork Mon Apr 16 23:48:06 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin O'Connor X-Patchwork-Id: 153014 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 5ABABB7008 for ; Tue, 17 Apr 2012 09:48:23 +1000 (EST) Received: from localhost ([::1]:42612 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SJvef-0000Ad-3Y for incoming@patchwork.ozlabs.org; Mon, 16 Apr 2012 19:48:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51793) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SJveY-0000AE-J4 for qemu-devel@nongnu.org; Mon, 16 Apr 2012 19:48:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SJveW-00066U-IZ for qemu-devel@nongnu.org; Mon, 16 Apr 2012 19:48:14 -0400 Received: from mail-qa0-f46.google.com ([209.85.216.46]:38689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SJveW-000653-F6 for qemu-devel@nongnu.org; Mon, 16 Apr 2012 19:48:12 -0400 Received: by qatm19 with SMTP id m19so40964qat.12 for ; Mon, 16 Apr 2012 16:48:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent :x-gm-message-state; bh=myT5dCUhNyJ4DvvZ9rv8fD7XiP50V5h237Y9THIaF9g=; b=BOoId/dNbu+vgNklnnhwY6pLuc6BN5CZx/p+n138m+ib/0HkGHwFLbJu0FHQgUZF6x BtUy8LSFPJBzIxNHJop0Ln1pj2kdQkJOOt5TCNcc52L5K7tPn1C7eO5kc3KiihrQtflF nFszxh82JvMPTwElQ4Qm2k8HGlVK8w4j82X+IKt5rATlo/jXyXoMUxsWdOEGTZeQ+i1k 2Ctsy5rwTkcOfZcgvQxY0RoUS9Y2be8W0VQyBvFtzwb7DAkuyH31dWtD7mGQc9d5TJ79 ECaFV2LRUatCoBdYocgtTapGrsgVY0ecc2boSEAHLxRaKq7QGBr/KIUlubiWBIqRWDjC 7F/g== Received: by 10.224.175.83 with SMTP id w19mr9012849qaz.76.1334620088606; Mon, 16 Apr 2012 16:48:08 -0700 (PDT) Received: from localhost (207-172-165-101.c3-0.avec-ubr1.nyr-avec.ny.cable.rcn.com. [207.172.165.101]) by mx.google.com with ESMTPS id gy2sm37015637qab.10.2012.04.16.16.48.07 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 16 Apr 2012 16:48:07 -0700 (PDT) Date: Mon, 16 Apr 2012 19:48:06 -0400 From: Kevin O'Connor To: Eric Blake Message-ID: <20120416234806.GA13724@morn.localdomain> References: <20120415024855.GA12078@morn.localdomain> <4F8B28AF.1070205@msgid.tls.msk.ru> <4F8C80E4.7030104@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4F8C80E4.7030104@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQmFM/p3lXUs2rWnNevZLz2tfiO5iVgz88Kj6jlOP8Hjxt6uur8d2hVhLC6rMKy/Va3BB3Xa X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.216.46 Cc: seabios@seabios.org, Michael Tokarev , qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [ANNOUNCE] SeaBIOS 1.7.0 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Mon, Apr 16, 2012 at 02:28:20PM -0600, Eric Blake wrote: > On 04/15/2012 01:59 PM, Michael Tokarev wrote: > > On 15.04.2012 06:48, Kevin O'Connor wrote: > >> The 1.7.0 version of SeaBIOS has now been released. For more > >> information on the release, please see: > >> > >> http://seabios.org/Releases > > > > Um. I can't compile it here, due to an error in ./tools/buildversion.sh. [...] > > AFIAK, "==" operator is a bash(?) extension, standard > > POSIX shell only mentions "=" operator. > > Not just a bash extension, as ksh and zsh have it too, but you are right > that dash doesn't implement it because POSIX 2008 (Issue 7) doesn't > require '==', just '='. [There is a good chance that the next POSIX > revision (Issue 8) will require '==' as a synonym for '=', but as that > version of POSIX is still several years away, you're still better off > sticking to '=' for now.] It's easy enough to fix in SeaBIOS (for the next release). -Kevin From 385a7d0dec28841a05531cba96c62138c3959fef Mon Sep 17 00:00:00 2001 From: Kevin O'Connor Date: Sun, 15 Apr 2012 22:02:15 -0400 Subject: [PATCH] buildversion: Don't rely on bash syntax. To: seabios@seabios.org Use '=' instead of '=='. Signed-off-by: Kevin O'Connor --- tools/buildversion.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/buildversion.sh b/tools/buildversion.sh index 9b301e6..c8c1725 100755 --- a/tools/buildversion.sh +++ b/tools/buildversion.sh @@ -15,7 +15,7 @@ VERSION="${VERSION}-`date +"%Y%m%d_%H%M%S"`-`hostname`" echo "Version: ${VERSION}" # Build header file -if [ "$VAR16MODE" == "VAR16" ]; then +if [ "$VAR16MODE" = "VAR16" ]; then cat > ${OUTFILE} <