From patchwork Fri Mar 16 08:55:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Wang X-Patchwork-Id: 147165 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id BCFD8B6EEA for ; Fri, 16 Mar 2012 20:05:14 +1100 (EST) Received: from localhost ([::1]:36898 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8T1X-0001l9-4o for incoming@patchwork.ozlabs.org; Fri, 16 Mar 2012 05:00:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44004) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8T0w-0008MI-6m for qemu-devel@nongnu.org; Fri, 16 Mar 2012 05:00:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S8T0o-0002zx-UX for qemu-devel@nongnu.org; Fri, 16 Mar 2012 04:59:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58871) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8T0o-0002zX-Lo for qemu-devel@nongnu.org; Fri, 16 Mar 2012 04:59:50 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2G8xlit006342 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 16 Mar 2012 04:59:47 -0400 Received: from amd-6168-8-1.englab.nay.redhat.com (amd-6168-8-1.englab.nay.redhat.com [10.66.104.52]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q2G8xivq028883; Fri, 16 Mar 2012 04:59:45 -0400 To: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, mst@redhat.com, rusty@rustcorp.com.au, qemu-devel@nongnu.org, quintela@redhat.com, pbonzini@redhat.com From: Jason Wang Date: Fri, 16 Mar 2012 16:55:11 +0800 Message-ID: <20120316085511.4947.14490.stgit@amd-6168-8-1.englab.nay.redhat.com> In-Reply-To: <20120316085237.4947.53556.stgit@amd-6168-8-1.englab.nay.redhat.com> References: <20120316085237.4947.53556.stgit@amd-6168-8-1.englab.nay.redhat.com> User-Agent: StGit/0.16-1-g60c4 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [V5 PATCH 3/4] virtio-net: notify guest to annouce itself X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org It's hard to track all mac addresses and their usage (vlan, bondings, ipv6) in qemu to send proper gratuitous packet. The better choice is to let guest to send them. So, this patch introduces a new rw config status bit of virtio-net, VIRTIO_NET_S_ANNOUNCE which is used to notify guest to announce presence of its link through config update interrupt. When gust have done the announcement, it should clear that bit. The feature is negotiated by a new feature bit VIRTIO_NET_F_ANNOUNCE. Signed-off-by: Jason Wang --- hw/virtio-net.c | 19 +++++++++++++++++++ hw/virtio-net.h | 3 +++ 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index bc5e3a8..c1dbd49 100644 --- a/hw/virtio-net.c +++ b/hw/virtio-net.c @@ -95,6 +95,10 @@ static void virtio_net_set_config(VirtIODevice *vdev, const uint8_t *config) memcpy(n->mac, netcfg.mac, ETH_ALEN); qemu_format_nic_info_str(&n->nic->nc, n->mac); } + + /* ignore write to RO byte */ + memcpy((uint8_t *)&n->status + 1, (uint8_t *)&netcfg.status + 1, + sizeof(uint8_t)); } static bool virtio_net_started(VirtIONet *n, uint8_t status) @@ -983,6 +987,20 @@ static void virtio_net_cleanup(VLANClientState *nc) n->nic = NULL; } +static int virtio_net_announce(VLANClientState *nc) +{ + VirtIONet *n = DO_UPCAST(NICState, nc, nc)->opaque; + + if (n->vdev.guest_features & (0x1 << VIRTIO_NET_F_GUEST_ANNOUNCE) + && virtio_net_started(n, n->vdev.status)) { + n->status |= VIRTIO_NET_S_ANNOUNCE; + virtio_notify_config(&n->vdev); + return 0; + } + + return -1; +} + static NetClientInfo net_virtio_info = { .type = NET_CLIENT_TYPE_NIC, .size = sizeof(NICState), @@ -990,6 +1008,7 @@ static NetClientInfo net_virtio_info = { .receive = virtio_net_receive, .cleanup = virtio_net_cleanup, .link_status_changed = virtio_net_set_link_status, + .announce = virtio_net_announce, }; VirtIODevice *virtio_net_init(DeviceState *dev, NICConf *conf, diff --git a/hw/virtio-net.h b/hw/virtio-net.h index 4468741..f3acbd1 100644 --- a/hw/virtio-net.h +++ b/hw/virtio-net.h @@ -44,8 +44,10 @@ #define VIRTIO_NET_F_CTRL_RX 18 /* Control channel RX mode support */ #define VIRTIO_NET_F_CTRL_VLAN 19 /* Control channel VLAN filtering */ #define VIRTIO_NET_F_CTRL_RX_EXTRA 20 /* Extra RX mode control support */ +#define VIRTIO_NET_F_GUEST_ANNOUNCE 21 /* Guest can announce itself */ #define VIRTIO_NET_S_LINK_UP 1 /* Link is up */ +#define VIRTIO_NET_S_ANNOUNCE 0x100 /* Announcement is needed */ #define TX_TIMER_INTERVAL 150000 /* 150 us */ @@ -176,6 +178,7 @@ struct virtio_net_ctrl_mac { DEFINE_PROP_BIT("guest_tso6", _state, _field, VIRTIO_NET_F_GUEST_TSO6, true), \ DEFINE_PROP_BIT("guest_ecn", _state, _field, VIRTIO_NET_F_GUEST_ECN, true), \ DEFINE_PROP_BIT("guest_ufo", _state, _field, VIRTIO_NET_F_GUEST_UFO, true), \ + DEFINE_PROP_BIT("guest_announce", _state, _field, VIRTIO_NET_F_GUEST_ANNOUNCE, true), \ DEFINE_PROP_BIT("host_tso4", _state, _field, VIRTIO_NET_F_HOST_TSO4, true), \ DEFINE_PROP_BIT("host_tso6", _state, _field, VIRTIO_NET_F_HOST_TSO6, true), \ DEFINE_PROP_BIT("host_ecn", _state, _field, VIRTIO_NET_F_HOST_ECN, true), \