From patchwork Wed Feb 22 02:07:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?6Zmz6Z+L5Lu7?= X-Patchwork-Id: 142403 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E553CB6FC5 for ; Wed, 22 Feb 2012 18:19:02 +1100 (EST) Received: from localhost ([::1]:59633 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S06TS-0004TA-7Y for incoming@patchwork.ozlabs.org; Wed, 22 Feb 2012 02:18:50 -0500 Received: from eggs.gnu.org ([140.186.70.92]:34341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S01bs-0001NN-96 for qemu-devel@nongnu.org; Tue, 21 Feb 2012 21:07:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S01bq-0004xP-Dl for qemu-devel@nongnu.org; Tue, 21 Feb 2012 21:07:12 -0500 Received: from csmailer.cs.nctu.edu.tw ([140.113.235.130]:44197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S01bp-0004xF-9l; Tue, 21 Feb 2012 21:07:10 -0500 Received: from csmailer.cs.nctu.edu.tw (localhost [127.0.0.1]) by csmailer.cs.nctu.edu.tw (Postfix) with ESMTP id 37BE6C6A; Wed, 22 Feb 2012 10:12:30 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=cs.nctu.edu.tw; h=date :from:to:cc:subject:message-id:mime-version:content-type; s= rsa1024; bh=h+NziQkBWwfGv+R3btpfqM0rfVU=; b=oSvHtNPy64thJkw562nt JPmlw9H6pgSc+v7rx9J+yxMxhCxt7hwlNhkO4lgzPaQ6upIwFhNQDDPMxjvC8AnK z8hMa2ZLvk3uNKgyhKQb9jMDtZPI/ujgnkksiaqNMNfoi//Z8uPjLgp7NCKE/7Wy Q4Y94E1uEcXBbZ27hIY9hQM= Received: from alumni.cs.nctu.edu.tw (alumni.cs.nctu.edu.tw [140.113.235.116]) by csmailer.cs.nctu.edu.tw (Postfix) with ESMTP id 317A1C69; Wed, 22 Feb 2012 10:12:30 +0800 (CST) Received: (from chenwj@localhost) by alumni.cs.nctu.edu.tw (8.14.4/8.14.4/Submit) id q1M275VO011028; Wed, 22 Feb 2012 10:07:05 +0800 (CST) (envelope-from chenwj) Date: Wed, 22 Feb 2012 10:07:05 +0800 From: =?utf-8?B?6Zmz6Z+L5Lu7?= To: qemu-devel@nongnu.org Message-ID: <20120222020705.GA10972@cs.nctu.edu.tw> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 140.113.235.130 X-Mailman-Approved-At: Wed, 22 Feb 2012 02:18:39 -0500 Cc: qemu-trivial@nongnu.org Subject: [Qemu-devel] [PATCH v2] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of bridge helper, but introduces dependency issue at the same time. While building target xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not generated at the moment. Explicitly declaring the dependency for the helper in the Makefile. Signed-off-by: Chen Wei-Ren --- v2: Explicitly declaring the dependency for the helper instead of relying on ordering side-effects. Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index e66e885..1b2488c 100644 --- a/Makefile +++ b/Makefile @@ -36,7 +36,7 @@ $(call set-vpath, $(SRC_PATH):$(SRC_PATH)/hw) LIBS+=-lz $(LIBS_TOOLS) -HELPERS-$(CONFIG_LINUX) = qemu-bridge-helper$(EXESUF) +HELPERS-$(CONFIG_LINUX) : config-host.h qemu-bridge-helper$(EXESUF) ifdef BUILD_DOCS DOCS=qemu-doc.html qemu-tech.html qemu.1 qemu-img.1 qemu-nbd.8 QMP/qmp-commands.txt