From patchwork Tue Feb 7 08:44:39 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gleb Natapov X-Patchwork-Id: 139886 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E2FB21007D6 for ; Tue, 7 Feb 2012 19:45:18 +1100 (EST) Received: from localhost ([::1]:58467 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rugff-0002Fw-W5 for incoming@patchwork.ozlabs.org; Tue, 07 Feb 2012 03:45:03 -0500 Received: from eggs.gnu.org ([140.186.70.92]:47080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RugfU-0002FR-UT for qemu-devel@nongnu.org; Tue, 07 Feb 2012 03:44:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RugfP-00051f-0F for qemu-devel@nongnu.org; Tue, 07 Feb 2012 03:44:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RugfO-00051Q-OX for qemu-devel@nongnu.org; Tue, 07 Feb 2012 03:44:46 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q178ifLS009491 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 7 Feb 2012 03:44:41 -0500 Received: from dhcp-1-237.tlv.redhat.com (dhcp-4-26.tlv.redhat.com [10.35.4.26]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q178ieNI025730; Tue, 7 Feb 2012 03:44:41 -0500 Received: by dhcp-1-237.tlv.redhat.com (Postfix, from userid 13519) id E3626133EEF; Tue, 7 Feb 2012 10:44:39 +0200 (IST) Date: Tue, 7 Feb 2012 10:44:39 +0200 From: Gleb Natapov To: "Kevin O'Connor" Message-ID: <20120207084439.GA23536@redhat.com> References: <1328212740-15799-1-git-send-email-mdroth@linux.vnet.ibm.com> <20120203121803.6963d24f@doriath.home> <4F2C0D45.1020701@linux.vnet.ibm.com> <20120203144535.1be8a569@doriath.home> <4F2C17F9.9030103@linux.vnet.ibm.com> <20120203171627.531a42d4@doriath.home> <20120204153432.GA31653@morn.localdomain> <20120206134342.605af344@doriath.home> <20120207000942.GA23819@morn.localdomain> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120207000942.GA23819@morn.localdomain> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: ghammer@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, Michael Roth , Luiz Capitulino Subject: Re: [Qemu-devel] [PATCH v2 0/8] qemu-ga: add support for Windows X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Mon, Feb 06, 2012 at 07:09:42PM -0500, Kevin O'Connor wrote: > On Mon, Feb 06, 2012 at 01:43:42PM -0200, Luiz Capitulino wrote: > > "Kevin O'Connor" wrote: > > > On Fri, Feb 03, 2012 at 05:16:27PM -0200, Luiz Capitulino wrote: > > > > On Fri, 03 Feb 2012 11:23:05 -0600 > > > > Michael Roth wrote: > > > > > I'd been tracking Gerd's QMP wakeup series as the s3 resolution we need > > > > > for guest-suspend, is that still the case? > > > > > > > > Yes. But now I remembered about a seabios bug with S3... Need to check if > > > > it were already addressed. > > > > > > I'm not aware of any recent S3 defects in SeaBIOS. If there is a > > > defect, please let me know. > > > > > > (I am aware of recent discussions on SeaBIOS and it running the > > > vgabios on s3-resume, but I would not classify that issue as a > > > defect.) > > > > The problem is that, the screen goes black after resuming from S3. Gleb > > debugged it a bit and he said that it was caused by a change in seabios. > > > > Please, take a look at the last three comments in this bz: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=772614 > > Perhaps a semantic distinction, but I don't consider that to be a > seabios defect. > Non optimal default. The default didn't change BTW, but it was config parameter before and we changed it for RHEL. Now config parameter is gone. > In any case, I don't think this was addressed. Gerd published a patch > that can address this in qemu: > http://www.seabios.org/pipermail/seabios/2012-January/002944.html > Strictly speaking the patch is incorrect since it introduces the file for all architectures, but I do not think qemu is the right place to tune SeaBIOS defaults. I propose this patch instead: --- Run vgabios during S3 resume by default on QEMU. QEMU still able to modify SeaBIOS behavior if it wishes so by providing etc/s3-resume-vga-init file. Gleb Natapov -- Gleb. diff --git a/src/optionroms.c b/src/optionroms.c index 27cfffd..06db1c1 100644 --- a/src/optionroms.c +++ b/src/optionroms.c @@ -423,7 +423,7 @@ vga_setup(void) // Load some config settings that impact VGA. EnforceChecksum = romfile_loadint("etc/optionroms-checksum", 1); - S3ResumeVgaInit = romfile_loadint("etc/s3-resume-vga-init", 0); + S3ResumeVgaInit = romfile_loadint("etc/s3-resume-vga-init", !CONFIG_COREBOOT); ScreenAndDebug = romfile_loadint("etc/screen-and-debug", 1); if (CONFIG_OPTIONROMS_DEPLOYED) {