From patchwork Mon Oct 4 21:53:11 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Williamson X-Patchwork-Id: 66746 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 950F2B70AB for ; Tue, 5 Oct 2010 09:21:36 +1100 (EST) Received: from localhost ([127.0.0.1]:57310 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P2tPZ-0001Tv-CK for incoming@patchwork.ozlabs.org; Mon, 04 Oct 2010 18:21:33 -0400 Received: from [140.186.70.92] (port=49315 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P2tAM-0004vW-VB for qemu-devel@nongnu.org; Mon, 04 Oct 2010 18:05:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P2syC-0000KK-NI for qemu-devel@nongnu.org; Mon, 04 Oct 2010 17:53:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38399) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P2syC-0000K2-Fy for qemu-devel@nongnu.org; Mon, 04 Oct 2010 17:53:16 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o94LrCHi030991 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 4 Oct 2010 17:53:12 -0400 Received: from s20.home (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o94LrBJH000805; Mon, 4 Oct 2010 17:53:12 -0400 From: Alex Williamson To: qemu-devel@nongnu.org Date: Mon, 04 Oct 2010 15:53:11 -0600 Message-ID: <20101004215311.17070.54862.stgit@s20.home> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.21 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: alex.williamson@redhat.com Subject: [Qemu-devel] [PATCH] PCI: Bus number from the bridge, not the device X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org pcibus_dev_print() was erroneously retrieving the device bus number from the secondary bus number offset of the device instead of the bridge above the device. This ends of landing in the 2nd byte of the 3rd BAR for devices, which thankfully is usually zero. pcibus_get_dev_path() copied this code, inheriting the same bug. pcibus_get_dev_path() is used for ramblock naming, so changing it can effect migration. However, I've only seen this byte be non-zero for an assigned device, which can't migrate anyway, so hopefully we won't run into any issues. Signed-off-by: Alex Williamson --- hw/pci.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 6d0934d..15416dd 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -1940,8 +1940,7 @@ static void pcibus_dev_print(Monitor *mon, DeviceState *dev, int indent) monitor_printf(mon, "%*sclass %s, addr %02x:%02x.%x, " "pci id %04x:%04x (sub %04x:%04x)\n", - indent, "", ctxt, - d->config[PCI_SECONDARY_BUS], + indent, "", ctxt, pci_bus_num(d->bus), PCI_SLOT(d->devfn), PCI_FUNC(d->devfn), pci_get_word(d->config + PCI_VENDOR_ID), pci_get_word(d->config + PCI_DEVICE_ID), @@ -1965,7 +1964,7 @@ static char *pcibus_get_dev_path(DeviceState *dev) char path[16]; snprintf(path, sizeof(path), "%04x:%02x:%02x.%x", - pci_find_domain(d->bus), d->config[PCI_SECONDARY_BUS], + pci_find_domain(d->bus), pci_bus_num(d->bus), PCI_SLOT(d->devfn), PCI_FUNC(d->devfn)); return strdup(path);