From patchwork Wed Jun 2 21:18:03 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anthony Liguori X-Patchwork-Id: 54434 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9C33FB7D29 for ; Thu, 3 Jun 2010 07:26:42 +1000 (EST) Received: from localhost ([127.0.0.1]:59725 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJvSQ-0005Gx-JZ for incoming@patchwork.ozlabs.org; Wed, 02 Jun 2010 17:26:38 -0400 Received: from [140.186.70.92] (port=39622 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OJvRL-0005E1-63 for qemu-devel@nongnu.org; Wed, 02 Jun 2010 17:25:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OJvRJ-0004xe-VG for qemu-devel@nongnu.org; Wed, 02 Jun 2010 17:25:31 -0400 Received: from adelie.canonical.com ([91.189.90.139]:39190) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OJvRJ-0004xY-PI for qemu-devel@nongnu.org; Wed, 02 Jun 2010 17:25:29 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1OJvRI-00073g-27 for ; Wed, 02 Jun 2010 22:25:28 +0100 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id C32802E8062 for ; Wed, 2 Jun 2010 22:25:27 +0100 (BST) MIME-Version: 1.0 Date: Wed, 02 Jun 2010 21:18:03 -0000 From: Anthony Liguori To: qemu-devel@nongnu.org X-Launchpad-Bug: product=qemu; status=In Progress; importance=Undecided; assignee=None; X-Launchpad-Bug-Private: no X-Launchpad-Bug-Security-Vulnerability: no X-Launchpad-Bug-Commenters: anthony-codemonkey roytam References: <20100602143725.32332.4482.malonedeb@potassium.ubuntu.com> Message-Id: <20100602211803.10953.52568.malone@potassium.ubuntu.com> X-Launchpad-Message-Rationale: Subscriber (QEMU) @qemu-devel-ml Precedence: bulk X-Generated-By: Launchpad (canonical.com); Revision="None"; Instance="initZopeless config overlay" X-Launchpad-Hash: 5cae1637fb6afe1c29b7d7ab9223a99642f0e550 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: [Qemu-devel] [Bug 588748] Re: QEMU fails to boot DR DOS Plus since 0.6.1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Reply-To: Bug 588748 <588748@bugs.launchpad.net> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patch doesn't seem correct as the spec is pretty clear that THRE interrupt enable is set to high, then an interrupt is rased if LSR.THRE=1. Does the following also make DOSPlus boot again: ** Changed in: qemu Status: New => In Progress diff --git a/hw/serial.c b/hw/serial.c index 9102edb..b0ac52f 100644 --- a/hw/serial.c +++ b/hw/serial.c @@ -401,7 +401,8 @@ static void serial_ioport_write(void *opaque, uint32_t addr, s->poll_msl = 0; } } - if (s->lsr & UART_LSR_THRE) { + if (s->ier & UART_IER_THRI && + s->lsr & UART_LSR_THRE) { s->thr_ipending = 1; serial_update_irq(s); }