From patchwork Thu Jan 14 15:46:24 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kusanagi Kouichi X-Patchwork-Id: 42899 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 58046B7CB9 for ; Fri, 15 Jan 2010 03:03:25 +1100 (EST) Received: from localhost ([127.0.0.1]:48724 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NVS86-0003oi-Kn for incoming@patchwork.ozlabs.org; Thu, 14 Jan 2010 11:01:02 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NVRuD-0006sl-Ta for qemu-devel@nongnu.org; Thu, 14 Jan 2010 10:46:41 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NVRu9-0006mZ-FF for qemu-devel@nongnu.org; Thu, 14 Jan 2010 10:46:41 -0500 Received: from [199.232.76.173] (port=48487 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NVRu9-0006mN-9u for qemu-devel@nongnu.org; Thu, 14 Jan 2010 10:46:37 -0500 Received: from msa106.auone-net.jp ([61.117.18.166]:43232) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NVRu8-0005bg-Ql for qemu-devel@nongnu.org; Thu, 14 Jan 2010 10:46:37 -0500 Received: from ppp.dion.ne.jp (ZJ080201.ppp.dion.ne.jp [222.4.80.201]) by msa106.auone-net.jp (au one net msa) with ESMTP id 732C062C03A for ; Fri, 15 Jan 2010 00:46:25 +0900 (JST) Date: Fri, 15 Jan 2010 00:46:24 +0900 From: Kusanagi Kouichi To: qemu-devel@nongnu.org MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) Message-Id: <20100114154625.732C062C03A@msa106.auone-net.jp> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Subject: [Qemu-devel] [PATCH] char: Remove redundant qemu_chr_generic_open() call. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org qemu_chr_open_fd() calls qemu_chr_generic_open(), so qemu_chr_open_tty() doesn't need to call it. Signed-off-by: Kusanagi Kouichi --- qemu-char.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index b13f8d4..800ee6c 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1187,7 +1187,6 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts) return NULL; } chr->chr_ioctl = tty_serial_ioctl; - qemu_chr_generic_open(chr); return chr; } #else /* ! __linux__ && ! __sun__ */