From patchwork Fri Aug 28 15:53:38 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Reimar_D=C3=B6ffinger?= X-Patchwork-Id: 32382 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by bilbo.ozlabs.org (Postfix) with ESMTPS id C3B81B7B73 for ; Sat, 29 Aug 2009 01:55:40 +1000 (EST) Received: from localhost ([127.0.0.1]:59342 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mh3nb-0004Ze-2M for incoming@patchwork.ozlabs.org; Fri, 28 Aug 2009 11:55:35 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mh3lx-0003lY-Tm for qemu-devel@nongnu.org; Fri, 28 Aug 2009 11:53:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mh3ls-0003gR-1y for qemu-devel@nongnu.org; Fri, 28 Aug 2009 11:53:52 -0400 Received: from [199.232.76.173] (port=44695 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mh3lr-0003g0-KY for qemu-devel@nongnu.org; Fri, 28 Aug 2009 11:53:47 -0400 Received: from mail.gmx.net ([213.165.64.20]:45741) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1Mh3lq-0002Qb-QJ for qemu-devel@nongnu.org; Fri, 28 Aug 2009 11:53:47 -0400 Received: (qmail invoked by alias); 28 Aug 2009 15:53:44 -0000 Received: from p5B133697.dip.t-dialin.net (EHLO localhost) [91.19.54.151] by mail.gmx.net (mp015) with SMTP; 28 Aug 2009 17:53:44 +0200 X-Authenticated: #11956158 X-Provags-ID: V01U2FsdGVkX18SGmsSB0kSzi4Z6Fete7DRHH2FjYnXRcWVitfdJj uDB1dQWUGhOYdY Date: Fri, 28 Aug 2009 17:53:38 +0200 From: Reimar =?iso-8859-1?Q?D=F6ffinger?= To: qemu-devel@nongnu.org Subject: Re: [Qemu-devel] Re: [HACK] make vmmouse work with KVM Message-ID: <20090828155338.GA25860@1und1.de> Mail-Followup-To: qemu-devel@nongnu.org References: <20090817144754.GA31553@1und1.de> <4A89730F.7090206@codemonkey.ws> <20090817154557.GB365@1und1.de> <4A8988DB.3040108@gnu.org> <20090817170017.GB1835@1und1.de> <4A899081.9010508@gnu.org> <20090817173232.GA1961@1und1.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20090817173232.GA1961@1und1.de> User-Agent: Mutt/1.5.20 (2009-06-14) X-Y-GMX-Trusted: 0 X-FuHaFi: 0.52 X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Mon, Aug 17, 2009 at 07:32:32PM +0200, Reimar Döffinger wrote: > On Mon, Aug 17, 2009 at 07:16:49PM +0200, Paolo Bonzini wrote: > > On 08/17/2009 07:00 PM, Reimar Döffinger wrote: > > > On Mon, Aug 17, 2009 at 06:44:11PM +0200, Paolo Bonzini wrote: > > >> On 08/17/2009 05:45 PM, Reimar Döffinger wrote: > > >>> + cpu_synchronize_state(env, 0); > > >>> env->regs[R_EAX] = vmport_ioport_read(opaque, addr); > > >>> + cpu_synchronize_state(env, 1); > > >> > > >> This is not needed because the sync is done in vmport_ioport_read, isn't it? > > > > > > Well... The cpu_synchronize_state could be dropped you are right, but > > > here we write R_EAX so the cpu_synchronize_state(env, 1) is necessary. > > > It might be slightly cleaner to rename the vmport_ioport_read (any name > > > suggestions?) and add a wrapper for register_ioport_read that does the > > > cpu_synchronize_state (so it looks similar to vmport_ioport_write). > > > > Yes, that would look best and wouldn't have fooled me. Could > > vmport_ioport_trigger be a decent name? > > Since what that function actually does is execute a specific command it > gets from ecx I went with vmport_ioport_command, but I'll happily leave > the naming to whoever applies it :-) Simpler version due to new cpu_synchronize_state behaviour. Signed-off-by: Reimar Döffinger diff --git a/hw/vmport.c b/hw/vmport.c index 884af3f..9a942ee 100644 --- a/hw/vmport.c +++ b/hw/vmport.c @@ -25,6 +25,7 @@ #include "isa.h" #include "pc.h" #include "sysemu.h" +#include "kvm.h" //#define VMPORT_DEBUG @@ -58,6 +59,7 @@ static uint32_t vmport_ioport_read(void *opaque, uint32_t addr) unsigned char command; uint32_t eax; + cpu_synchronize_state(env); eax = env->regs[R_EAX]; if (eax != VMPORT_MAGIC) return eax;