From patchwork Wed Sep 10 11:47:15 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hahn X-Patchwork-Id: 387695 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id A6E9B14010C for ; Wed, 10 Sep 2014 21:47:51 +1000 (EST) Received: from localhost ([::1]:55487 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRgNJ-0006p9-TF for incoming@patchwork.ozlabs.org; Wed, 10 Sep 2014 07:47:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRgMx-0006Sk-Kw for qemu-devel@nongnu.org; Wed, 10 Sep 2014 07:47:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XRgMs-0002Bh-Hz for qemu-devel@nongnu.org; Wed, 10 Sep 2014 07:47:27 -0400 Received: from mail.univention.de ([82.198.197.8]:1085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XRgMs-0002BT-CN for qemu-devel@nongnu.org; Wed, 10 Sep 2014 07:47:22 -0400 Received: from localhost (localhost [127.0.0.1]) by solig.knut.univention.de (Postfix) with ESMTP id 78E6110B8598; Wed, 10 Sep 2014 13:47:20 +0200 (CEST) X-Virus-Scanned: by amavisd-new-2.6.4 (20090625) (Debian) at knut.univention.de Received: from mail.univention.de ([127.0.0.1]) by localhost (solig.knut.univention.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9sHiNuG0RFFO; Wed, 10 Sep 2014 13:47:18 +0200 (CEST) Received: from stave.knut.univention.de (stave.knut.univention.de [192.168.0.191]) by solig.knut.univention.de (Postfix) with ESMTPSA id 4418A10B8595; Wed, 10 Sep 2014 13:47:18 +0200 (CEST) Received: by stave.knut.univention.de (Postfix, from userid 2260) id 027713FB16; Wed, 10 Sep 2014 13:47:17 +0200 (CEST) From: Philipp Hahn To: qemu-devel@nongnu.org Date: Wed, 10 Sep 2014 13:47:15 +0200 Message-Id: <1d591a3214013dbe24f593a3404f85f1bef1a50f.1410349594.git.hahn@univention.de> X-Mailer: git-send-email 1.9.1 In-Reply-To: <540EB169.2000707@redhat.com> References: <540EB169.2000707@redhat.com> Organization: Univention GmbH, Bremen, Germany X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 82.198.197.8 Cc: Paolo Bonzini , Philipp Hahn Subject: [Qemu-devel] [PATCH v2] hw/dma/i8257: Silence phony error message X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Convert into trace event. Otherwise the message dma: unregistered DMA channel used nchan=0 dma_pos=0 dma_len=1 gets printed every time and fills up the log-file with 50 MiB / minute. Signed-off-by: Philipp Hahn --- v2: Convert into trace event instead of tracking once per static bitmap. --- hw/dma/i8257.c | 4 ++-- trace-events | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/dma/i8257.c b/hw/dma/i8257.c index dd370ed..a414029 100644 --- a/hw/dma/i8257.c +++ b/hw/dma/i8257.c @@ -24,6 +24,7 @@ #include "hw/hw.h" #include "hw/isa/isa.h" #include "qemu/main-loop.h" +#include "trace.h" /* #define DEBUG_DMA */ @@ -473,8 +474,7 @@ static void dma_reset(void *opaque) static int dma_phony_handler (void *opaque, int nchan, int dma_pos, int dma_len) { - dolog ("unregistered DMA channel used nchan=%d dma_pos=%d dma_len=%d\n", - nchan, dma_pos, dma_len); + trace_i8257_unregistered_dma(nchan, dma_pos, dma_len); return dma_pos; } diff --git a/trace-events b/trace-events index 03ac5d2..c12afc0 100644 --- a/trace-events +++ b/trace-events @@ -1318,3 +1318,6 @@ mhp_pc_dimm_assigned_address(uint64_t addr) "0x%"PRIx64 # target-s390x/kvm.c kvm_enable_cmma(int rc) "CMMA: enabling with result code %d" kvm_clear_cmma(int rc) "CMMA: clearing with result code %d" + +# hw/dma/i8257.c +i8257_unregistered_dma(int nchan, int dma_pos, int dma_len) "unregistered DMA channel used nchan=%d dma_pos=%d dma_len=%d"