From patchwork Fri Jul 3 14:45:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?B?Wm9sdMOhbiBLxZF2w6Fnw7M=?= X-Patchwork-Id: 491108 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 7987D140777 for ; Sat, 4 Jul 2015 00:46:03 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=cld1CbDr; dkim-atps=neutral Received: from localhost ([::1]:41520 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZB2E3-0002Ee-OK for incoming@patchwork.ozlabs.org; Fri, 03 Jul 2015 10:45:59 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZB2DX-0001rz-91 for qemu-devel@nongnu.org; Fri, 03 Jul 2015 10:45:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZB2DU-0004vi-0n for qemu-devel@nongnu.org; Fri, 03 Jul 2015 10:45:27 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:35066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZB2DT-0004uY-QA; Fri, 03 Jul 2015 10:45:23 -0400 Received: by wiga1 with SMTP id a1so179857054wig.0; Fri, 03 Jul 2015 07:45:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=mmxi08gq7PrPH9rkDK/WoYLj6yEXePHlQ7onsens8hM=; b=cld1CbDrpBuNphGndRQH55VG+lOqJWrJuKaifq6BNvy7dAEah46K/iF35x2o7e2eAQ ZzvARqeQTogP7LsRimhShPNojih96U+MOMjCX94GV5OF7B29Dz0aQKLvdfF473yhqjdo t6+2vDMOX0WS/iNVIh8oQ2Uq1hN5MdNEB3K/OEgcHSRQD3j+PeWnqhVcAmMbjHYB8QMZ gmyvdlHShbt3A/RbmHSIJ0SQHQNR1UcmJ6zQGvJyBM7IkuwKXsALiO+uHcDdW8PbB9MT 9dXImbhMBsMc5jKpmE/9B6CrXGy/qA3RiW/Za5+WrYEiz52cmD1sSDC5EBam5nVM31j7 6Sqg== X-Received: by 10.194.11.73 with SMTP id o9mr70121901wjb.116.1435934723159; Fri, 03 Jul 2015 07:45:23 -0700 (PDT) Received: from nullptr.home.dirty-ice.org (94-21-30-178.pool.digikabel.hu. [94.21.30.178]) by mx.google.com with ESMTPSA id o9sm1406854wiy.19.2015.07.03.07.45.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 Jul 2015 07:45:22 -0700 (PDT) From: "=?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?=" X-Google-Original-From: =?UTF-8?q?K=C5=91v=C3=A1g=C3=B3=2C=20Zolt=C3=A1n?= To: qemu-devel@nongnu.org Date: Fri, 3 Jul 2015 16:45:36 +0200 Message-Id: <19df383991831bad31163fa0053f996284eeedec.1435934626.git.DirtY.iCE.hu@gmail.com> X-Mailer: git-send-email 2.4.5 MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::230 Cc: qemu-trivial@nongnu.org, Kevin Wolf , Markus Armbruster , "open list:Block layer core" Subject: [Qemu-devel] [PATCH v2] opts: produce valid command line in qemu_opts_print X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This will let us print options in a format that the user would actually write it on the command line (foo=bar,baz=asd,etc=def), without prepending a spurious comma at the beginning of the list, or quoting values unnecessarily. This patch provides the following changes: * write and id=, if the option has an id * do not print separator before the first element * do not quote string arguments * properly escape commas (,) for QEMU Signed-off-by: Kővágó, Zoltán Reviewed-by: Markus Armbruster --- Change from v1: * updated escaped_print as suggested by Markus block.c | 2 +- util/qemu-option.c | 29 ++++++++++++++++++++++++++--- 2 files changed, 27 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index 7e130cc..78a5304 100644 --- a/block.c +++ b/block.c @@ -3813,7 +3813,7 @@ void bdrv_img_create(const char *filename, const char *fmt, } if (!quiet) { - printf("Formatting '%s', fmt=%s", filename, fmt); + printf("Formatting '%s', fmt=%s ", filename, fmt); qemu_opts_print(opts, " "); puts(""); } diff --git a/util/qemu-option.c b/util/qemu-option.c index efe9d27..e54ac0d 100644 --- a/util/qemu-option.c +++ b/util/qemu-option.c @@ -730,14 +730,35 @@ void qemu_opts_del(QemuOpts *opts) g_free(opts); } -void qemu_opts_print(QemuOpts *opts, const char *sep) +/* print value, escaping any commas in value */ +static void escaped_print(const char *value) +{ + const char *ptr; + + for (ptr = value; *ptr; ++ptr) { + if (*ptr == ',') { + putchar(','); + } + putchar(*ptr); + } +} + +void qemu_opts_print(QemuOpts *opts, const char *separator) { QemuOpt *opt; QemuOptDesc *desc = opts->list->desc; + const char *sep = ""; + + if (opts->id) { + printf("id=%s", opts->id); /* passed id_wellformed -> no commas */ + sep = separator; + } if (desc[0].name == NULL) { QTAILQ_FOREACH(opt, &opts->head, next) { - printf("%s%s=\"%s\"", sep, opt->name, opt->str); + printf("%s%s=", sep, opt->name); + escaped_print(opt->str); + sep = separator; } return; } @@ -750,13 +771,15 @@ void qemu_opts_print(QemuOpts *opts, const char *sep) continue; } if (desc->type == QEMU_OPT_STRING) { - printf("%s%s='%s'", sep, desc->name, value); + printf("%s%s=", sep, desc->name); + escaped_print(value); } else if ((desc->type == QEMU_OPT_SIZE || desc->type == QEMU_OPT_NUMBER) && opt) { printf("%s%s=%" PRId64, sep, desc->name, opt->value.uint); } else { printf("%s%s=%s", sep, desc->name, value); } + sep = separator; } }