diff mbox

[2/2] syscall: pselect arg_sigsize variable was write only

Message ID 1703b79860e2625c250014288c4fb236467a0fb9.1310400716.git.quintela@redhat.com
State New
Headers show

Commit Message

Juan Quintela July 11, 2011, 4:15 p.m. UTC 
Remove it.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 linux-user/syscall.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

Comments

Peter Maydell July 11, 2011, 4:50 p.m. UTC | #1 
On 11 July 2011 17:15, Juan Quintela <quintela@redhat.com> wrote:
> Remove it.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>

http://patchwork.ozlabs.org/patch/104232/ in the current linux-user
pullreq is a fix for this.

-- PMM
Juan Quintela July 11, 2011, 7:35 p.m. UTC | #2 
Juan Quintela <quintela@redhat.com> wrote:
> Remove it.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>

/me nacks himself

Peter one is better, it even makes sense, go figure O:-)
diff mbox

Patch

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index fed7a8f..35bbe36 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -5634,7 +5634,7 @@  abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
                 size_t size;
             } sig, *sig_ptr;

-            abi_ulong arg_sigset, arg_sigsize, *arg7;
+            abi_ulong arg_sigset, *arg7;
             target_sigset_t *target_sigset;

             n = arg1;
@@ -5679,7 +5679,6 @@  abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
                     goto efault;
                 }
                 arg_sigset = tswapl(arg7[0]);
-                arg_sigsize = tswapl(arg7[1]);
                 unlock_user(arg7, arg6, 0);

                 if (arg_sigset) {