From patchwork Mon Jun 24 05:33:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yan Zhao X-Patchwork-Id: 1121068 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=intel.com Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45XHyl4V6bz9s5c for ; Mon, 24 Jun 2019 15:33:51 +1000 (AEST) Received: from localhost ([::1]:48048 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfHbx-0005VV-1n for incoming@patchwork.ozlabs.org; Mon, 24 Jun 2019 01:33:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58867) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfHbX-0005VP-Cp for qemu-devel@nongnu.org; Mon, 24 Jun 2019 01:33:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfHbW-0003CX-BM for qemu-devel@nongnu.org; Mon, 24 Jun 2019 01:33:23 -0400 Received: from mga05.intel.com ([192.55.52.43]:62445) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfHbW-00039I-24 for qemu-devel@nongnu.org; Mon, 24 Jun 2019 01:33:22 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Jun 2019 22:33:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,411,1557212400"; d="scan'208";a="151844409" Received: from joy-desktop.sh.intel.com ([10.239.13.126]) by orsmga007.jf.intel.com with ESMTP; 23 Jun 2019 22:33:17 -0700 From: Yan Zhao To: pbonzini@redhat.com Date: Mon, 24 Jun 2019 13:33:03 +0800 Message-Id: <1561354383-21322-1-git-send-email-yan.y.zhao@intel.com> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 192.55.52.43 Subject: [Qemu-devel] [PATCH] memory: warning on out of scope notification X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Auger Eric , Yan Zhao , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" if an entry has parts out of scope of notifier's range, print warning message. Out of scope mapping/unmapping would cause problem, as in below case: 1. initially there are two notifiers with ranges 0-0xfedfffff, 0xfef00000-0xffffffffffffffff, IOVAs from 0x3c000000 - 0x3c1fffff is in shadow page table. 2. in vfio, memory_region_register_iommu_notifier() is followed by memory_region_iommu_replay(), which will first call address space unmap, and walk and add back all entries in vtd shadow page table. e.g. (1) for notifier 0-0xfedfffff, IOVAs from 0 - 0xffffffff get unmapped, and IOVAs from 0x3c000000 - 0x3c1fffff get mapped (2) for notifier 0xfef00000-0xffffffffffffffff IOVAs from 0 - 0x7fffffffff get unmapped, but IOVAs from 0x3c000000 - 0x3c1fffff cannot get mapped back. Cc: Auger Eric Signed-off-by: Yan Zhao --- memory.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/memory.c b/memory.c index 0a089a7..18927f2 100644 --- a/memory.c +++ b/memory.c @@ -1953,6 +1953,16 @@ void memory_region_notify_one(IOMMUNotifier *notifier, request_flags = IOMMU_NOTIFIER_UNMAP; } + if (entry->iova < notifier->start || + entry->iova + entry->addr_mask > notifier->end) { + warn_report("%s IOMMUTLBEntry %lx-%lx outside of " + "notifier scope %lx-%lx", + (request_flags == IOMMU_NOTIFIER_MAP) ? + "Mapping" : "Unmapping", + entry->iova, entry->iova + entry->addr_mask, + notifier->start, notifier->end); + } + if (notifier->notifier_flags & request_flags) { notifier->notify(notifier, entry); }