From patchwork Thu Dec 13 02:09:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Li Qiang X-Patchwork-Id: 1012456 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FA2lc467"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43FcZt4yDxz9s7h for ; Thu, 13 Dec 2018 13:10:13 +1100 (AEDT) Received: from localhost ([::1]:49911 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXGS1-0001oh-UZ for incoming@patchwork.ozlabs.org; Wed, 12 Dec 2018 21:10:09 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXGRg-0001ms-Hs for qemu-devel@nongnu.org; Wed, 12 Dec 2018 21:09:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXGRd-0007qN-9d for qemu-devel@nongnu.org; Wed, 12 Dec 2018 21:09:48 -0500 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:38073) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXGRc-0007p1-UA for qemu-devel@nongnu.org; Wed, 12 Dec 2018 21:09:45 -0500 Received: by mail-pf1-x444.google.com with SMTP id q1so268969pfi.5 for ; Wed, 12 Dec 2018 18:09:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=kuwFIzvENBydeg1EpaW3bWLcJd16XTwtySU69eqjqss=; b=FA2lc467PXP71fSIHYeADumfJeQo7utO/nui8Z3qekAKUuIvn3uORbwI1dXwVzOU8B et06s8NiTeAeMhVBO4wAGyM+9b5UlqvT76PnaNH2KSIyQRGMLm8Wbz7QNqH4Mmljlgn+ zLr1AgIwwlpLAst/TaDpDreBwjOc5ujzUkQDn3wYoauhH3rxVaHq5pbVBwnDMj1/VA9q zF6izVyPYQRAwouaqfQ8NwEZFg6Zbfo5ds8fVk9AMQTw8NOVh3LoqMu0gNoNTTxrzNUM WMwl5ljPjUyTQGhGEEl6lGauGCcvzr4OIDQ76DoSlvrcpsDO3AR1U2zUUA6yAkbtfIQ9 hpfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=kuwFIzvENBydeg1EpaW3bWLcJd16XTwtySU69eqjqss=; b=Yt/+Q06Ee0+BMt4ZbRZRY/aYd/j0uraZkD5FnF/AUuPryytTDnGMKDZPpfl6mmc3HR 4HIwfzhUmqoauxrQvU+ifeuHkNhxU+3rfe5HsqnIK0WZKdYETlJPBnbs7oSkRnTqe1N5 aAyrGEHrYY+iHUkLvRriHtDjejltUVagidxRY5SDLVc5Pg4wLnzxzSVlXXvFc4zcMu+D BKX5wl9tJsiIEFsFKEGjRl4cNKzmPqcG+CHKRHbtudDvGRGfC0TEWeKcV4IZ9Vo/8i3x 4Fj3GjibmqcMu7Cg2laiUVvJAFUoDhWAG6EEDw2WmLIXUdvgluv7UkeYHYUI39fQZUZ8 KjHg== X-Gm-Message-State: AA+aEWY+/JHPhCV+4ro17lYc3t+JxZv6bBvh3r/76jmp41jbZcZc+Pgh rreeM9BS13+Tm8KsNmQySnM= X-Google-Smtp-Source: AFSGD/V8cjqckx2m2GKBVam2/yaR5MoFE0NKvxwkwpe/zvwCBkUHQzU6Hfze6nfyAnERfj7GttUV+w== X-Received: by 2002:a62:c21c:: with SMTP id l28mr22216265pfg.74.1544666983726; Wed, 12 Dec 2018 18:09:43 -0800 (PST) Received: from localhost.localdomain.localdomain ([103.129.255.252]) by smtp.gmail.com with ESMTPSA id v191sm353541pgb.77.2018.12.12.18.09.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Dec 2018 18:09:43 -0800 (PST) From: Li Qiang To: peter.maydell@linaro.org, marcandre.lureau@redhat.com, pbonzini@redhat.com Date: Wed, 12 Dec 2018 18:09:37 -0800 Message-Id: <1544666977-4816-1-git-send-email-liq3ea@gmail.com> X-Mailer: git-send-email 1.8.3.1 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::444 Subject: [Qemu-devel] [PATCH] util: check the return value of fcntl in qemu_set_{block, noblock} X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Li Qiang , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Assert that the return value is not an error. This is like commit 7e6478e7d4f for qemu_set_cloexec. Signed-off-by: Li Qiang --- util/oslib-posix.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index c1bee2a581..4ce1ba9ca4 100644 --- a/util/oslib-posix.c +++ b/util/oslib-posix.c @@ -233,14 +233,18 @@ void qemu_set_block(int fd) { int f; f = fcntl(fd, F_GETFL); - fcntl(fd, F_SETFL, f & ~O_NONBLOCK); + assert(f != -1); + f = fcntl(fd, F_SETFL, f & ~O_NONBLOCK); + assert(f != -1); } void qemu_set_nonblock(int fd) { int f; f = fcntl(fd, F_GETFL); - fcntl(fd, F_SETFL, f | O_NONBLOCK); + assert(f != -1); + f = fcntl(fd, F_SETFL, f | O_NONBLOCK); + assert(f != -1); } int socket_set_fast_reuse(int fd)