From patchwork Wed Jun 6 14:36:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Babu Moger X-Patchwork-Id: 925889 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="WSjlfSj/"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 411B9829jZz9s1R for ; Thu, 7 Jun 2018 00:37:48 +1000 (AEST) Received: from localhost ([::1]:52816 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQZZJ-0004Wp-Bm for incoming@patchwork.ozlabs.org; Wed, 06 Jun 2018 10:37:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50551) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fQZYf-0004Uk-80 for qemu-devel@nongnu.org; Wed, 06 Jun 2018 10:37:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fQZYb-0004ES-A6 for qemu-devel@nongnu.org; Wed, 06 Jun 2018 10:37:05 -0400 Received: from mail-by2nam01on0074.outbound.protection.outlook.com ([104.47.34.74]:28608 helo=NAM01-BY2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fQZYb-0004E6-0A for qemu-devel@nongnu.org; Wed, 06 Jun 2018 10:37:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HP0RagRc5AgEeksaUXsOj7Y3OBrz44iA7vm2HMdzO5M=; b=WSjlfSj/oRZIyA60KfH2IJnZMTPi/5SpW4k0JmGLOPV4uePNgzu9d9/d8VpWn+W0ctaUjIwW6NMa4GkGQJwX5xD5ZZWEEen8PnSA330Ei3W2m6bwj37Am+GUYD8OebTaQ2rB5UwrSvTS6P55A1IPBRCo4nF4CaS8dm05kqwxjp8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Babu.Moger@amd.com; Received: from linux-h3ml.amd.com (165.204.77.1) by MW2PR12MB2476.namprd12.prod.outlook.com (2603:10b6:907:9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.820.15; Wed, 6 Jun 2018 14:36:57 +0000 From: Babu Moger To: mst@redhat.com, marcel.apfelbaum@gmail.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mtosatti@redhat.com Date: Wed, 6 Jun 2018 10:36:44 -0400 Message-Id: <1528295806-90593-3-git-send-email-babu.moger@amd.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1528295806-90593-1-git-send-email-babu.moger@amd.com> References: <1528295806-90593-1-git-send-email-babu.moger@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN4PR0501CA0082.namprd05.prod.outlook.com (2603:10b6:803:22::20) To MW2PR12MB2476.namprd12.prod.outlook.com (2603:10b6:907:9::15) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:MW2PR12MB2476; X-Microsoft-Exchange-Diagnostics: 1; MW2PR12MB2476; 3:djidp+nVKat8R+DivJNkVGP8pgLi8yHJ1N3ysZcF+XerYY8PSyF1kkNR6JbXvN5QyUuPRunCYVY1TF/D8d7vYVkr/HVq/0kutQX0uvpPSKGIv1BTcFUDk2bfCcjTSQGOy1Tq0Czz6Hvmi2yIPZZ/AL4p+8cl0ueQxSH1awQvjAWCXuP9HNLwbq95oNaX0qckoXq8C/SqUkqauGjRK2sLnSTdn6wy4Y4LkWv1FlrF+vYCblr0p6+LltwdGpVXXBuJ; 25:veV15RSetZbBtqyu/al126VbahTo5/3pnYkfd2K3gyi6m4QB2ta9EryqosW2mQfZOqCqObTtR8nPqV7UcBexa+5gVFs7uAs0AxYkk36/k08NTINsCzJoCqUStbGJKwMwJVuKn6St8syGXOJTF9GnzOkHeV9Xdks+zEeuLLEr3C0SSkMLtL9u8dUYWI/Z8Swdd3NmnJoBz4dQCnJ0Gvdfra6J5bvX536gU3iaZtrs/LSSqT5TIbc7vjgQrz8x+n1Xe/KpSBg0jQ6cD0aGccZpTuke745ze/LvgV/vlPL4PXM/EsPv4tld696VZMR+gz8FVHUCPPAk/qUoKflfj0VpTg==; 31:oSIupgjN1sWOyELcgErqWsRFsMqQtxBHmVJ495MqmMNj4zxLIG4xFro6WNt3LiobnH1bHjOcm1nqrrLCW/sSYsKp8piEcS3ttYB/9BPKdOhaKRoQ//2SiBXYd430so9Aw7Fff5++AiLY9yuinNQyaRhltkoKeprBpX3LjE3K3m9thygfaUPSYOlNjvXeWOlj+XK+IHQkUiVzBv//K0xXfI38z60ml65EZ4J0ucCuk6c= X-MS-TrafficTypeDiagnostic: MW2PR12MB2476: X-Microsoft-Exchange-Diagnostics: 1; MW2PR12MB2476; 20:DreXhnZ5r0jpUYtyuiFhkg7CEHetoR1zhobKGxd6RyyXpyBdoSqJi3GtbmOwbuSTAX6lHN+eB0+5mTZrJCGxb9Y0Z1sXzYY0tbQjdJhe5GmJ8pOmrjiaLt45m3J62F73wuHpwKHpCiEhmv2UUijFyNWTj8JN9qKPrBOcMk5+IjcaBGPOpBOH7VB9TjEVjv7hr2Nr3UJDDPx6m5FDRbsHaoNlBY3ar4sS+YMVndy/OfPbz2xvhUMZKtQA0iONIsiErCdH7wmyOxO5KEmdcBCkdgAXZrvydkuM6kky1Kq+5X4HCkbpCyMJE/R0c0q1irVwcFFtorHsCza9yms7INxpoRCHYGdadKqSTLaSLNd6P6saE15kftMv47hG1UxFfEhDi2bA6ltu+Au0GW6GsJs9DMrqs7HPvsG4Us6BA4/zC+h9XcAlu+GLxdIqCJOGNYMaFpiwcCXkpghMGaiELYxbBrUwVMpZrLpucQRCyyfDc4hRGETFMaLFERZxYIYoKPrs; 4:Q4MeKlz/vEPPt70cwlsUH3WLDVP4nur4kDxNxBumn0OBpacHYQy0WnfKKjeHwGyRpY5PuflU/om6VpcvJHu6hPH5qWcUyFMKPgHXUmSFD6FzVeIsmc0T4MnmPAVRkQEOsYlZ3cz/48YtpTkmExI6l3Z3WmLSS8V3UxXeW9nymnBRCPKfS7IPxGsFolTs3Uii8UngWHjFxbXTnxBQXQUkBqw4m/aGaF8w/xBcXI5Xr8o+UchnJsX5l/lNpKtWnqCv3of2wshLHrC4DGKMRibRgEZrLjhsjiBT/HCSamSPsnEbT2w0kUX5NUCmUNJjGG2n X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231254)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:MW2PR12MB2476; BCL:0; PCL:0; RULEID:; SRVR:MW2PR12MB2476; X-Forefront-PRVS: 06952FC175 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(346002)(396003)(39860400002)(39380400002)(366004)(189003)(199004)(4720700003)(97736004)(26005)(50466002)(4326008)(39060400002)(7416002)(25786009)(3846002)(72206003)(6116002)(52116002)(47776003)(7696005)(386003)(478600001)(76176011)(66066001)(51416003)(5660300001)(81166006)(2906002)(446003)(11346002)(305945005)(8936002)(86362001)(6666003)(81156014)(16526019)(8676002)(53416004)(186003)(956004)(7736002)(44832011)(486006)(476003)(316002)(68736007)(36756003)(48376002)(105586002)(50226002)(16586007)(6486002)(106356001)(2616005)(53936002); DIR:OUT; SFP:1101; SCL:1; SRVR:MW2PR12MB2476; H:linux-h3ml.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MW2PR12MB2476; 23:120FR/xYw2Ha6B8cBhsEIKojw5/EVrqNIw5eRr4ur?= Y5r4arQCg1JyW2yQcjSX1pksgqu2HA4i4gTLICX/97C7sZtg6POb+QZ8L479Mrai5W8N6norcrXYSQqrIW3PHVdbLqPkkAbv7X2uHcIDkvDBDch+D4tSZvDNMR6p7asIrkHEWcSk5ir9f6BGgoimp8Jy9xEHZ4vwgjh8xugEqEvUMLRE5JIzfqRBELBu1o8O53esfviXwyiQkxx0qX3DM4fEMDFxHi8QA7TezTZa3RetQ0OevboLsyzmbihAEYt3H67WSqOII9+H4b9IY6E/vZV4q1EUntZ+/LTMo5kBwSfZDq0KJoY1luqh4UK0Y9gCvQa4bkcXXkhp0Yh75kPveXh5R1g/xIpoYgibmm7tAk39Rm3ljQyKbnpDTJuW0rsYO3idyPSTsnXbBDWoXDrg8pkE8f7y0FUiS9R9fcny44osapsLKu4Itk8+YXWdeYgsXsynoD3954aS7KpOkFat1c3jSFRn6pYt7z/A8vjtfY1wYSeFmx6rhfjsaywOwlyhL3644TBKuUUAGp6ydZS8Jpxx8xBlq2pSvo0eMcc38BBkiphzCsQI136sGTTJS92xcTt13YA466ossCEFu4yxcyREt7l/AHidWN+hJSDZKSI7DGf3apgyxSgyrxMKmiU55sVhKHJ8JSLx5HlIHZI/yX03y8Ns9wPGOIGaDNNVKcPtl/RtkDS3V8nL5iCk0ew4VnU28N+EKseBbSTmJynEB7KPJiDyNWuK/CWc6iHP/xrn82K4V5KaxZw/iny8B/w+qd+WM0K2LgRPo4WJmX1j/5JgacrHuA35AtHzot0BVuMvFNsDkuy6MQVz5w4xxq1IRRvRRy/gp5nmbI2KE+/WrtJ5xiE4PD+eHulj/E4FIyol9ENjC6vzHnqK2001tDJVq2mhJ7cZHsELJWArTVJG0L20l8kNQH6qPtDo2v3nv3dm2Zgq3KJbJI9RpC5q++0G84EVkprhWSlTNdhUUkBq363LXnGOoOwmX3tGQcu/Ha+QKMSNhhljr16pWa33H1OYn8G2C9g/Sp2FKlmjhfMlmyQSvJdDjYj1nAfTa6IK7V7hW2DDOgIOrB+N3j/ZCUWoy3GvjX9ARsrR7GtddAhOy7OMCR0FbZixopRUUll/BvbO0OTBpNz5Aa2zDZnvN6hAPVzQd3bR7MNcC2N+IUq+NZAykC2+lvp+o7MZ9r5ZywtBfTky295+LK9LFONMMXPBV/rvmSMx4pRHSBZnLOxk6e/ X-Microsoft-Antispam-Message-Info: OsAmoE1e48Q5oZ2JL64Ja/lZIaIEBzlBdk91jsPSFok9nN7nIYC4SazmuBSszvficciswmb1MSo4uO6ixNTucA8cELqNDNP/KBl2MPy1LhFZnTfqxqQ2ssgKO6QYpBetrzLOno0GKw1pEb6CfUQu2X4QSYtWBxavVUBJNVXnqbT8IEdxw9oaQh/gFoviC40Y X-Microsoft-Exchange-Diagnostics: 1; MW2PR12MB2476; 6:e5nU7y/nwOnA1NU4DXVoGfQNn7P2pZpQ8oPQ+XKS2v6cIDRSM0yMbJ5k3EgldRHZpne6G1LxKA/01hvevj9jf6aTiwJsb7o88Bcry5A7pSyI7LfQTKs3uEtfK9c/wPcgaXG1iLF3nnQGBEcgizxDgV1tTjLhTX9lEeImBYQRUIdwpzMji+DDOzjQfyXIcYwjfS9R7TNTY/QvTl5h7dsOPmOoHKjDMdW1x+1qalSr844xbSQI7mydzvBH9yN5yyyNbN7guIu4SFuc/YNKo/TQG/Ylpx+OgcbClOk8+ti+DjvmPrVF45ObFBZYtAN0QJMbbUQ8IAAOOMF7+e1J+dIk+bLQzqjZEtHt2adkmnvX5U5HQl7ZbgFy9Mo3QtnbGqowG2gtTyVSv0/Q1nvV6VTE6NXo6WniQ0FUWnrqbTjjnnBGBjeKW1ROmwgKXVa1hnlMtNmyh5gj4J9vbkF9OE7C+Q==; 5:kGdiTb584W4USbrdZz86338XqHf/AyEjMB8D86LanUGelEaDaZSTftSZT38e7/7JB6Kp62ishy5hCvATk1o/cB7lJjinkZpYoKkGUaZsfv6oKUXcw9rXVSUekdXNpFukTdpz5svnLiJxch0mcpdMEbFrxtBPg+AkZZSAT0GjtPE=; 24:DWOqBo5TtMqINry3V/63e5IQTZWQV0CD1R8Qy0iCRFlHKpn1E+FS/h35PKc9I1ly3RL1zaHcIfc2oucnKxsmWEbtVAqKbPFz9tKAp0qFbCI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; MW2PR12MB2476; 7:2GSaxOJUn9qVN4CDrg6cCCEOh2huovsYVEFVTyoXhiSjC1HHDyQii+Z7Iicm6UogOODSF7fzmed00wnvjwIBIMuRxOfG/aAQuRI6GFx+SVL20KuQIkHXVygb1992eFItlu1qYAqAQZZ71lox40j9vefb9HISUSlSyvHQH5W9qcS6DRqX5AVE3aRzclqBrB3W06G/bqThGvUDYX3JammPbRXJiOjERSFgKdE8WUv27CUtj3lxtmgNwZQLIHkq7A0U; 20:vifh+0vNqQpCzx1JBAYw8aEZL7wngSLddBlRESH6Xzo90bS9SfDoMSZ3jHrggkeV4xFA8K/Un3XKiqbSPuzLM4TQWQe5TwNTir8l4pm4WBhCySYdWdhHbjR3jISyrMZcaZ9/3SOMgyDFv1YqNFKLh/fyuQjrT7OB3J1nf+WIUqUjo5e7L1xK6KlMBzfGjMLD36rOm/oeJx/9ssB5Jwm7pm/sxX9usCYU/xia8ln2oWtVykJ1yUv39HlNXFdSL1NH X-MS-Office365-Filtering-Correlation-Id: a8a50e38-1509-4cfb-75fa-08d5cbbaf59c X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2018 14:36:57.8133 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a8a50e38-1509-4cfb-75fa-08d5cbbaf59c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2476 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.34.74 Subject: [Qemu-devel] [PATCH v12 2/4] i386: Verify if topoext feature can be supported X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: geoff@hostfission.com, babu.moger@amd.com, kash@tripleback.net, qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" topoext feature cannot be supported in certain cases with large number of cores or threads. Add the check. Signed-off-by: Babu Moger --- target/i386/cpu.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 86fb1a4..fc5c66d 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -509,6 +509,20 @@ static void encode_topo_cpuid8000001e(CPUState *cs, X86CPU *cpu, } /* + * Check if we can support this topology + * Fail if number of cores are beyond the supported config + * or nr_threads is more than 2 + */ +static int topology_supports_topoext(int nr_cores, int nr_threads) +{ + if ((nr_cores > (MAX_CORES_IN_NODE * MAX_NODES_PER_SOCKET)) || + (nr_threads > 2)) { + return 0; + } + return 1; +} + +/* * Definitions of the hardcoded cache entries we expose: * These are legacy cache values. If there is a need to change any * of these values please use builtin_x86_defs @@ -4941,6 +4955,19 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) qemu_init_vcpu(cs); + /* On AMD systems, check if we can support topoext feature */ + if (IS_AMD_CPU(env) && + (env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_TOPOEXT)) { + if (!topology_supports_topoext(cs->nr_cores, cs->nr_threads)) { + /* Cannot support topoext */ + error_setg(errp, "CPU model does not support topoext feature " + "with number of cores(%d) and threads(%d). " + "Please configure -smp options properly.", + cs->nr_cores, cs->nr_threads); + return; + } + } + /* Only Intel CPUs support hyperthreading. Even though QEMU fixes this * issue by adjusting CPUID_0000_0001_EBX and CPUID_8000_0008_ECX * based on inputs (sockets,cores,threads), it is still better to gives