From patchwork Tue Apr 10 23:16:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Babu Moger X-Patchwork-Id: 896977 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="lLh44agA"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40LNP94J5Lz9s1p for ; Wed, 11 Apr 2018 09:17:33 +1000 (AEST) Received: from localhost ([::1]:54626 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f62W3-0003MS-Hy for incoming@patchwork.ozlabs.org; Tue, 10 Apr 2018 19:17:31 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33823) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f62V9-0003IP-L7 for qemu-devel@nongnu.org; Tue, 10 Apr 2018 19:16:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f62V6-0005ji-FF for qemu-devel@nongnu.org; Tue, 10 Apr 2018 19:16:35 -0400 Received: from mail-by2nam01on0049.outbound.protection.outlook.com ([104.47.34.49]:54239 helo=NAM01-BY2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f62V6-0005jN-5B for qemu-devel@nongnu.org; Tue, 10 Apr 2018 19:16:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qCLlUWXHa4ebRbNlkP55KECxGff+MZ4RV8KAkJ9KkvQ=; b=lLh44agA2N0/FqFxBVbQ2Vp8PAEEV9oOsZiGcFjG3qMSQtYBj7GCeMv6OUnuBtr2uXWivTrvuxBGUjIbJ6er5erR729KNSmZJPy7b43x23yKLS8FckNdk2Lr9+MAe3Xxi/23IuqdqOREh3FxgqeEV/zgxOVutfBU4zY70LJojaM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Babu.Moger@amd.com; Received: from linux-pyp0.amd.com (165.204.77.1) by CY4PR12MB1767.namprd12.prod.outlook.com (2603:10b6:903:122::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Tue, 10 Apr 2018 23:16:28 +0000 From: Babu Moger To: mst@redhat.com, marcel@redhat.com, pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, mtosatti@redhat.com Date: Tue, 10 Apr 2018 19:16:08 -0400 Message-Id: <1523402169-113351-9-git-send-email-babu.moger@amd.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1523402169-113351-1-git-send-email-babu.moger@amd.com> References: <1523402169-113351-1-git-send-email-babu.moger@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: MWHPR2201CA0048.namprd22.prod.outlook.com (2603:10b6:301:16::22) To CY4PR12MB1767.namprd12.prod.outlook.com (2603:10b6:903:122::9) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(2017052603328)(7153060)(7193020); SRVR:CY4PR12MB1767; X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1767; 3:Dnl5wD6FJmsfRmTySaNjyZ679qBFYr/PtD02zyWarp/oJmJ9XbGvdntWw0DcHkxDwzFA9kzlpNoZisUxsEom3Ck4w0kCUANPSAUdOhJVjCXfEiymSrgJbmkBgZFgnOBLyvm+p2a7gyJtzImglwkST5CFhYDBH1sFw+ebsmwFv6DNdNx/VwxJ3299LqMxpQArH6PHR4oM0+WW05mwRwim6BNqNsQQvYYyd7MiEYP6Z1erOZO0Qm0RbQFXaLmqgkmt; 25:nbffVgLg0fVyrF3F3jv5bXmlIPPMsxDOtu6avmQqgiB34I91JbheMLE00ZidWHvBhBGGTxt5/1+6lGNg3Snp+fuy0A5qv0hvRFNEXddJC9PgF7diUWcUMu8DVaAuYW1na8uPsKS1sM8D4zgNLfKbbnBF37jcOjFJfy1SA+TpOECrTzQUiGbYHlQeWS1RGgC4lQ+joidlMUh+f+TcqXKMIFFLr0AEPueV7pFBcJG/AobRQyKkNjJjzgX2G7lIMqt3UJie4xeObsecHSR4HCVcknMorQ9P66n5HEYlwwrJ4uUqA7dZK9C0NcyF8VcU13IyG0YHn1QS1l3lxBDxR0rA4g==; 31:zjDF+2/sLHlOu7u6qRpd8h0vsebOX0uxMpX6EwE8NZvElT7dr91+r/ihSQ9c8DZJs3V1uJWjuRqyrM0hej3ka+G/rTQE0VP7TxQotNBEprK0oEisEKUZ2dVp+vYGA9r+rPo8bnV4wENNbBs3ROQLbZgCR3tgJXMNUxUQAJW/6HS0Uq/5BbC9qQVJ6FSNTMmxGufNzwAeaQ0nSCuw4H23aneLm8EkzJDRKPkVBAh+mVw= X-MS-TrafficTypeDiagnostic: CY4PR12MB1767: X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1767; 20:vKy4aOg0qvuhFp4l6qbCyHbe6Z4yleJDGrijiv/bv9a69UtuHoiyhf5BoDJ49lcn5O8qQ3D7ZzZaqXRLwCBMPSFq3Q+nw1e+jTU+zh+s64RgOh9TuLmciiVY3RZdXlkficK7C6CRZWj72cVuQPrUz7gUK7MWbqMjgq5sf7CY8Jy82PXRZWyMcDTbFO8xkAr/0ntK8LTxB8vl64bjquIcYJdmVB35pgl2qVtF2aKYkZHGv/+d1/lMmWwOHTyD8J4Z2GiiW9mnLLJZArTLr3TVAo4kjNV0lkrdmy/04mcDmhEeQTcPKVJ1GyMv+MKPxl6fpQzKJyaGDZYdJfAckWqv1PJaMGubHo1bdZblXegBiIhalUCBn+UP29IgI2WCzFtcHjn3zoAgHPWwxY/aotQEwEij44T+zsA1KadsLmSOGPzu2l5AHnAxqUeIbiBuoXtjfzIc0CFSpjaFLk5CFEGxmy16oApWiCh4V2XsJEBfc/wjBr4vME+hkddXBPKudSIy; 4:gQGgG5Qi/RG97MOa4iiszLx5TrgV7Pd6J5/a+jkEef2i2fvv9kHVLrxWPhs7ysXhZVL49T2UskktCakSWR0NZdsXPVPjSAoPQeSd6j9EX7cFN4Gmy57JGusbEfhRSVWchc0mPHcSw1MsJ7wj1ogMH09swCFHciq8rNr7RbB/Gsirlr3TKV/yBSvMzcZgr2Qwa7hVBm0z8vvHST1+tgEaRfyIrh94TzumwarMGbzNJfb1LE+UdzMgBOjIBYrOwa21HBIELd755kiTDjEMA5L0FfZbNiPHV+c8wQnscRfxvuuG57OajQAtaOVwKRUpHxX4 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231221)(944501327)(52105095)(3002001)(10201501046)(6055026)(6041310)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:CY4PR12MB1767; BCL:0; PCL:0; RULEID:; SRVR:CY4PR12MB1767; X-Forefront-PRVS: 0638FD5066 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(376002)(366004)(39860400002)(39380400002)(396003)(199004)(189003)(476003)(2906002)(52116002)(26005)(86362001)(50466002)(50226002)(305945005)(5660300001)(186003)(48376002)(7736002)(16526019)(6666003)(25786009)(6116002)(446003)(11346002)(105586002)(4720700003)(2616005)(6486002)(4326008)(956004)(3846002)(66066001)(53416004)(8936002)(386003)(72206003)(478600001)(316002)(16586007)(8676002)(81156014)(81166006)(59450400001)(97736004)(36756003)(47776003)(76176011)(106356001)(7416002)(7696005)(51416003)(68736007)(53936002)(486006)(217873001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR12MB1767; H:linux-pyp0.amd.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR12MB1767; 23:r0VyoCQQWJ9k9rqop/k+YyH0FaM7YOLXcZeIf17OQ?= sbGwm4qIp+9F8QBe8oz0s+VrPYwi++M84OhQF2opBFMTBPyXKrQ9T9dGDpH2b0WM5oRwF4e1qP8T8cYMc+Tx7e4wMGqMN7HH8pmnI4uND4BaoLP+/B0HWmbBDZjiYm8n+bezGv4gj0VQwEverUeIU8T4hE71hx6V5UCRKEfmlREB1a1naODsTxs8+w0XI9ObqHAoVnSP+MQJqeWN22GvC47pzgLIP+ko7SiW66ZnvqvemTJzhLYOkx0vFgVyLMENE/wvGM0T3RJRvAgxdG0i6SVbuYfrBgqEzYbD4rvZAh6jEA8UN29rhxCje1/gxcEMIEmr4nE0G7B7ZzzPyX/EZ7eKFntwpAWkooarbKWdbmcFgNmUIt+Cw+RFzgJ195QbY5XDofZ2WezHXIDnfRwpW7eMcDt+a3tIq57XpddSVlNoPZ/qKGbCirZp6z7p8rjg1wNTqSqhJl3zw/YGXF1a8lDkPncGwVDN4wEwgoqyKwm/LMMzhdF4lvMZGfWlMWSOQ4e+1xjK07QW0i62/TFPdjgtAW8+yZj5NzhZf24Du0aoGPkMFt+4tMM2FIl8JIin6J2qvKcSXcik5gC8iXTA5CR9SYSMRas+aPNarDwvoF5UNmHcaFBWHwIgBC+P2sVCcd6RSWrjZ42wyZdxP94fFULXN4yaQO8fwDDBvtmrv/pvA1h3gEBrTJLpWnn6nYfxG/aL+4el2cDMbyCEuHrAKBoK2MXh8uaehqNZ9q/j6eGka+3Oa167Gqk1dgrlKpr9TCcOsCg72ZHT73dM3ZE/uhrAg6BQ/R2aoqivcK31wczzL0CMzUqJh/jc4m0SMugAeQ3n2C2vWu1mlq7nGZV/sWcQZoJt9I3Ky++wqAtiYUtyiQALpGEfgf7QtgNHfqHYktrfnp/YiLTj3RiJpiOEXTn/WXuuhbwK5/rCrf7IEyqQHeUypfzCSLX3sVXPqifptjLRdQmSxJluZm3w/EEtXp9ONHKnL3IqPpwITzZuM2YZktbBKyWNd33XrpjbR/bpZ/ovtaIMzFN8oh1B2yLlNzpkAo9biwFsT5bIF0LaWAlff4DkMWopWH2PMN4qP2l59JNfywjRje7Sm4/8HfM93MkjBSEkwCRcYZj6cN9FXJdJAe1jZM6gHrQpgAIobitYAz3xT6Ryl+epsViMvub5q3Wt+jexchOxuziCCQld0DnEtDzgFs0cuHEhU3d1oX1GehFiMb3oU63dIyFieUeUnFF X-Microsoft-Antispam-Message-Info: rRp/9w5inEBNRCd+6Gwc+RDjWRqXJoLC/B8imBKT4RSsMY3NpouvnCu9YSsZwhvAGSDmMJpDvH/HADWNfAkCTLBYN51W/bDEwraPqllDeEkNsDZfBMOZ1IABByoTyQXJ9ZObbrysaLdop6zMdYKTHkEmbsYG2EDyVVikbbcS+66+54MPal0Dtk4xMoMk+6Z0 X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1767; 6:bPFPvT/XMa3vAXzE4cj156JTwlYx9ZEwSrtD+e9PhCBR4agzEo36lkXq0RT55sHcFpiG1qpEEz6seGpCIsHU9Nui6P3kRlLx9s/paMAh+1d53SPN/HDnEQl0Gf+/b3BJysuRXHkru71KC7oPJzpzi13dPff5e0vaCuFxRRrk4Q23K8CWRHghDkOvD7Sl/531+u60LkDG6Pz45Rw+ul2jY8Ecn1u6jritIeb+l9QmbQwhbbZg3RPP/xFGE5gTBzL6iP7tx7IhCtzOX5qo5tIZr8sXn3l13BvkWb6l6TibdddS6T7eLJ2xyRSgJ0pooqhfb8e+SmD4kyzF5Z5OMx2f96fqDRkdOThva86XyNFRHqvAClZWmmeOGkSAY1zyjQMKR12Sp8KO6iZcBhvMkhIk4+Z9LiugvJxrZmVSvIi4DJDa6IAtCHmH67tMFVkSVYeYulNtN82UEy7Amayqk1B83w==; 5:7xVTpSHAKlOFIlugsHW3hQI4Q4aZolE41agHbAkVCDKNhsdLokDuUmT89hu1FphY53O8PGZRsfLGmHak9n+h66nEkWVgBOq0YEPlMper6kB88X0tKaOURdjFwfPp2RX4bh/yRYSiKySsMwUh3rNjG7AK47CZc/h8IQUtcYm3adk=; 24:dAdG0hL9ypOlBDdw+M7nAJgddY7jHlwGQNkojffklVVQGWu7t+D6wsbpEz3NLuWlyWWm+cNPrq9SbcRumyiaIpFlDb6296Wx8P1vJ4CFZu8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR12MB1767; 7:CHowamAPHBuREfQBLllCOkgjzdh8X62doSr4IoNFDTJwZPBSzvmc1GBP7udAtQWddGEaS23hd+HJxVVP2eRTc/znQ/YvK2MBNaZw/zG5fMH7+0S40Zx9jolWQfnQpkEPvm944C/re0FxGu0jYMED6EJrGBQ8ay6G69lin7gqim7VIYIHfImeN6CotvyKUxdI0A/ZSYAZHUAv9db1GUHUakmqPqfnBP9zNZ7zGx8plKlMyd2iMr8hqOov+Q5c+OGj; 20:ycjz+p86PMcYJf6EX/HCIsWLed1ZxTJOFn3qeMpJ03uP6MnlOUOBKlOM313NnC48ZGEP3EeTnzD93vvcw4M4PbC9jFBCaBW3CODGOaQ81+2/pLFSTfbfJaQEwd/ZWIyAzbPWTlNklL/5KBGsCIkpom5rkIbIfBIQrep8GXkoVkqYts6uuLWP+om8O5wBYmaYDcIeuNiqYC67ulWHtHh5bhCKQIsrgSTHR5w6gJ4go4TiuirYcTgeZAQslDKkdkZK X-MS-Office365-Filtering-Correlation-Id: 3c599654-a330-4fec-c901-08d59f39177b X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Apr 2018 23:16:28.8421 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c599654-a330-4fec-c901-08d59f39177b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1767 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.34.49 Subject: [Qemu-devel] [PATCH v6 8/9] i386: Enable TOPOEXT feature on AMD EPYC CPU X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: geoff@hostfission.com, babu.moger@amd.com, kash@tripleback.net, qemu-devel@nongnu.org, kvm@vger.kernel.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Enable TOPOEXT feature on EPYC CPU. This is required to support hyperthreading on VM guests. Also extend xlevel to 0x8000001E. Signed-off-by: Babu Moger Tested-by: Geoffrey McRae --- target/i386/cpu.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 24b39c6..bfe24b9 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -2327,7 +2327,8 @@ static X86CPUDefinition builtin_x86_defs[] = { .features[FEAT_8000_0001_ECX] = CPUID_EXT3_OSVW | CPUID_EXT3_3DNOWPREFETCH | CPUID_EXT3_MISALIGNSSE | CPUID_EXT3_SSE4A | CPUID_EXT3_ABM | - CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM, + CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM | + CPUID_EXT3_TOPOEXT, .features[FEAT_7_0_EBX] = CPUID_7_0_EBX_FSGSBASE | CPUID_7_0_EBX_BMI1 | CPUID_7_0_EBX_AVX2 | CPUID_7_0_EBX_SMEP | CPUID_7_0_EBX_BMI2 | CPUID_7_0_EBX_RDSEED | @@ -2419,7 +2420,8 @@ static X86CPUDefinition builtin_x86_defs[] = { .features[FEAT_8000_0001_ECX] = CPUID_EXT3_OSVW | CPUID_EXT3_3DNOWPREFETCH | CPUID_EXT3_MISALIGNSSE | CPUID_EXT3_SSE4A | CPUID_EXT3_ABM | - CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM, + CPUID_EXT3_CR8LEG | CPUID_EXT3_SVM | CPUID_EXT3_LAHF_LM | + CPUID_EXT3_TOPOEXT, .features[FEAT_8000_0008_EBX] = CPUID_8000_0008_EBX_IBPB, .features[FEAT_7_0_EBX] = @@ -4572,6 +4574,11 @@ static void x86_cpu_expand_features(X86CPU *cpu, Error **errp) x86_cpu_adjust_level(cpu, &env->cpuid_min_xlevel, 0x8000000A); } + /* TOPOEXT feature requires 0x8000001E */ + if (env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_TOPOEXT) { + x86_cpu_adjust_level(cpu, &env->cpuid_min_xlevel, 0x8000001E); + } + /* SEV requires CPUID[0x8000001F] */ if (sev_enabled()) { x86_cpu_adjust_level(cpu, &env->cpuid_min_xlevel, 0x8000001F);