From patchwork Mon Mar 5 20:18:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Babu Moger X-Patchwork-Id: 881660 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=2001:4830:134:3::11; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="S6JAvMa/"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3zwB8Y5ms6z9sgB for ; Tue, 6 Mar 2018 07:19:41 +1100 (AEDT) Received: from localhost ([::1]:51362 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eswaB-0005DJ-Q2 for incoming@patchwork.ozlabs.org; Mon, 05 Mar 2018 15:19:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eswZR-00059v-Ss for qemu-devel@nongnu.org; Mon, 05 Mar 2018 15:18:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eswZO-000134-Ey for qemu-devel@nongnu.org; Mon, 05 Mar 2018 15:18:53 -0500 Received: from mail-cys01nam02on0041.outbound.protection.outlook.com ([104.47.37.41]:7093 helo=NAM02-CY1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eswZO-00012n-5i for qemu-devel@nongnu.org; Mon, 05 Mar 2018 15:18:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector1-amd-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=XNROgMkOlvUyPvw2KXtxVEs7heufm7Hmk3S/hs27810=; b=S6JAvMa/JB6fBs8ISaENqjUtsG1WtNOqhemXUQL8tz4CcTSzAPiPEoxZ65QKoaLloaR4GATGwmNmBGs0YryH+6YFvC72dWs9y2jU71zQUIWqyBv0WQ1D3BcMBAfaX6arq0ytnhXIe353JS13lNkwPYj7fwFDZlSJ+8sPf7cyUnA= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Babu.Moger@amd.com; Received: from linux-pyp0.amd.com (165.204.77.1) by BN6PR12MB1763.namprd12.prod.outlook.com (10.175.101.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Mon, 5 Mar 2018 20:18:45 +0000 From: Babu Moger To: pbonzini@redhat.com, rth@twiddle.net, ehabkost@redhat.com, rkrcmar@redhat.com Date: Mon, 5 Mar 2018 15:18:27 -0500 Message-Id: <1520281107-5115-6-git-send-email-babu.moger@amd.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1520281107-5115-1-git-send-email-babu.moger@amd.com> References: <1520281107-5115-1-git-send-email-babu.moger@amd.com> MIME-Version: 1.0 X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR1801CA0014.namprd18.prod.outlook.com (10.171.252.27) To BN6PR12MB1763.namprd12.prod.outlook.com (10.175.101.136) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 08721938-4a54-4631-6290-08d582d64cce X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:BN6PR12MB1763; X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1763; 3:9UoI6O+EO9fzXT4ZeZTNPO+MqtPAvXSWbXVJAPUkCfAlpemu24+m7DH0ZD8NL6ylVzo9JZ0VPlZbwN6c7HbQLBLKzDLZlPyp/GDpFXFc3PU6G2XL90B3n1/AAm/luPSml9zxkOkPqBZJ6e8MpKBqIq0pwSyorWEtptKSFNLMxtJpTbUrOjO3t5YQW7hGDWALDS3RtV7jf1GHhOXcT3S5ToP3GUzPEAdkF8vlLXSDb9+KS1DbK5fSDKUT4YtkCRzL; 25:/KxcyxvDC9r9crUO8I35Yg65uIACO5HfwIxMj8vN6IPWDyqjnWCQP2I/K44e1tUoTFBUBgYh/7rK0MWzCwsK6xLqFHhuVPDsk9tUqMvbwuBeB4TG7X2LJIFf7Z4UEAN3DbgdCL76Ms3hFPgQq1KDOJQPTMJ7GlLKPAJEQAgCOH/CYkuk24Xf96+o6dfp1/LKIB1McuqSytFL84hvVG1n/1NlFqn8tqWUGdbeR40NaZGlp6ZTM2LNp4N3mmz8NYJDhXSZPMYniJ+R/BbOkDbyM8xvL2gSiMIH4o+UQ27a0UsCUh0C4hwkey/qHb3C7jnA1EB3PYnCTXXj9ITsm+YvjA==; 31:JRwQ2vzPa+nl4G+8UpYsW7qcr81EGXh+RL52zddjkDIIMCw9fYyyr2LJcRXMq/pRe3jLXUWa5jS263rNVijj2iNa+lz0E8xOKRblTuS5N1OSSevjqHOT5mD7vsvyv6PYTKLmDCHoTVfIhUv0Tecxf5CJql0U4WM8hx6BM7dCkClgbD1QnYSRiPGkCqtuXnMVDNJLysMD0refXstNnqRmWYaisZHdVg0FEkvjdJtP8SY= X-MS-TrafficTypeDiagnostic: BN6PR12MB1763: X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1763; 20:iBneHBLURtxUIxNLvHa1K5UTWAiT2P1+pO8tKfLZomTnBiOp2RzUGePEtJEEw5SF4K+jhSgDDPwvGywF2rD1NrTtanJwSGQ5JmE3RVU3T+YIzQwdVCPPDzNz5TXs+mlkdwZ15ncSukIuT3BKa1/y8ewXpvhABheJnlx/ax2g+LrgEx/R8d5Y5I4hnORHzGY4c7spacdlswLRxhF5zy/HSmxqL7gVaQE7A8GUPZY9ZHORoK2lO0ZBlgGG9092UBomf8XUzgVt7qxnyBr14XJLvd01BINDa0oQwS2yPtGjxdtzLZwzSV2l25NKQY//+6AnRaPLjx89/u36oXzfNznXHlhfTiOR65zdWKXGwU6BKG6wxNg0Yd9cd5cKvtiv+e+A0AJlENg4BqOIwYn9eo62Cc09nD/3tIS9TW2F3gwJtccjn/7MfmXm4/4DzH31SYdOdsoWmuXf+bDMmZBE47z2zyhwfMTkigtQy/A/Y3Yow+6EKGUUY+dXLcmmORzZEYir; 4:L0WzhBfEQATgtWVyQKpirwB51FO4w+gy+KBQjiOnyctjcn8mfZ0c93L+9Ss+Z3oVZXtMHSnciFC9FwANajMlpouTZgIxTE9Eh1BISR+sE5nN552b0hU7wc5EGE/XtFhfix97qAR+WsC6QpIktJ1HHqIJK/9WFu9g1+s2T6Vj0reTCm2bQldGAPlU8RNFnhGQqmpw08PAqWpC45lnam2nJZ59eRWzh5xlcMlFV87dgqHWDH+RoUjdp4Dazz71td33l3YD9xtlx4wklUD1cqcCqFiSCjc+2VhjKIbSsa46u125lge49h80D9EBoQlxEq8L X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(10201501046)(3231220)(944501244)(52105095)(3002001)(93006095)(93001095)(6055026)(6041288)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123564045)(6072148)(201708071742011); SRVR:BN6PR12MB1763; BCL:0; PCL:0; RULEID:; SRVR:BN6PR12MB1763; X-Forefront-PRVS: 06022AA85F X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(39380400002)(396003)(366004)(376002)(346002)(189003)(199004)(2950100002)(4720700003)(2906002)(106356001)(66066001)(6666003)(97736004)(25786009)(36756003)(5660300001)(478600001)(48376002)(81166006)(81156014)(8676002)(72206003)(47776003)(8936002)(50226002)(4326008)(59450400001)(105586002)(50466002)(26005)(6486002)(305945005)(16586007)(186003)(16526019)(316002)(52116002)(53936002)(7696005)(68736007)(53416004)(3846002)(6116002)(386003)(51416003)(7736002)(76176011)(86362001)(41533002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR12MB1763; H:linux-pyp0.amd.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR12MB1763; 23:itaTrcCODj64isrrJuUaP1OncaARnjTpV0kh00nj0?= Pk6wY6zCpRNdTjcLXZQTe+bjPY62neVdC8RxrH6GqMF9ZQMHM7BPwnzxxiI8dyzIpBTCglzfhNwWH1uMTRaKFG4mZcaxh/5r50rXeXIlxqeZPZw+UVr/BstukAmiKpMN8cpomn58NkhCtBbxZcHeagyGMAIkIhMPlUiRNzFmkm7hvayAVc5xazojZiu6lwYTtBd+/XOIQLtdZIO8xsuyYUb9VaU49cL2fPBkKFnr9EsCfE8A4Rc3MnBI8B6vhXyoDwUGpB61bIzbf/VEV8vyALk72UX/qRIKU1EnQkyM2/3siC3zgc+uUWugKo4E+/7vYUiS0KEtqijwHzlyDDTvZejM3suFecaNdvGvFqH/ozLwYN5Tu0nda67kK+jZYtbkzltWxu4IkJm2RbS1/rG6wvggd4eiMJKaMo381YGDdM0VfTLJzWBZLnu1GcbE/pOsUdER5lxjhgoS0bplBpSOGX/MBAZPbo55w58OBacHQb25eudugwI51QOArHqLlFLx2QVXxl7I+UAf1rmOntjV/f0+fPyvNXx067s4q24jk/8RafEuDwGTu28C8/UuT/Yckrhv6P+chiqhI1b6wTZmy36eXIvmUZrKMdvYXk4PMsbyeZlnzlUaMryuKJNJInLZdlxMITcCd0ndOtReyoDpFhb5O7dAI0DUoCbLI+PFqmVKSFE6oOZUqKt1rnVTGk1U8sHr3yCWlo066orM2oAmPxJzPR5sldZiA7LzJetxoQn7jve7Iy3WxYQx+9RETRXHFxt/ywPc17teHHKwrcOwSe6rXfVeFmup2AULqYKTILCuAAh7S8Xfo8wptavPFeq7tkHT8A0+XNIoPj+IAOEDV4IvB40veIqk8NbCH7AxI6Bhz8VLGsiqnXcllIbG8aBDhPb2r/IAYGgUSUM4gGobiMD9h15dUI7OMcI/+8u3WoTs4BoZLOluzUrcc/1OlmJqkBY1VoH316fUNwwSgRYxbb8w0x7EaAGrMOKOZ3TCA/C3J9srhyjkNRENuI6MpsPqnbOAKfVCNjkSZUMv0b/Pj5MIqWUwuWOPuie6DzAHT4r2PDQIoi76MgqWrsxOo0qE64HyYyWDC7tbM4uAflrAjXwK/2p9nzzk54amGdpZgT8pEteisgND4v1Q/sPs/aCPNs= X-Microsoft-Antispam-Message-Info: zCKNHfx4zPjQfC2Zg4xco2xv+UpNiQR+dT8+nSLqN7trnTYusUWpfvI8Xno/5rZnqq1JfFPzw5J2OStCDOne3f1S1QPFyd0DuD4bplSF/NXMls2gQJalOlHIJbLrBRNOyL51Rn4oWTigoa1muEmm2jPHs2n9t3nTYECLUV/isdnj2px4kCfELkTkZx3ptIud X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1763; 6:MuJxD5o5+DXNPVU7IJ48pGlxES4AeWCY/XJ+AfEQFD6jSnrhtGwaPM/oCM98RpraDH4ENJ2RCU+uWUUNrLXBSRfsr3Xsvs1mnPtjlU7ow2XwMTbNLUElNvQ9/0b3P2OShp6ZtXFJn8x4SnMp8N3OJnN4TaX2S5bi3zBdUTuGWqFnvqhBJu/H0CmYTEKbOc0XoL7Imy8saztU2DLvZhmdQcTmJo8xqFbx5NXgLrr5yeWTDU8C/Ri+3wdNbvao/TeuS+aKNTXvf0seJh01FZJYRzB4lLi74AU5YUuKzNYgBL60euGwsFw1mtrhoXJaT0RGw1R/lnsG6qCE224MG8dz06Ke+CN09GZBxSTTGNKrmRw=; 5:/pMqS1sZqExb7hBnNjSKtR4MN1CknYfagiGJZgxi56qayOeEVqG040fuxppS6+gw8PhLjaTzzmdVcBfjHCNgbqwD5olnKFO86Xw9AKlQUYgMsx4Af9t2Ic4RHBnQKwjzhOt1dGArmAUjJYqNAWMNsvkHR7LwkStgIS1SpHc9lcY=; 24:RcNG5opD87xQFXDTvoRwh+E3zUGlAk6a3QcRd0n2mrF4GJZ7Bp5j2OaZRJLaXRnpPYhifBufq+dTx7PpGdlVmv067kGS2zFpbkfdUH3Et+A=; 7:7l36YfI0JyiF5Eb3JE+TgVjfsrSrtNNdPWnm8v7hd9Eyw6hWqmDefFDBkspVyZY4WCWCi+PYm2Z/Inh7MeQb2cuzvU2A4zZJTk2WRzzgdzLQiVigsJk2ML2vqtAV2IbjWvSIurFXLWer1icrwtIFCRikz07U6P+OvKx7YJE9NF7rXn3WjgxZljuJ7CPhOaz6pT2AzlzkFIULjvV43ECz+YM0uhRMM9y9Die2kaNWTGBb5SGzHHC5i96gp7CZSj6Z SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR12MB1763; 20:0sNEiXesZ8Q1YS9ur9aD7nYrydlMifeVQoRi2H1Fz2Cwilzorp2Y5mK2pcTZKL9AJUyDSi9GUD6MSBI1U8rsORqbp7yK9A6SYiNY6HGVjNzb12T2Ojep2JWFVC/bB+b2LOnfKF3CUOh4FF2VnMTLCT/S34SGjArtEOkdtiK4xrr5k/rrM3cFD9TDQnNg+sMGfQEmSi+KWetLpmXWJQuWrIm8vCOApb5dZbYzCJUMq9NUsukIQk3EHYy8T9xf0TYa X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2018 20:18:45.4749 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 08721938-4a54-4631-6290-08d582d64cce X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1763 X-detected-operating-system: by eggs.gnu.org: Windows 7 or 8 [fuzzy] X-Received-From: 104.47.37.41 Subject: [Qemu-devel] [PATCH v3 5/5] target/i386: Remove generic SMT thread check X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas.Lendacky@amd.com, kvm@vger.kernel.org, mtosatti@redhat.com, Gary.Hook@amd.com, qemu-devel@nongnu.org, babu.moger@amd.com Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Remove generic non-intel check while validating hyperthreading support. Certain AMD CPUs can support hyperthreading now. CPU family with TOPOEXT feature can support hyperthreading now. Signed-off-by: Babu Moger --- target/i386/cpu.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index 88941d9..0eb319d 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -4337,17 +4337,20 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) qemu_init_vcpu(cs); - /* Only Intel CPUs support hyperthreading. Even though QEMU fixes this - * issue by adjusting CPUID_0000_0001_EBX and CPUID_8000_0008_ECX - * based on inputs (sockets,cores,threads), it is still better to gives + /* Most Intel and certain AMD CPUs support hyperthreading. Even though QEMU + * fixes this issue by adjusting CPUID_0000_0001_EBX and CPUID_8000_0008_ECX + * based on inputs (sockets,cores,threads), it is still better to give * users a warning. * * NOTE: the following code has to follow qemu_init_vcpu(). Otherwise * cs->nr_threads hasn't be populated yet and the checking is incorrect. */ - if (!IS_INTEL_CPU(env) && cs->nr_threads > 1 && !ht_warned) { - error_report("AMD CPU doesn't support hyperthreading. Please configure" - " -smp options properly."); + if (IS_AMD_CPU(env) && + !(env->features[FEAT_8000_0001_ECX] & CPUID_EXT3_TOPOEXT) && + cs->nr_threads > 1 && !ht_warned) { + error_report("This family of AMD CPU doesn't support " + "hyperthreading. Please configure -smp " + "options properly."); ht_warned = true; }